| Message ID | ZoJhQVF-U6sSJ_Sg@fedora |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: Add missing include for FIELD_*() | expand |
On 7/1/24 00:56, Matti Vaittinen wrote: > The FIELD_PREP() and FIELD_GET() macros are defined in the > linux/bitfield.h. Include this header to avoid missing the macro > definitions. > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202406300817.hcJ9VtLf-lkp@intel.com/ > Acked-by: Guenter Roeck <linux@roeck-us.net> > --- > This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag. > These macros got included via some indirect route in my build > config on v6.10-rc1 - but the lkp reported problem on some config. > > Please, let me know if this follow-up fix is Ok or if I should rather > respin the: > https://lore.kernel.org/all/20240627082555.GH2532839@google.com/ > with this fix. (I don't see much of potential bisecting problems if this > fix still gets in the next release, as the watchdog code is behind a new > Kconfig flag - but please let me know if I should re-spin whole series). > --- > drivers/watchdog/bd96801_wdt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c > index ff51f42ced2a..12b74fd2bc05 100644 > --- a/drivers/watchdog/bd96801_wdt.c > +++ b/drivers/watchdog/bd96801_wdt.c > @@ -5,6 +5,7 @@ > * ROHM BD96801 watchdog driver > */ > > +#include <linux/bitfield.h> > #include <linux/interrupt.h> > #include <linux/kernel.h> > #include <linux/mfd/rohm-bd96801.h> > > base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f
On Mon, 01 Jul 2024 10:56:49 +0300, Matti Vaittinen wrote: > The FIELD_PREP() and FIELD_GET() macros are defined in the > linux/bitfield.h. Include this header to avoid missing the macro > definitions. > > Applied, thanks! [1/1] watchdog: Add missing include for FIELD_*() commit: e53cb372d75b5912fc72d9eebe8d37620fb58056 -- Lee Jones [李琼斯]
diff --git a/drivers/watchdog/bd96801_wdt.c b/drivers/watchdog/bd96801_wdt.c index ff51f42ced2a..12b74fd2bc05 100644 --- a/drivers/watchdog/bd96801_wdt.c +++ b/drivers/watchdog/bd96801_wdt.c @@ -5,6 +5,7 @@ * ROHM BD96801 watchdog driver */ +#include <linux/bitfield.h> #include <linux/interrupt.h> #include <linux/kernel.h> #include <linux/mfd/rohm-bd96801.h>
The FIELD_PREP() and FIELD_GET() macros are defined in the linux/bitfield.h. Include this header to avoid missing the macro definitions. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202406300817.hcJ9VtLf-lkp@intel.com/ --- This patch is built on the ib-mfd-regulator-watchdog-v6.11 tag. These macros got included via some indirect route in my build config on v6.10-rc1 - but the lkp reported problem on some config. Please, let me know if this follow-up fix is Ok or if I should rather respin the: https://lore.kernel.org/all/20240627082555.GH2532839@google.com/ with this fix. (I don't see much of potential bisecting problems if this fix still gets in the next release, as the watchdog code is behind a new Kconfig flag - but please let me know if I should re-spin whole series). --- drivers/watchdog/bd96801_wdt.c | 1 + 1 file changed, 1 insertion(+) base-commit: fcf1f960a6aa45a22efd4d49114c672ed305b85f