| Message ID | 20240710061102.1323550-6-quic_varada@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v6,1/9] soc: qcom: cpr3: Fix 'acc_desc' usage | expand |
On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > Add the APC power domain definitions used in IPQ9574. > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- Could you please confirm [1]? Konrad [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/
On Tue, Jul 16, 2024 at 02:15:12PM +0200, Konrad Dybcio wrote: > On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > Add the APC power domain definitions used in IPQ9574. > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > --- > > Could you please confirm [1]? > > Konrad > > [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/ The author is off for a few days. Will get back to you once he is in. Thanks Varada
On Wed, Jul 17, 2024 at 02:44:08PM +0530, Varadarajan Narayanan wrote: > On Tue, Jul 16, 2024 at 02:15:12PM +0200, Konrad Dybcio wrote: > > On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > Add the APC power domain definitions used in IPQ9574. > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > --- > > > > Could you please confirm [1]? > > > > Konrad > > > > [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/ > > The author is off for a few days. Will get back to you once he is in. Have responded to that query. Please see https://lore.kernel.org/linux-arm-msm/ZqCCpf1FwLWulSgr@hu-varada-blr.qualcomm.com/ Thanks Varada
On Wed, Jul 24, 2024 at 10:02:31AM GMT, Varadarajan Narayanan wrote: > On Wed, Jul 17, 2024 at 02:44:08PM +0530, Varadarajan Narayanan wrote: > > On Tue, Jul 16, 2024 at 02:15:12PM +0200, Konrad Dybcio wrote: > > > On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > > > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > > > Add the APC power domain definitions used in IPQ9574. > > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > --- > > > > > > Could you please confirm [1]? > > > > > > Konrad > > > > > > [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/ > > > > The author is off for a few days. Will get back to you once he is in. > > Have responded to that query. Please see https://lore.kernel.org/linux-arm-msm/ZqCCpf1FwLWulSgr@hu-varada-blr.qualcomm.com/ If it responds to voltage values, please model it as a regulator rather than a power domain.
On Wed, 24 Jul 2024 at 19:26, Dmitry Baryshkov <dmitry.baryshkov@linaro.org> wrote: > > On Wed, Jul 24, 2024 at 10:02:31AM GMT, Varadarajan Narayanan wrote: > > On Wed, Jul 17, 2024 at 02:44:08PM +0530, Varadarajan Narayanan wrote: > > > On Tue, Jul 16, 2024 at 02:15:12PM +0200, Konrad Dybcio wrote: > > > > On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > > > > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > > > > > Add the APC power domain definitions used in IPQ9574. > > > > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > > --- > > > > > > > > Could you please confirm [1]? > > > > > > > > Konrad > > > > > > > > [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/ > > > > > > The author is off for a few days. Will get back to you once he is in. > > > > Have responded to that query. Please see https://lore.kernel.org/linux-arm-msm/ZqCCpf1FwLWulSgr@hu-varada-blr.qualcomm.com/ > > If it responds to voltage values, please model it as a regulator rather > than a power domain. Just wanted to give my brief opinion around this too. I agree that it seems to make sense to model it as a regulator, but that doesn't necessarily mean that we shouldn't model it as a power-domain too. If it is a power-domain it should be modelled like that - and then the power-domain provider should be assigned as the consumer of that regulator. Kind regards Uffe
On Mon, Aug 05, 2024 at 12:32:34PM +0200, Ulf Hansson wrote: > On Wed, 24 Jul 2024 at 19:26, Dmitry Baryshkov > <dmitry.baryshkov@linaro.org> wrote: > > > > On Wed, Jul 24, 2024 at 10:02:31AM GMT, Varadarajan Narayanan wrote: > > > On Wed, Jul 17, 2024 at 02:44:08PM +0530, Varadarajan Narayanan wrote: > > > > On Tue, Jul 16, 2024 at 02:15:12PM +0200, Konrad Dybcio wrote: > > > > > On 10.07.2024 8:10 AM, Varadarajan Narayanan wrote: > > > > > > From: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > > > > > > > Add the APC power domain definitions used in IPQ9574. > > > > > > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > > Signed-off-by: Praveenkumar I <quic_ipkumar@quicinc.com> > > > > > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > > > > > > --- > > > > > > > > > > Could you please confirm [1]? > > > > > > > > > > Konrad > > > > > > > > > > [1] https://lore.kernel.org/linux-arm-msm/57dadb35-5dde-4127-87aa-962613730336@linaro.org/ > > > > > > > > The author is off for a few days. Will get back to you once he is in. > > > > > > Have responded to that query. Please see https://lore.kernel.org/linux-arm-msm/ZqCCpf1FwLWulSgr@hu-varada-blr.qualcomm.com/ > > > > If it responds to voltage values, please model it as a regulator rather > > than a power domain. > > Just wanted to give my brief opinion around this too. > > I agree that it seems to make sense to model it as a regulator, but > that doesn't necessarily mean that we shouldn't model it as a > power-domain too. > > If it is a power-domain it should be modelled like that - and then the > power-domain provider should be assigned as the consumer of that > regulator. Have posted V7 (without modelling as power-domain). Please review. Thanks Varada
diff --git a/drivers/pmdomain/qcom/rpmpd.c b/drivers/pmdomain/qcom/rpmpd.c index 5e6280b4cf70..947d6a9c3897 100644 --- a/drivers/pmdomain/qcom/rpmpd.c +++ b/drivers/pmdomain/qcom/rpmpd.c @@ -38,6 +38,7 @@ static struct qcom_smd_rpm *rpmpd_smd_rpm; #define KEY_FLOOR_CORNER 0x636676 /* vfc */ #define KEY_FLOOR_LEVEL 0x6c6676 /* vfl */ #define KEY_LEVEL 0x6c766c76 /* vlvl */ +#define RPM_KEY_UV 0x00007675 /* "uv" */ #define MAX_CORNER_RPMPD_STATE 6 @@ -644,6 +645,23 @@ static const struct rpmpd_desc mdm9607_desc = { .max_state = RPM_SMD_LEVEL_TURBO, }; +static struct rpmpd apc_s1_lvl = { + .pd = { .name = "apc", }, + .res_type = RPMPD_SMPA, + .res_id = 1, + .key = RPM_KEY_UV, +}; + +static struct rpmpd *ipq9574_rpmpds[] = { + [IPQ9574_VDDAPC] = &apc_s1_lvl, +}; + +static const struct rpmpd_desc ipq9574_desc = { + .rpmpds = ipq9574_rpmpds, + .num_pds = ARRAY_SIZE(ipq9574_rpmpds), + .max_state = RPM_SMD_LEVEL_TURBO_HIGH, +}; + static struct rpmpd *msm8226_rpmpds[] = { [MSM8226_VDDCX] = &cx_s1a_corner, [MSM8226_VDDCX_AO] = &cx_s1a_corner_ao, @@ -931,6 +949,7 @@ static const struct rpmpd_desc qcm2290_desc = { }; static const struct of_device_id rpmpd_match_table[] = { + { .compatible = "qcom,ipq9574-rpmpd", .data = &ipq9574_desc }, { .compatible = "qcom,mdm9607-rpmpd", .data = &mdm9607_desc }, { .compatible = "qcom,msm8226-rpmpd", .data = &msm8226_desc }, { .compatible = "qcom,msm8909-rpmpd", .data = &msm8916_desc },