Message ID | 20240722092735.1109925-1-arnd@kernel.org |
---|---|
State | New |
Headers | show |
Series | [1/2] Bluetooth: btmtk: Fix btmtk.c undefined reference build error harder | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=872895 ---Test result--- Test Summary: CheckPatch FAIL 1.37 seconds GitLint FAIL 0.69 seconds SubjectPrefix PASS 0.13 seconds BuildKernel PASS 29.64 seconds CheckAllWarning PASS 31.93 seconds CheckSparse PASS 37.56 seconds CheckSmatch PASS 101.74 seconds BuildKernel32 PASS 28.62 seconds TestRunnerSetup PASS 524.61 seconds TestRunner_l2cap-tester PASS 23.89 seconds TestRunner_iso-tester PASS 29.11 seconds TestRunner_bnep-tester PASS 4.84 seconds TestRunner_mgmt-tester PASS 108.95 seconds TestRunner_rfcomm-tester PASS 7.44 seconds TestRunner_sco-tester PASS 15.09 seconds TestRunner_ioctl-tester PASS 7.88 seconds TestRunner_mesh-tester PASS 5.97 seconds TestRunner_smp-tester PASS 6.89 seconds TestRunner_userchan-tester PASS 4.99 seconds IncrementalBuild PASS 33.35 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script Output: [2/2] Bluetooth: btmtk: remove #ifdef around declarations WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?) #81: 2720 | urb = alloc_mtk_intr_urb(hdev, skb, btusb_tx_complete); total: 0 errors, 1 warnings, 14 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13738574.patch has style problems, please review. NOTE: Ignored message types: UNKNOWN_COMMIT_ID NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [2/2] Bluetooth: btmtk: remove #ifdef around declarations WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 10: B1 Line exceeds max length (133>80): "drivers/bluetooth/btusb.c:2705:15: error: implicit declaration of function 'btmtk_usb_subsys_reset' [-Wimplicit-function-declaration]" 14: B1 Line exceeds max length (129>80): "drivers/bluetooth/btusb.c:2720:23: error: implicit declaration of function 'alloc_mtk_intr_urb' [-Wimplicit-function-declaration]" 17: B1 Line exceeds max length (142>80): "drivers/bluetooth/btusb.c:2720:21: error: assignment to 'struct urb *' from 'int' makes pointer from integer without a cast [-Wint-conversion]" --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 22 Jul 2024 11:27:05 +0200 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The previous fix was incomplete as the link failure still persists > with CONFIG_USB=m when the sdio or serial wrappers for btmtk.c > are build-in: > > btmtk.c:(.text+0x468): undefined reference to `usb_alloc_urb' > btmtk.c:(.text+0x488): undefined reference to `usb_free_urb' > btmtk.c:(.text+0x500): undefined reference to `usb_anchor_urb' > btmtk.c:(.text+0x50a): undefined reference to `usb_submit_urb' > btmtk.c:(.text+0x92c): undefined reference to `usb_control_msg' > btmtk.c:(.text+0xa92): undefined reference to `usb_unanchor_urb' > btmtk.c:(.text+0x11e4): undefined reference to `usb_set_interface' > btmtk.c:(.text+0x120a): undefined reference to `usb_kill_anchored_urbs' > > [...] Here is the summary with links: - [1/2] Bluetooth: btmtk: Fix btmtk.c undefined reference build error harder https://git.kernel.org/bluetooth/bluetooth-next/c/0f6bd069a04a - [2/2] Bluetooth: btmtk: remove #ifdef around declarations https://git.kernel.org/bluetooth/bluetooth-next/c/3a493d96e81c You are awesome, thank you!
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 44a2de58337b..082698675849 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -413,6 +413,7 @@ config BT_ATH3K config BT_MTKSDIO tristate "MediaTek HCI SDIO driver" depends on MMC + depends on USB || !BT_HCIBTUSB_MTK select BT_MTK help MediaTek Bluetooth HCI SDIO driver. @@ -425,6 +426,7 @@ config BT_MTKSDIO config BT_MTKUART tristate "MediaTek HCI UART driver" depends on SERIAL_DEV_BUS + depends on USB || !BT_HCIBTUSB_MTK select BT_MTK help MediaTek Bluetooth HCI UART driver.