| Message ID | 20240724045659.160684-1-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/rx: Use target_ulong for address in LI | expand |
On 24/07/2024 06.56, Richard Henderson wrote: > Using int32_t meant that the address was sign-extended to uint64_t > when passing to translator_ld*, triggering an assert. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2453 > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/rx/translate.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target/rx/translate.c b/target/rx/translate.c > index 9b81cf20b3..9aade2b6e5 100644 > --- a/target/rx/translate.c > +++ b/target/rx/translate.c > @@ -85,7 +85,8 @@ static uint32_t decode_load_bytes(DisasContext *ctx, uint32_t insn, > > static uint32_t li(DisasContext *ctx, int sz) > { > - int32_t tmp, addr; > + target_ulong addr; > + uint32_t tmp; > CPURXState *env = ctx->env; > addr = ctx->base.pc_next; > Thank you very much! This fixes the problem for me. Tested-by: Thomas Huth <thuth@redhat.com>
diff --git a/target/rx/translate.c b/target/rx/translate.c index 9b81cf20b3..9aade2b6e5 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -85,7 +85,8 @@ static uint32_t decode_load_bytes(DisasContext *ctx, uint32_t insn, static uint32_t li(DisasContext *ctx, int sz) { - int32_t tmp, addr; + target_ulong addr; + uint32_t tmp; CPURXState *env = ctx->env; addr = ctx->base.pc_next;
Using int32_t meant that the address was sign-extended to uint64_t when passing to translator_ld*, triggering an assert. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2453 Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/rx/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)