| Message ID | 20240725220608.131426-1-quic_abhinavk@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: qcom: com-qmp-combo: fix swing and pre-emphasis table for sm8350 | expand |
On Fri, 26 Jul 2024 at 01:06, Abhinav Kumar <quic_abhinavk@quicinc.com> wrote: > > Fix the voltage swing and pre-emphasis tables for sm8350 as the current > one do not match the hardware docs. > > Fixes: ef14aff107bd ("phy: qcom: com-qmp-combo: add SM8350 & SM8450 support") > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> # SM8350-HDK
On 25-07-24, 15:06, Abhinav Kumar wrote: > Fix the voltage swing and pre-emphasis tables for sm8350 as the current > one do not match the hardware docs. > > Fixes: ef14aff107bd ("phy: qcom: com-qmp-combo: add SM8350 & SM8450 support") > Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> > --- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > index 31e43638a649..c15b01aa5a48 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c > @@ -1946,8 +1946,8 @@ static const struct qmp_phy_cfg sm8350_usb3dpphy_cfg = { > > .swing_hbr_rbr = &qmp_dp_v4_voltage_swing_hbr_rbr, > .pre_emphasis_hbr_rbr = &qmp_dp_v4_pre_emphasis_hbr_rbr, > - .swing_hbr3_hbr2 = &qmp_dp_v3_voltage_swing_hbr3_hbr2, > - .pre_emphasis_hbr3_hbr2 = &qmp_dp_v4_pre_emphasis_hbr3_hbr2, > + .swing_hbr3_hbr2 = &qmp_dp_v5_voltage_swing_hbr3_hbr2, > + .pre_emphasis_hbr3_hbr2 = &qmp_dp_v5_pre_emphasis_hbr3_hbr2, This is fine but you need to drop the unused qmp_dp_v4_pre_emphasis_hbr3_hbr2 table... It adds a warning, defined but unused!
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index 31e43638a649..c15b01aa5a48 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -1946,8 +1946,8 @@ static const struct qmp_phy_cfg sm8350_usb3dpphy_cfg = { .swing_hbr_rbr = &qmp_dp_v4_voltage_swing_hbr_rbr, .pre_emphasis_hbr_rbr = &qmp_dp_v4_pre_emphasis_hbr_rbr, - .swing_hbr3_hbr2 = &qmp_dp_v3_voltage_swing_hbr3_hbr2, - .pre_emphasis_hbr3_hbr2 = &qmp_dp_v4_pre_emphasis_hbr3_hbr2, + .swing_hbr3_hbr2 = &qmp_dp_v5_voltage_swing_hbr3_hbr2, + .pre_emphasis_hbr3_hbr2 = &qmp_dp_v5_pre_emphasis_hbr3_hbr2, .dp_aux_init = qmp_v4_dp_aux_init, .configure_dp_tx = qmp_v4_configure_dp_tx,
Fix the voltage swing and pre-emphasis tables for sm8350 as the current one do not match the hardware docs. Fixes: ef14aff107bd ("phy: qcom: com-qmp-combo: add SM8350 & SM8450 support") Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com> --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)