| Message ID | 1479138250-17780-2-git-send-email-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | b662a9dd8a1a03e6e2d61e74d3e7a08400edefb7 |
| Headers | show |
Le 14/11/2016 à 16:44, Sudeep Holla a écrit : > Though the keyboard driver for GPIO buttons(gpio-keys) will continue to > check for/support the legacy "gpio-key,wakeup" boolean property to > enable gpio buttons as wakeup source, "wakeup-source" is the new > standard binding. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property in order to avoid any further copy-paste > duplication. > > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Hi, > > Inspite of getting rid of most of the legacy property almost a year ago, > addition of new platforms have brought this back and over time it's > now found again in few places. Just get rid of them *again* > > Regards, > Sudeep Sorry for this Sudeep and thanks for the patch. Best regards, > diff --git a/arch/arm/boot/dts/at91sam9260ek.dts b/arch/arm/boot/dts/at91sam9260ek.dts > index 2c87f58448e7..b2578feceb08 100644 > --- a/arch/arm/boot/dts/at91sam9260ek.dts > +++ b/arch/arm/boot/dts/at91sam9260ek.dts > @@ -174,14 +174,14 @@ > label = "Button 3"; > gpios = <&pioA 30 GPIO_ACTIVE_LOW>; > linux,code = <0x103>; > - gpio-key,wakeup; > + wakeup-source; > }; > > btn4 { > label = "Button 4"; > gpios = <&pioA 31 GPIO_ACTIVE_LOW>; > linux,code = <0x104>; > - gpio-key,wakeup; > + wakeup-source; > }; > }; > > -- > 2.7.4 > > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14/11/16 15:45, Nicolas Ferre wrote: > Le 14/11/2016 à 16:44, Sudeep Holla a écrit : >> Though the keyboard driver for GPIO buttons(gpio-keys) will continue to >> check for/support the legacy "gpio-key,wakeup" boolean property to >> enable gpio buttons as wakeup source, "wakeup-source" is the new >> standard binding. >> >> This patch replaces the legacy "gpio-key,wakeup" with the unified >> "wakeup-source" property in order to avoid any further copy-paste >> duplication. >> >> Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > >> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> >> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> >> --- >> arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Hi, >> >> Inspite of getting rid of most of the legacy property almost a year ago, >> addition of new platforms have brought this back and over time it's >> now found again in few places. Just get rid of them *again* >> >> Regards, >> Sudeep > > Sorry for this Sudeep and thanks for the patch. > No problem, in fact you reminded me to post them :) -- Regards, Sudeep -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 14/11/2016 at 15:44:08 +0000, Sudeep Holla wrote : > Though the keyboard driver for GPIO buttons(gpio-keys) will continue to > check for/support the legacy "gpio-key,wakeup" boolean property to > enable gpio buttons as wakeup source, "wakeup-source" is the new > standard binding. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property in order to avoid any further copy-paste > duplication. > > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> > Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/at91sam9260ek.dts b/arch/arm/boot/dts/at91sam9260ek.dts index 2c87f58448e7..b2578feceb08 100644 --- a/arch/arm/boot/dts/at91sam9260ek.dts +++ b/arch/arm/boot/dts/at91sam9260ek.dts @@ -174,14 +174,14 @@ label = "Button 3"; gpios = <&pioA 30 GPIO_ACTIVE_LOW>; linux,code = <0x103>; - gpio-key,wakeup; + wakeup-source; }; btn4 { label = "Button 4"; gpios = <&pioA 31 GPIO_ACTIVE_LOW>; linux,code = <0x104>; - gpio-key,wakeup; + wakeup-source; }; };
Though the keyboard driver for GPIO buttons(gpio-keys) will continue to check for/support the legacy "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup source, "wakeup-source" is the new standard binding. This patch replaces the legacy "gpio-key,wakeup" with the unified "wakeup-source" property in order to avoid any further copy-paste duplication. Cc: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com> Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Hi, Inspite of getting rid of most of the legacy property almost a year ago, addition of new platforms have brought this back and over time it's now found again in few places. Just get rid of them *again* Regards, Sudeep -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html