| Message ID | 20240829044835.2047794-1-yanzhen@vivo.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] pinctrl: Simplify with dev_err_probe() | expand |
On Thu, Aug 29, 2024 at 12:48:35PM +0800, Yan Zhen wrote: > Switch to use dev_err_probe() to simplify the error path and > unify a message template. > > Using this helper is totally fine even if err is known to never > be -EPROBE_DEFER. > > The benefit compared to a normal dev_err() is the standardized format > of the error code, it being emitted symbolically and the fact that > the error code is returned which allows more compact error paths. > > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> > --- Subject line really should be pinctrl: madera:, but otherwise: Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Thu, Aug 29, 2024 at 6:48 AM Yan Zhen <yanzhen@vivo.com> wrote: > Switch to use dev_err_probe() to simplify the error path and > unify a message template. > > Using this helper is totally fine even if err is known to never > be -EPROBE_DEFER. > > The benefit compared to a normal dev_err() is the standardized format > of the error code, it being emitted symbolically and the fact that > the error code is returned which allows more compact error paths. > > > Signed-off-by: Yan Zhen <yanzhen@vivo.com> Fixed up the subject and applied the patch. Yours, Linus Walleij
diff --git a/drivers/pinctrl/cirrus/pinctrl-madera-core.c b/drivers/pinctrl/cirrus/pinctrl-madera-core.c index 898b197c3738..2932d7aba725 100644 --- a/drivers/pinctrl/cirrus/pinctrl-madera-core.c +++ b/drivers/pinctrl/cirrus/pinctrl-madera-core.c @@ -1063,12 +1063,9 @@ static int madera_pin_probe(struct platform_device *pdev) if (pdata->gpio_configs) { ret = pinctrl_register_mappings(pdata->gpio_configs, pdata->n_gpio_configs); - if (ret) { - dev_err(priv->dev, - "Failed to register pdata mappings (%d)\n", - ret); - return ret; - } + if (ret) + return dev_err_probe(priv->dev, ret, + "Failed to register pdata mappings\n"); } ret = pinctrl_enable(priv->pctl);
Switch to use dev_err_probe() to simplify the error path and unify a message template. Using this helper is totally fine even if err is known to never be -EPROBE_DEFER. The benefit compared to a normal dev_err() is the standardized format of the error code, it being emitted symbolically and the fact that the error code is returned which allows more compact error paths. Signed-off-by: Yan Zhen <yanzhen@vivo.com> --- Changes in v2: -Rewrite the subject. -Remove 'ret' from the message. drivers/pinctrl/cirrus/pinctrl-madera-core.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)