| Message ID | 87poltbwt2.fsf@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Thu, Nov 17, 2016 at 10:50:33PM +0100, Gregory CLEMENT wrote: > Hi, > > Here is the first pull request for dt for mvebu for v4.10. > > I hope being able to send a second part very soon with the series > removing all the DT warning. > > Gregory > > The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: > > Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) > > are available in the git repository at: > > git://git.infradead.org/linux-mvebu.git tags/mvebu-dt-4.10-1 > > for you to fetch changes up to cf20c489de6fcef88405d4febef7a078d2053b9e: > > ARM: dt: orion5x: convert ls-chl to FDT (2016-11-07 17:23:34 +0100) > > ---------------------------------------------------------------- > mvebu fixes for 4.10 (part 1) > > Most of the commit are pinmux and i2c fix for netgear NASes > Fix on a wrong comment about PLL frequency > Bigger commit: conversion of on otion5x based board to the device tree > > ---------------------------------------------------------------- > Ashley Hughes (1): > ARM: dt: orion5x: convert ls-chl to FDT This is a great conversion, but I'd like to see the code handled a little differently. First of all, there's no longer a need to have a config option for MACH_LINKSTATION_LSCHL, as long as ARCH_ORION5X_DT is enabled you'll be fine. So you can remove that Kconfig entry alltogether. Also, there's no need to make the DT addition and the legacy platform removal in one commit. It's common that we build up the DT support to the point that it's at parity, and then remove the legacy board. That way we also don't entangle DT commits with non-DT commits, which can sometimes be a bit of a pain (in particular for those who maintain a copy of the DT subdir in another git repo). So, mind respinning with this fixed? Thanks! -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi Olof, On sam., nov. 19 2016, Olof Johansson <olof@lixom.net> wrote: > Hi, > > On Thu, Nov 17, 2016 at 10:50:33PM +0100, Gregory CLEMENT wrote: >> Hi, >> >> Here is the first pull request for dt for mvebu for v4.10. >> >> I hope being able to send a second part very soon with the series >> removing all the DT warning. >> >> Gregory >> >> The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: >> >> Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) >> >> are available in the git repository at: >> >> git://git.infradead.org/linux-mvebu.git tags/mvebu-dt-4.10-1 >> >> for you to fetch changes up to cf20c489de6fcef88405d4febef7a078d2053b9e: >> >> ARM: dt: orion5x: convert ls-chl to FDT (2016-11-07 17:23:34 +0100) >> >> ---------------------------------------------------------------- >> mvebu fixes for 4.10 (part 1) >> >> Most of the commit are pinmux and i2c fix for netgear NASes >> Fix on a wrong comment about PLL frequency >> Bigger commit: conversion of on otion5x based board to the device tree >> >> ---------------------------------------------------------------- >> Ashley Hughes (1): >> ARM: dt: orion5x: convert ls-chl to FDT > > This is a great conversion, but I'd like to see the code handled a > little differently. > > First of all, there's no longer a need to have a config option for > MACH_LINKSTATION_LSCHL, as long as ARCH_ORION5X_DT is enabled you'll > be fine. So you can remove that Kconfig entry alltogether. > > Also, there's no need to make the DT addition and the legacy platform > removal in one commit. It's common that we build up the DT support to the point > that it's at parity, and then remove the legacy board. That way we also don't > entangle DT commits with non-DT commits, which can sometimes be a bit of a pain > (in particular for those who maintain a copy of the DT subdir in another git > repo). > > So, mind respinning with this fixed? Thanks! OK I am doing it. Gregory > > > -Olof > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Hi, Here is the first pull request for dt for mvebu for v4.10. I hope being able to send a second part very soon with the series removing all the DT warning. Gregory The following changes since commit 1001354ca34179f3db924eb66672442a173147dc: Linux 4.9-rc1 (2016-10-15 12:17:50 -0700) are available in the git repository at: git://git.infradead.org/linux-mvebu.git tags/mvebu-dt-4.10-1 for you to fetch changes up to cf20c489de6fcef88405d4febef7a078d2053b9e: ARM: dt: orion5x: convert ls-chl to FDT (2016-11-07 17:23:34 +0100) ---------------------------------------------------------------- mvebu fixes for 4.10 (part 1) Most of the commit are pinmux and i2c fix for netgear NASes Fix on a wrong comment about PLL frequency Bigger commit: conversion of on otion5x based board to the device tree ---------------------------------------------------------------- Ashley Hughes (1): ARM: dt: orion5x: convert ls-chl to FDT Chris Packham (1): ARM: dts: mvebu: Update comment for main PLL frequency Uwe Kleine-König (6): ARM: dts: armada-370-rn104: add pinmuxing for i2c0 ARM: dts: armada-370-rn104: drop specification of compatible for i2c0 ARM: dts: armada-xp-rn2120: drop wrong compatible for i2c0 ARM: dts: armada-xp-rn2120: add pinmuxing for ethernet ARM: dts: armada-370-rn102: drop specification of compatible for i2c0 ARM: dts: armada-370-rn102: add pinmuxing for i2c0 arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/armada-370-netgear-rn102.dts | 5 +- arch/arm/boot/dts/armada-370-netgear-rn104.dts | 5 +- arch/arm/boot/dts/armada-375.dtsi | 2 +- arch/arm/boot/dts/armada-38x.dtsi | 2 +- arch/arm/boot/dts/armada-39x.dtsi | 2 +- arch/arm/boot/dts/armada-xp-netgear-rn2120.dts | 7 +- arch/arm/boot/dts/orion5x-lschl.dts | 171 +++++++++++++ arch/arm/mach-orion5x/Kconfig | 4 +- arch/arm/mach-orion5x/Makefile | 1 - arch/arm/mach-orion5x/ls-chl-setup.c | 331 ------------------------- 11 files changed, 191 insertions(+), 340 deletions(-) create mode 100644 arch/arm/boot/dts/orion5x-lschl.dts delete mode 100644 arch/arm/mach-orion5x/ls-chl-setup.c