| Message ID | ZvEaHWH0IndyeMvs@shikoro |
|---|---|
| State | New |
| Headers | show |
| Series | [PULL,REQUEST] i2c-for-6.12-rc1 | expand |
Hi Linus, ... > > The Intel LJCA driver loses "target_addr" parameter in > > ljca_i2c_stop() because it was unused. > [..] > > Still in the iMX/MXC driver a comma ',' has been replaced by a > > semicolon ';', while in different drivers the ',' has been > > removed from the '{ }' delimiters. > > Stop describing pointless noise. The pull request - and the resulting > merge message - is about USEFUL INFORMATION. > > The above is just pure noise. You're literally hiding all the useful > stuff by overwhelming people with totally uninteresting stuff that > matters not at all. > > I edited things down a bit, but I shouldn't need to wade through this > kind of pointless verbiage. > > I want a useful *summary* of what has happened, and what I'm getting. > Not some line-by-line "I changed a character". > > Is this some broken attempt at AI summary? Because it sure isn't real > intelligence. No, it's not AI summary, of course. I tried to be as more specific as I could in the description. I'll keep your message in mind for the next time and compare the way you reworded the git description with my version. Thanks, Andi
On Tue, 24 Sept 2024 at 07:24, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > ... but this comment is too much. We have a new maintainer here (Andi) > trying very hard to get up to speed. Ahh. That wasn't obvious, since the email - and the tag - were from you, and I was like "what the heck happened?" Sorry to Andi, but yeah, what I want in the pull (and thus the merge commit message) is a useful summary overview. If it's two commits, and one of them is a typo fix and the other moves code around, then by all means say "fix typo and reorganize code" for that. But when it's 50 commits, and it has major changes to some area, the typo fixes etc aren't worth mentioning individually, and can just go under some general "And the usual misc cleanups" heading. Linus
The following changes since commit da3ea35007d0af457a0afc87e84fddaebc4e0b63: Linux 6.11-rc7 (2024-09-08 14:50:28 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git tags/i2c-for-6.12-rc1 for you to fetch changes up to c24999e61b2187578fe4256b7bc6190a046c4b93: Merge tag 'i2c-host-6.12' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-mergewindow (2024-09-21 12:46:00 +0200) ---------------------------------------------------------------- i2c-for-6.12-rc1 I2C core ======== After 15 years of deprecation, the I2C_COMPAT symbol has finally been removed. Also client addresses are now locked during initialization to prevent race conditions between different kinds of instantiation. Scoped foreach OF child loops are now used. And the testunit has received some cleanups and documentation improvements as well as two new tests, one for repeated start and one for triggering SMBusAlert interrupts. I2C host drivers ================ The DesignWare and the Renesas I2C drivers have received most of the changes in this pull request. The first has has undergone through a series of cleanups that have been sent to the mailing list a year ago for the first time and finally get merged in this pull request. They are many, from typos (e.g. i2/i2c), to cosmetics, to refactoring (e.g. move inline functions to librarieas) and many others. Besides that, all the DesignWare Kconfig options have been grouped under the I2C_DESIGNWARE_CORE and this required some adaptation in many of the kernel configuration files for different arm and mips boards. Follows the list of the rest of the changes grouped by type of change. Cleanups -------- The Qualcomm Geni platform improves the exit path in the runtime resume function. The Intel LJCA driver loses "target_addr" parameter in ljca_i2c_stop() because it was unused. The MediaTek controller intializes the restart_flag in the transfer function using the ternary conditional operator ("? :") instead of initializing it in different parts. Constified a few global data structures in the virtio driver. The Renesas driver simplifies the bus speed handling in the init function making it more readable. Improved an if/else statement in probe function of the Renesas R-Car driver. The iMX/MXC driver switches to using the RUNTIME_PM_OPS() instead of SET_RUNTIME_PM_OPS(). Still in the iMX/MXC driver a comma ',' has been replaced by a semicolon ';', while in different drivers the ',' has been removed from the '{ }' delimiters. Finally three devm_clk_get_enabled() have been used to simplify the devm_clk_get/clk_prepare_enable tuple in the Renesas EMEV2, Ingenic and MPC drivers. Refactors --------- The Nuvoton fixes a potential out of boundary array access. This is not a bug fix because the issue could never occur due to hardware not having the properties listed in the array. The change makes the driver more future proof and, at the same time, silences code analyzers. Improvements ------------ The Renesas I2C (riic) driver undergoes several patches improving the runtime power management handling. The Intel i801 driver uses a more descriptive adapter's name to show the presence of the IDF feature. In the Intel Denverton (ismt) adapter the pending transactions are killed when irq's can't complete their handling, triggering a timeout. This could have been considered as a bug fix, but because, standing to Vasily, it's very sporadic, I preferred considering the patch rather as an improvement. New Feature ----------- The Renesas I2C (riic) driver now supports the fast mode plus. New support ----------- Added support for: - Renesas R9A08G045 - Rockchip RK3576 - KEBA I2C - Theobroma Systems Mule Multiplexer. The Keba comes with a new driver, i2c-keba.c. The Mule is an i2c multiplexer and it also comes with a new driver, mux/i2c-mux-mule.c. Core patch ---------- This pull request includes also a patch in the I2C framework, in i2c-core-base.c where the runtime PM functions have been replaced in order to allow to be accessed during the device add. Devicetree ---------- Some cleanups in the devicetree, as well. nVidia and Qualcomm bindings improve their "if:then:" blocks. While the aspeed binding loses the "multi-master" property because it was redundant. The i2c-sprd binding has been converted to YAML. AT24 updates ============ - document a new model from giantec in DT bindings ---------------------------------------------------------------- Adrian Huang (1): i2c: designware: Fix wrong setting for {ss,fs,hs}_{h,l}cnt registers Andi Shyti (2): i2c: qcom-geni: Use goto for clearer exit path i2c: ljca: Remove unused "target_addr" parameter Andy Shevchenko (16): i2c: designware: Replace a while-loop by for-loop i2c: designware: Let PCI core to take care about interrupt vectors i2c: designware: Add missing 'c' into PCI IDs variable name i2c: designware: Unify terminator in device ID tables i2c: designware: Always provide device ID tables i2c: designware: Drop return value from i2c_dw_acpi_configure() i2c: designware: Drop return value from dw_i2c_of_configure() i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() i2c: designware: Consolidate firmware parsing and configuring code i2c: designware: Unify the firmware type checks i2c: designware: Move exports to I2C_DW namespaces i2c: designware: Remove ->disable() callback i2c: designware: Consolidate PM ops i2c: designware: Uninline i2c_dw_probe() i2c: designware: Propagate firmware node i2c: designware: Use pci_get_drvdata() AngeloGioacchino Del Regno (1): i2c: mt65xx: Avoid double initialization of restart_flag in isr Christophe JAILLET (1): i2c: virtio: Constify struct i2c_algorithm and struct virtio_device_id Claudiu Beznea (8): i2c: riic: Use temporary variable for struct device i2c: riic: Call pm_runtime_get_sync() when need to access registers i2c: riic: Use pm_runtime_resume_and_get() i2c: riic: Enable runtime PM autosuspend support i2c: riic: Add suspend/resume support i2c: riic: Define individual arrays to describe the register offsets dt-bindings: i2c: renesas,riic: Document the R9A08G045 support i2c: riic: Add support for fast mode plus Detlev Casanova (1): dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible Fabio Estevam (1): i2c: imx: Switch to RUNTIME_PM_OPS() Farouk Bouabid (2): dt-bindings: i2c: add support for tsd,mule-i2c-mux i2c: muxes: add support for tsd,mule-i2c multiplexer Geert Uytterhoeven (1): i2c: riic: Simplify unsupported bus speed handling Gerhard Engleder (1): i2c: keba: Add KEBA I2C controller support Hans de Goede (2): i2c: core: Setup i2c_adapter runtime-pm before calling device_add() i2c: i801: Use a different adapter-name for IDF adapters Heikki Krogerus (7): ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM arm64: defconfig: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM net: txgbe: Fix I2C Kconfig dependencies i2c: designware: Group all DesignWare drivers under a single option Heiko Stuebner (1): dt-bindings: eeprom: at24: Add compatible for Giantec GT24C04A Heiner Kallweit (2): i2c: core: Lock address during client device instantiation i2c: Remove I2C_COMPAT config symbol and related code Krzysztof Kozlowski (6): i2c: simplify with scoped for each OF child loop dt-bindings: i2c: nvidia,tegra20-i2c: combine same if:then: clauses dt-bindings: i2c: nvidia,tegra20-i2c: restrict also clocks in if:then: dt-bindings: i2c: nvidia,tegra20-i2c: define power-domains top-level dt-bindings: i2c: qcom,i2c-cci: add missing clocks constraint in if:then: dt-bindings: i2c: aspeed: drop redundant multi-master Kuninori Morimoto (1): i2c: rcar: tidyup priv->devtype handling on rcar_i2c_probe() Rong Qianfeng (2): i2c: emev2: Use devm_clk_get_enabled() helpers i2c: jz4780: Use devm_clk_get_enabled() helpers Shen Lichuan (1): i2c: imx: Convert comma to semicolon Stanislav Jakubek (1): dt-bindings: i2c: i2c-sprd: convert to YAML Tyrone Ting (1): i2c: npcm: restore slave addresses array length Vasily Khoruzhick (1): i2c: ismt: kill transaction in hardware on timeout Wolfram Sang (10): i2c: testunit: sort case blocks i2c: testunit: use decimal values in docs when appropriate i2c: testunit: add command to support versioning and test rep_start i2c: testunit: return current command on read messages i2c: testunit: describe fwnode based instantiation i2c: testunit: move code to avoid a forward declaration i2c: testunit: add SMBusAlert trigger Merge tag 'at24-updates-for-v6.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux into i2c/for-mergewindow i2c: don't use ',' after delimiters Merge tag 'i2c-host-6.12' of git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux into i2c/for-mergewindow Zhang Zekun (1): i2c: mpc: Use devm_clk_get_optional_enabled() to simplify code with much appreciated quality assurance from ---------------------------------------------------------------- Andi Shyti (21): (Rev.) i2c: designware: Use pci_get_drvdata() (Rev.) i2c: designware: Propagate firmware node (Rev.) i2c: designware: Uninline i2c_dw_probe() (Rev.) i2c: core: Setup i2c_adapter runtime-pm before calling device_add() (Rev.) i2c: npcm: restore slave addresses array length (Rev.) dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible (Rev.) i2c: designware: Consolidate PM ops (Rev.) i2c: designware: Remove ->disable() callback (Rev.) i2c: designware: Move exports to I2C_DW namespaces (Rev.) i2c: designware: Unify the firmware type checks (Rev.) i2c: designware: Consolidate firmware parsing and configuring code (Rev.) i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() (Rev.) i2c: riic: Add suspend/resume support (Rev.) i2c: riic: Call pm_runtime_get_sync() when need to access registers (Rev.) i2c: designware: Drop return value from dw_i2c_of_configure() (Rev.) i2c: designware: Drop return value from i2c_dw_acpi_configure() (Rev.) i2c: designware: Always provide device ID tables (Rev.) i2c: designware: Unify terminator in device ID tables (Rev.) i2c: designware: Add missing 'c' into PCI IDs variable name (Rev.) i2c: designware: Let PCI core to take care about interrupt vectors (Rev.) i2c: designware: Replace a while-loop by for-loop Chris Packham (1): (Rev.) i2c: mpc: Use devm_clk_get_optional_enabled() to simplify code Claudiu Beznea (2): (Rev.) i2c: riic: Simplify unsupported bus speed handling (Test) i2c: riic: Simplify unsupported bus speed handling Conor Dooley (1): (Rev.) dt-bindings: i2c: i2c-sprd: convert to YAML Dong Wang (1): (Test) i2c: designware: Fix wrong setting for {ss,fs,hs}_{h,l}cnt registers Geert Uytterhoeven (2): (Rev.) i2c: rcar: tidyup priv->devtype handling on rcar_i2c_probe() (Rev.) i2c: emev2: Use devm_clk_get_enabled() helpers Guenter Roeck (1): (Rev.) dt-bindings: i2c: add support for tsd,mule-i2c-mux Jarkko Nikula (1): (Test) i2c: designware: Let PCI core to take care about interrupt vectors Krzysztof Kozlowski (1): (Rev.) dt-bindings: i2c: i2c-rk3x: Add rk3576 compatible Krzysztof Piotr Oledzki (1): (Test) i2c: core: Lock address during client device instantiation Mario Limonciello (7): (Rev.) i2c: designware: Unify the firmware type checks (Rev.) i2c: designware: Consolidate firmware parsing and configuring code (Rev.) i2c: designware: Rename dw_i2c_of_configure() -> i2c_dw_of_configure() (Rev.) i2c: designware: Drop return value from dw_i2c_of_configure() (Rev.) i2c: designware: Always provide device ID tables (Rev.) i2c: designware: Unify terminator in device ID tables (Rev.) i2c: designware: Replace a while-loop by for-loop Pali Rohár (2): (Rev.) i2c: i801: Use a different adapter-name for IDF adapters (Rev.) i2c: core: Setup i2c_adapter runtime-pm before calling device_add() Rob Herring (Arm) (1): (Rev.) dt-bindings: i2c: add support for tsd,mule-i2c-mux Sanket Goswami (1): (Test) i2c: designware: Consolidate PM ops Serge Semin (2): (Test) i2c: designware: Propagate firmware node (Test) i2c: designware: Uninline i2c_dw_probe() Wolfram Sang (10): (Rev.) i2c: rcar: tidyup priv->devtype handling on rcar_i2c_probe() (Rev.) i2c: emev2: Use devm_clk_get_enabled() helpers (Rev.) i2c: muxes: add support for tsd,mule-i2c multiplexer (Rev.) dt-bindings: i2c: add support for tsd,mule-i2c-mux (Rev.) i2c: riic: Simplify unsupported bus speed handling (Rev.) i2c: riic: Define individual arrays to describe the register offsets (Rev.) i2c: riic: Enable runtime PM autosuspend support (Rev.) i2c: riic: Use pm_runtime_resume_and_get() (Rev.) i2c: riic: Call pm_runtime_get_sync() when need to access registers (Rev.) i2c: riic: Use temporary variable for struct device Documentation/devicetree/bindings/eeprom/at24.yaml | 1 + .../devicetree/bindings/i2c/aspeed,i2c.yaml | 5 - .../devicetree/bindings/i2c/i2c-rk3x.yaml | 1 + Documentation/devicetree/bindings/i2c/i2c-sprd.txt | 31 -- .../bindings/i2c/nvidia,tegra20-i2c.yaml | 27 +- .../devicetree/bindings/i2c/qcom,i2c-cci.yaml | 1 + .../devicetree/bindings/i2c/renesas,riic.yaml | 4 + .../devicetree/bindings/i2c/sprd,sc9860-i2c.yaml | 65 +++ .../devicetree/bindings/i2c/tsd,mule-i2c-mux.yaml | 69 +++ Documentation/i2c/slave-testunit-backend.rst | 120 ++++- arch/arc/configs/axs101_defconfig | 1 + arch/arc/configs/axs103_defconfig | 1 + arch/arc/configs/axs103_smp_defconfig | 1 + arch/arc/configs/tb10x_defconfig | 1 + arch/arm/configs/hisi_defconfig | 1 + arch/arm/configs/multi_v7_defconfig | 1 + arch/arm/configs/pxa_defconfig | 1 + arch/arm/configs/socfpga_defconfig | 1 + arch/arm/configs/spear13xx_defconfig | 1 + arch/arm/configs/spear3xx_defconfig | 1 + arch/arm/configs/spear6xx_defconfig | 1 + arch/arm64/configs/defconfig | 1 + arch/mips/configs/generic/board-ocelot.config | 1 + arch/riscv/configs/defconfig | 1 + arch/riscv/configs/nommu_k210_defconfig | 1 + arch/riscv/configs/nommu_k210_sdcard_defconfig | 1 + drivers/i2c/Kconfig | 8 - drivers/i2c/busses/Kconfig | 40 +- drivers/i2c/busses/Makefile | 1 + drivers/i2c/busses/i2c-ali1535.c | 3 +- drivers/i2c/busses/i2c-amd-mp2-plat.c | 2 +- drivers/i2c/busses/i2c-aspeed.c | 2 +- drivers/i2c/busses/i2c-designware-common.c | 180 ++++++- drivers/i2c/busses/i2c-designware-core.h | 39 +- drivers/i2c/busses/i2c-designware-master.c | 36 +- drivers/i2c/busses/i2c-designware-pcidrv.c | 88 +-- drivers/i2c/busses/i2c-designware-platdrv.c | 184 ++----- drivers/i2c/busses/i2c-designware-slave.c | 6 +- drivers/i2c/busses/i2c-digicolor.c | 2 +- drivers/i2c/busses/i2c-emev2.c | 25 +- drivers/i2c/busses/i2c-i801.c | 9 +- drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +- drivers/i2c/busses/i2c-imx.c | 11 +- drivers/i2c/busses/i2c-ismt.c | 10 + drivers/i2c/busses/i2c-jz4780.c | 22 +- drivers/i2c/busses/i2c-keba.c | 598 +++++++++++++++++++++ drivers/i2c/busses/i2c-ljca.c | 6 +- drivers/i2c/busses/i2c-mpc.c | 23 +- drivers/i2c/busses/i2c-mt65xx.c | 5 +- drivers/i2c/busses/i2c-npcm7xx.c | 6 +- drivers/i2c/busses/i2c-omap.c | 2 +- drivers/i2c/busses/i2c-piix4.c | 2 +- drivers/i2c/busses/i2c-pnx.c | 2 +- drivers/i2c/busses/i2c-pxa-pci.c | 2 +- drivers/i2c/busses/i2c-pxa.c | 2 +- drivers/i2c/busses/i2c-qcom-geni.c | 23 +- drivers/i2c/busses/i2c-qup.c | 2 +- drivers/i2c/busses/i2c-rcar.c | 12 +- drivers/i2c/busses/i2c-riic.c | 228 +++++--- drivers/i2c/busses/i2c-s3c2410.c | 2 +- drivers/i2c/busses/i2c-virtio.c | 4 +- drivers/i2c/i2c-core-base.c | 79 +-- drivers/i2c/i2c-core-slave.c | 7 +- drivers/i2c/i2c-slave-testunit.c | 166 ++++-- drivers/i2c/muxes/Kconfig | 16 + drivers/i2c/muxes/Makefile | 1 + drivers/i2c/muxes/i2c-mux-mule.c | 148 +++++ drivers/net/ethernet/wangxun/Kconfig | 3 +- include/linux/i2c.h | 3 + 69 files changed, 1747 insertions(+), 605 deletions(-) delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-sprd.txt create mode 100644 Documentation/devicetree/bindings/i2c/sprd,sc9860-i2c.yaml create mode 100644 Documentation/devicetree/bindings/i2c/tsd,mule-i2c-mux.yaml create mode 100644 drivers/i2c/busses/i2c-keba.c create mode 100644 drivers/i2c/muxes/i2c-mux-mule.c