| Message ID | 20241001125033.10625-8-johan+linaro@kernel.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/7] serial: qcom-geni: fix premature receiver enable | expand |
Hi, On Tue, Oct 1, 2024 at 5:51 AM Johan Hovold <johan+linaro@kernel.org> wrote: > > Serial drivers should not be dropping characters themselves, but at > least drop the unused 'drop' parameter from the receive handler for now. > > Signed-off-by: Johan Hovold <johan+linaro@kernel.org> > --- > drivers/tty/serial/qcom_geni_serial.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Sure. I haven't spent any time figuring out what serial drivers are supposed to do with parity errors occur (I don't think I've ever used a UART that enabled the parity bit in all my years), but at least I agree that getting rid of this useless parameter makes sense. Reviewed-by: Douglas Anderson <dianders@chromium.org> I guess while reviewing this patch I can also see that, indeed, parity errors seem to be "GP0" and break seems to be (strangely) GP2 and GP3. I guess that answers some of the questions I had on patch #5.
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 8bc4b240bf59..daa852785bd9 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -562,7 +562,7 @@ static void handle_rx_console(struct uart_port *uport, u32 bytes, bool drop) } #endif /* CONFIG_SERIAL_QCOM_GENI_CONSOLE */ -static void handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop) +static void handle_rx_uart(struct uart_port *uport, u32 bytes) { struct qcom_geni_serial_port *port = to_dev_port(uport); struct tty_port *tport = &uport->state->port; @@ -855,7 +855,7 @@ static void qcom_geni_serial_handle_rx_dma(struct uart_port *uport, bool drop) } if (!drop) - handle_rx_uart(uport, rx_in, drop); + handle_rx_uart(uport, rx_in); ret = geni_se_rx_dma_prep(&port->se, port->rx_buf, DMA_RX_BUF_SIZE,
Serial drivers should not be dropping characters themselves, but at least drop the unused 'drop' parameter from the receive handler for now. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/tty/serial/qcom_geni_serial.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)