| Message ID | 8cd12678-f44a-4b16-a579-c8f11175ee8c@stanley.mountain |
|---|---|
| State | Accepted |
| Commit | 78261cb08f06c93d362cab5c5034bf5899bc7552 |
| Headers | show |
| Series | soc: qcom: geni-se: fix array underflow in geni_se_clk_tbl_get() | expand |
On Mon, 30 Sep 2024 10:51:31 +0300, Dan Carpenter wrote: > This loop is supposed to break if the frequency returned from > clk_round_rate() is the same as on the previous iteration. However, > that check doesn't make sense on the first iteration through the loop. > It leads to reading before the start of these->clk_perf_tbl[] array. > > Applied, thanks! [1/1] soc: qcom: geni-se: fix array underflow in geni_se_clk_tbl_get() commit: 78261cb08f06c93d362cab5c5034bf5899bc7552 Best regards,
diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c index 2e8f24d5da80..4cb959106efa 100644 --- a/drivers/soc/qcom/qcom-geni-se.c +++ b/drivers/soc/qcom/qcom-geni-se.c @@ -585,7 +585,8 @@ int geni_se_clk_tbl_get(struct geni_se *se, unsigned long **tbl) for (i = 0; i < MAX_CLK_PERF_LEVEL; i++) { freq = clk_round_rate(se->clk, freq + 1); - if (freq <= 0 || freq == se->clk_perf_tbl[i - 1]) + if (freq <= 0 || + (i > 0 && freq == se->clk_perf_tbl[i - 1])) break; se->clk_perf_tbl[i] = freq; }
This loop is supposed to break if the frequency returned from clk_round_rate() is the same as on the previous iteration. However, that check doesn't make sense on the first iteration through the loop. It leads to reading before the start of these->clk_perf_tbl[] array. Fixes: eddac5af0654 ("soc: qcom: Add GENI based QUP Wrapper driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/soc/qcom/qcom-geni-se.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)