Message ID | 20241008200926.428679-1-arkadiusz.bokowy@gmail.com |
---|---|
State | New |
Headers | show |
Series | [BlueZ] transport: Delay existence based on delay reporting capability | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=896868 ---Test result--- Test Summary: CheckPatch FAIL 0.74 seconds GitLint PASS 0.32 seconds BuildEll PASS 27.04 seconds BluezMake FAIL 2671.19 seconds MakeCheck FAIL 25.18 seconds MakeDistcheck PASS 199.11 seconds CheckValgrind FAIL 205.60 seconds CheckSmatch FAIL 375.30 seconds bluezmakeextell FAIL 123.82 seconds IncrementalBuild FAIL 2492.60 seconds ScanBuild FAIL 1140.48 seconds Details ############################## Test: CheckPatch - FAIL Desc: Run checkpatch.pl script Output: [BlueZ] transport: Delay existence based on delay reporting capability ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line #115: FILE: profiles/audio/avdtp.c:3206: +gboolean avdtp_stream_has_delay_reporting(struct avdtp_stream *stream) { WARNING:LONG_LINE: line length of 81 exceeds 80 columns #192: FILE: profiles/audio/transport.c:2039: + transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ /github/workspace/src/src/13826901.patch total: 1 errors, 1 warnings, 71 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13826901.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. ############################## Test: BluezMake - FAIL Desc: Build BlueZ Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[]) | ^~~~ unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4690: all] Error 2 ############################## Test: MakeCheck - FAIL Desc: Run Bluez Make Check Output: profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make: *** [Makefile:12355: check] Error 2 ############################## Test: CheckValgrind - FAIL Desc: Run Bluez Make Check with Valgrind Output: tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[]) | ^~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:12355: check] Error 2 ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: src/shared/crypto.c:271:21: warning: Variable length array is used. src/shared/crypto.c:272:23: warning: Variable length array is used. src/shared/gatt-helpers.c:768:31: warning: Variable length array is used. src/shared/gatt-helpers.c:830:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used. src/shared/gatt-server.c:278:25: warning: Variable length array is used. src/shared/gatt-server.c:618:25: warning: Variable length array is used. src/shared/gatt-server.c:716:25: warning: Variable length array is used. src/shared/bap.c:288:25: warning: array of flexible structures src/shared/bap.c: note: in included file: ./src/shared/ascs.h:88:25: warning: array of flexible structures src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' src/shared/crypto.c:271:21: warning: Variable length array is used. src/shared/crypto.c:272:23: warning: Variable length array is used. src/shared/gatt-helpers.c:768:31: warning: Variable length array is used. src/shared/gatt-helpers.c:830:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used. src/shared/gatt-server.c:278:25: warning: Variable length array is used. src/shared/gatt-server.c:618:25: warning: Variable length array is used. src/shared/gatt-server.c:716:25: warning: Variable length array is used. src/shared/bap.c:288:25: warning: array of flexible structures src/shared/bap.c: note: in included file: ./src/shared/ascs.h:88:25: warning: array of flexible structures src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' tools/mesh-cfgtest.c:1453:17: warning: unknown escape sequence: '\%' tools/sco-tester.c: note: in included file: ./lib/bluetooth.h:219:15: warning: array of flexible structures ./lib/bluetooth.h:224:31: warning: array of flexible structures tools/bneptest.c:634:39: warning: unknown escape sequence: '\%' tools/seq2bseq.c:57:26: warning: Variable length array is used. tools/obex-client-tool.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' android/avctp.c:505:34: warning: Variable length array is used. android/avctp.c:556:34: warning: Variable length array is used. unit/test-avrcp.c:373:26: warning: Variable length array is used. unit/test-avrcp.c:398:26: warning: Variable length array is used. unit/test-avrcp.c:414:24: warning: Variable length array is used. android/avrcp-lib.c:1085:34: warning: Variable length array is used. android/avrcp-lib.c:1583:34: warning: Variable length array is used. android/avrcp-lib.c:1612:34: warning: Variable length array is used. android/avrcp-lib.c:1638:34: warning: Variable length array is used. mesh/mesh-io-mgmt.c:523:67: warning: Variable length array is used. client/display.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' src/shared/crypto.c:271:21: warning: Variable length array is used. src/shared/crypto.c:272:23: warning: Variable length array is used. src/shared/gatt-helpers.c:768:31: warning: Variable length array is used. src/shared/gatt-helpers.c:830:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1323:31: warning: Variable length array is used. src/shared/gatt-helpers.c:1354:23: warning: Variable length array is used. src/shared/gatt-server.c:278:25: warning: Variable length array is used. src/shared/gatt-server.c:618:25: warning: Variable length array is used. src/shared/gatt-server.c:716:25: warning: Variable length array is used. src/shared/bap.c:288:25: warning: array of flexible structures src/shared/bap.c: note: in included file: ./src/shared/ascs.h:88:25: warning: array of flexible structures src/shared/shell.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' monitor/packet.c: note: in included file: monitor/display.h:82:26: warning: Variable length array is used. monitor/packet.c:1868:26: warning: Variable length array is used. monitor/packet.c: note: in included file: monitor/bt.h:3606:52: warning: array of flexible structures monitor/bt.h:3594:40: warning: array of flexible structures monitor/l2cap.c: note: in included file: monitor/display.h:82:26: warning: Variable length array is used. monitor/msft.c: note: in included file: monitor/msft.h:88:44: warning: array of flexible structures monitor/att.c: note: in included file: monitor/display.h:82:26: warning: Variable length array is used. tools/rctest.c:627:33: warning: non-ANSI function declaration of function 'automated_send_recv' tools/hex2hcd.c:136:26: warning: Variable length array is used. tools/meshctl.c:324:33: warning: non-ANSI function declaration of function 'forget_mesh_devices' tools/mesh-gatt/node.c:456:39: warning: non-ANSI function declaration of function 'node_get_local_node' tools/mesh-gatt/net.c:1239:30: warning: non-ANSI function declaration of function 'get_next_seq' tools/mesh-gatt/net.c:2193:29: warning: non-ANSI function declaration of function 'net_get_default_ttl' tools/mesh-gatt/net.c:2207:26: warning: non-ANSI function declaration of function 'net_get_seq_num' tools/mesh-gatt/prov.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' tools/mesh-gatt/onoff-model.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' ell/log.c:431:65: warning: non-ANSI function declaration of function 'register_debug_section' ell/log.c:439:68: warning: non-ANSI function declaration of function 'free_debug_sections' ell/random.c:60:42: warning: non-ANSI function declaration of function 'l_getrandom_is_supported' ell/cipher.c:660:28: warning: non-ANSI function declaration of function 'init_supported' ell/checksum.c:372:28: warning: non-ANSI function declaration of function 'init_supported' ell/checksum.c:434:47: warning: non-ANSI function declaration of function 'l_checksum_cmac_aes_supported' ell/cipher.c:519:24: warning: Variable length array is used. ell/cert-crypto.c:36:33: warning: Variable length array is used. ell/cert-crypto.c:132:36: warning: Variable length array is used. ell/cert-crypto.c:188:36: warning: Variable length array is used. ell/cert-crypto.c:241:31: warning: Variable length array is used. ell/key.c:538:25: warning: Variable length array is used. ell/dbus-service.c:548:49: warning: non-ANSI function declaration of function '_dbus_object_tree_new' ell/dbus-filter.c:232:46: warning: Variable length array is used. ell/tls.c:45:25: warning: Variable length array is used. ell/tls.c:86:22: warning: Variable length array is used. ell/tls.c:86:46: warning: Variable length array is used. ell/tls.c:1819:26: warning: Variable length array is used. ell/tls-suites.c:1078:25: warning: Variable length array is used. ell/tls-suites.c:1080:34: warning: Variable length array is used. ell/tls-suites.c:1083:41: warning: Variable length array is used. ell/tls-suites.c:1132:41: warning: Variable length array is used. emulator/btdev.c:436:29: warning: Variable length array is used. emulator/bthost.c:613:28: warning: Variable length array is used. emulator/bthost.c:787:28: warning: Variable length array is used. attrib/gatttool.c:235:23: warning: Variable length array is used. attrib/interactive.c: note: in included file (through /usr/include/readline/readline.h): /usr/include/readline/rltypedefs.h:35:23: warning: non-ANSI function declaration of function 'Function' /usr/include/readline/rltypedefs.h:36:25: warning: non-ANSI function declaration of function 'VFunction' /usr/include/readline/rltypedefs.h:37:27: warning: non-ANSI function declaration of function 'CPFunction' /usr/include/readline/rltypedefs.h:38:29: warning: non-ANSI function declaration of function 'CPPFunction' attrib/interactive.c:174:27: warning: non-ANSI function declaration of function 'disconnect_io' attrib/interactive.c:299:23: warning: Variable length array is used. profiles/sap/server.c: note: in included file: profiles/sap/sap.h:77:35: warning: array of flexible structures profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4690: all] Error 2 ############################## Test: bluezmakeextell - FAIL Desc: Build Bluez with External ELL Output: profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4690: all] Error 2 ############################## Test: IncrementalBuild - FAIL Desc: Incremental build with the patches in the series Output: [BlueZ] transport: Delay existence based on delay reporting capability tools/mgmt-tester.c: In function ‘main’: tools/mgmt-tester.c:12725:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 12725 | int main(int argc, char *argv[]) | ^~~~ unit/test-avdtp.c: In function ‘main’: unit/test-avdtp.c:766:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 766 | int main(int argc, char *argv[]) | ^~~~ unit/test-avrcp.c: In function ‘main’: unit/test-avrcp.c:989:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without 989 | int main(int argc, char *argv[]) | ^~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:4690: all] Error 2 ############################## Test: ScanBuild - FAIL Desc: Run Scan Build Output: src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed gatt_db_unregister(op->client->db, op->db_id); ^~~~~~~~~~ src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed discovery_op_complete(op, false, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed discover_all(op); ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2145:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2153:8: warning: Use of memory after it is freed discovery_op_ref(op), ^~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3242:2: warning: Use of memory after it is freed complete_write_long_op(req, success, 0, false); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3264:2: warning: Use of memory after it is freed request_unref(req); ^~~~~~~~~~~~~~~~~~ 12 warnings generated. src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed gatt_db_unregister(op->client->db, op->db_id); ^~~~~~~~~~ src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed discovery_op_complete(op, false, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed discover_all(op); ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2145:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2153:8: warning: Use of memory after it is freed discovery_op_ref(op), ^~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3242:2: warning: Use of memory after it is freed complete_write_long_op(req, success, 0, false); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3264:2: warning: Use of memory after it is freed request_unref(req); ^~~~~~~~~~~~~~~~~~ 12 warnings generated. tools/hciattach.c:817:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 10)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:865:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:887:8: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 10)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:909:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:930:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 4)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/hciattach.c:974:7: warning: Although the value stored to 'n' is used in the enclosing expression, the value is never actually read from 'n' if ((n = read_hci_event(fd, resp, 6)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ 6 warnings generated. src/oui.c:50:2: warning: Value stored to 'hwdb' is never read hwdb = udev_hwdb_unref(hwdb); ^ ~~~~~~~~~~~~~~~~~~~~~ src/oui.c:53:2: warning: Value stored to 'udev' is never read udev = udev_unref(udev); ^ ~~~~~~~~~~~~~~~~ 2 warnings generated. tools/hcidump.c:180:9: warning: Potential leak of memory pointed to by 'dp' if (fds[i].fd == sock) ^~~ tools/hcidump.c:248:17: warning: Assigned value is garbage or undefined dh->ts_sec = htobl(frm.ts.tv_sec); ^ ~~~~~~~~~~~~~~~~~~~~ tools/hcidump.c:326:9: warning: 1st function call argument is an uninitialized value if (be32toh(dp.flags) & 0x02) { ^~~~~~~~~~~~~~~~~ /usr/include/endian.h:46:22: note: expanded from macro 'be32toh' # define be32toh(x) __bswap_32 (x) ^~~~~~~~~~~~~~ tools/hcidump.c:341:20: warning: 1st function call argument is an uninitialized value frm.data_len = be32toh(dp.len); ^~~~~~~~~~~~~~~ /usr/include/endian.h:46:22: note: expanded from macro 'be32toh' # define be32toh(x) __bswap_32 (x) ^~~~~~~~~~~~~~ tools/hcidump.c:346:14: warning: 1st function call argument is an uninitialized value opcode = be32toh(dp.flags) & 0xffff; ^~~~~~~~~~~~~~~~~ /usr/include/endian.h:46:22: note: expanded from macro 'be32toh' # define be32toh(x) __bswap_32 (x) ^~~~~~~~~~~~~~ tools/hcidump.c:384:17: warning: Assigned value is garbage or undefined frm.data_len = btohs(dh.len); ^ ~~~~~~~~~~~~~ tools/hcidump.c:394:11: warning: Assigned value is garbage or undefined frm.len = frm.data_len; ^ ~~~~~~~~~~~~ tools/hcidump.c:398:9: warning: 1st function call argument is an uninitialized value ts = be64toh(ph.ts); ^~~~~~~~~~~~~~ /usr/include/endian.h:51:22: note: expanded from macro 'be64toh' # define be64toh(x) __bswap_64 (x) ^~~~~~~~~~~~~~ tools/hcidump.c:403:13: warning: 1st function call argument is an uninitialized value frm.in = be32toh(dp.flags) & 0x01; ^~~~~~~~~~~~~~~~~ /usr/include/endian.h:46:22: note: expanded from macro 'be32toh' # define be32toh(x) __bswap_32 (x) ^~~~~~~~~~~~~~ tools/hcidump.c:408:11: warning: Assigned value is garbage or undefined frm.in = dh.in; ^ ~~~~~ tools/hcidump.c:437:7: warning: Null pointer passed to 1st parameter expecting 'nonnull' fd = open(file, open_flags, 0644); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 11 warnings generated. tools/rfcomm.c:234:3: warning: Value stored to 'i' is never read i = execvp(cmdargv[0], cmdargv); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/rfcomm.c:234:7: warning: Null pointer passed to 1st parameter expecting 'nonnull' i = execvp(cmdargv[0], cmdargv); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/rfcomm.c:354:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd' if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/rfcomm.c:497:14: warning: Assigned value is garbage or undefined req.channel = raddr.rc_channel; ^ ~~~~~~~~~~~~~~~~ tools/rfcomm.c:515:8: warning: Although the value stored to 'fd' is used in the enclosing expression, the value is never actually read from 'fd' if ((fd = open(devname, O_RDONLY | O_NOCTTY)) < 0) { ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5 warnings generated. src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ 3 warnings generated. tools/ciptool.c:350:7: warning: 5th function call argument is an uninitialized value sk = do_connect(ctl, dev_id, &src, &dst, psm, (1 << CMTP_LOOPBACK)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. tools/sdptool.c:941:26: warning: Result of 'malloc' is converted to a pointer of type 'uint32_t', which is incompatible with sizeof operand type 'int' uint32_t *value_int = malloc(sizeof(int)); ~~~~~~~~~~ ^~~~~~ ~~~~~~~~~~~ tools/sdptool.c:980:4: warning: 1st function call argument is an uninitialized value free(allocArray[i]); ^~~~~~~~~~~~~~~~~~~ tools/sdptool.c:3777:2: warning: Potential leak of memory pointed to by 'si.name' return add_service(0, &si); ^~~~~~~~~~~~~~~~~~~~~~~~~~ tools/sdptool.c:4112:4: warning: Potential leak of memory pointed to by 'context.svc' return -1; ^~~~~~~~~ 4 warnings generated. tools/avtest.c:225:5: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:235:5: warning: Value stored to 'len' is never read len = write(sk, buf, 4); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:244:5: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:258:5: warning: Value stored to 'len' is never read len = write(sk, buf, ^ ~~~~~~~~~~~~~~ tools/avtest.c:265:5: warning: Value stored to 'len' is never read len = write(sk, buf, ^ ~~~~~~~~~~~~~~ tools/avtest.c:272:5: warning: Value stored to 'len' is never read len = write(sk, buf, ^ ~~~~~~~~~~~~~~ tools/avtest.c:279:5: warning: Value stored to 'len' is never read len = write(sk, buf, ^ ~~~~~~~~~~~~~~ tools/avtest.c:291:5: warning: Value stored to 'len' is never read len = write(sk, buf, 4); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:295:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:304:5: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:308:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:317:5: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:324:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:346:5: warning: Value stored to 'len' is never read len = write(sk, buf, 4); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:350:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:359:5: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:363:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:376:5: warning: Value stored to 'len' is never read len = write(sk, buf, 4); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:380:5: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:387:4: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:397:4: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:562:3: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:570:3: warning: Value stored to 'len' is never read len = write(sk, buf, invalid ? 2 : 3); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/avtest.c:584:3: warning: Value stored to 'len' is never read len = write(sk, buf, 4 + sizeof(media_transport)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/avtest.c:597:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:607:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:619:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:634:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:646:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:655:3: warning: Value stored to 'len' is never read len = write(sk, buf, 3); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:662:3: warning: Value stored to 'len' is never read len = write(sk, buf, 2); ^ ~~~~~~~~~~~~~~~~~ tools/avtest.c:698:2: warning: Value stored to 'len' is never read len = write(sk, buf, AVCTP_HEADER_LENGTH + sizeof(play_pressed)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 32 warnings generated. tools/btproxy.c:836:15: warning: Null pointer passed to 1st parameter expecting 'nonnull' tcp_port = atoi(optarg); ^~~~~~~~~~~~ tools/btproxy.c:839:8: warning: Null pointer passed to 1st parameter expecting 'nonnull' if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3)) ^~~~~~~~~~~~~~ 2 warnings generated. tools/create-image.c:76:3: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ tools/create-image.c:84:3: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ tools/create-image.c:92:3: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ tools/create-image.c:105:2: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ 4 warnings generated. tools/btgatt-client.c:1824:2: warning: Value stored to 'argv' is never read argv += optind; ^ ~~~~~~ 1 warning generated. tools/btgatt-server.c:1212:2: warning: Value stored to 'argv' is never read argv -= optind; ^ ~~~~~~ 1 warning generated. tools/check-selftest.c:42:3: warning: Value stored to 'ptr' is never read ptr = fgets(result, sizeof(result), fp); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. tools/gatt-service.c:294:2: warning: 2nd function call argument is an uninitialized value chr_write(chr, value, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. tools/obex-server-tool.c:133:13: warning: Null pointer passed to 1st parameter expecting 'nonnull' data->fd = open(name, O_WRONLY | O_CREAT | O_NOCTTY, 0600); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/obex-server-tool.c:192:13: warning: Null pointer passed to 1st parameter expecting 'nonnull' data->fd = open(name, O_RDONLY | O_NOCTTY, 0); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. tools/btpclientctl.c:402:3: warning: Value stored to 'bit' is never read bit = 0; ^ ~ tools/btpclientctl.c:1655:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(cp->data, ad_data, ad_len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t' pElem = malloc(sizeof(uint16_t)); ^~~~~~ ~~~~~~~~~~~~~~~~ src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t' pElem = malloc(sizeof(uint32_t)); ^~~~~~ ~~~~~~~~~~~~~~~~ 2 warnings generated. android/avrcp-lib.c:1968:3: warning: 1st function call argument is an uninitialized value g_free(text[i]); ^~~~~~~~~~~~~~~ 1 warning generated. profiles/health/hdp.c:644:3: warning: Use of memory after it is freed hdp_tmp_dc_data_unref(dc_data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/health/hdp.c:800:19: warning: Use of memory after it is freed path = g_strdup(chan->path); ^~~~~~~~~~ profiles/health/hdp.c:1779:6: warning: Use of memory after it is freed hdp_tmp_dc_data_ref(hdp_conn), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/health/hdp.c:1836:30: warning: Use of memory after it is freed reply = g_dbus_create_error(data->msg, ERROR_INTERFACE ".HealthError", ^~~~~~~~~ 4 warnings generated. profiles/health/hdp_util.c:1052:2: warning: Use of memory after it is freed conn_data->func(conn_data->data, gerr); ^~~~~~~~~~~~~~~ 1 warning generated. attrib/gatt.c:970:2: warning: Potential leak of memory pointed to by 'long_write' return prepare_write(long_write); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. src/sdpd-request.c:211:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint16_t' pElem = malloc(sizeof(uint16_t)); ^~~~~~ ~~~~~~~~~~~~~~~~ src/sdpd-request.c:239:13: warning: Result of 'malloc' is converted to a pointer of type 'char', which is incompatible with sizeof operand type 'uint32_t' pElem = malloc(sizeof(uint32_t)); ^~~~~~ ~~~~~~~~~~~~~~~~ 2 warnings generated. src/sdp-xml.c:126:10: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ src/sdp-xml.c:300:11: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ src/sdp-xml.c:338:11: warning: Assigned value is garbage or undefined buf[1] = data[i + 1]; ^ ~~~~~~~~~~~ 3 warnings generated. src/sdp-client.c:353:14: warning: Access to field 'cb' results in a dereference of a null pointer (*ctxt)->cb = cb; ~~~~~~~~~~~~^~~~ 1 warning generated. src/gatt-database.c:1156:10: warning: Value stored to 'bits' during its initialization is never read uint8_t bits[] = { BT_GATT_CHRC_CLI_FEAT_ROBUST_CACHING, ^~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. gobex/gobex-header.c:95:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(to, from, count); ^~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. gobex/gobex-transfer.c:423:7: warning: Use of memory after it is freed if (!g_slist_find(transfers, transfer)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. mesh/main.c:161:3: warning: Value stored to 'optarg' is never read optarg += strlen("auto"); ^ ~~~~~~~~~~~~~~ 1 warning generated. client/player.c:2206:8: warning: Null pointer passed to 2nd parameter expecting 'nonnull' if (!strcmp(ep->path, pattern)) ^~~~~~~~~~~~~~~~~~~~~~~~~ client/player.c:3476:16: warning: Null pointer passed to 1st parameter expecting 'nonnull' codec->name = strdup(name); ^~~~~~~~~~~~ 2 warnings generated. lib/hci.c:97:4: warning: Value stored to 'ptr' is never read ptr += sprintf(ptr, "%s", m->str); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. gdbus/watch.c:226:3: warning: Attempt to free released memory g_free(l->data); ^~~~~~~~~~~~~~~ 1 warning generated. lib/sdp.c:509:17: warning: Dereference of undefined pointer value uint8_t dtd = *(uint8_t *) dtds[i]; ^~~~~~~~~~~~~~~~~~~~ lib/sdp.c:539:17: warning: Dereference of undefined pointer value uint8_t dtd = *(uint8_t *) dtds[i]; ^~~~~~~~~~~~~~~~~~~~ lib/sdp.c:1885:26: warning: Potential leak of memory pointed to by 'ap' for (; pdlist; pdlist = pdlist->next) { ^~~~~~ lib/sdp.c:1899:6: warning: Potential leak of memory pointed to by 'pds' ap = sdp_list_append(ap, pds); ~~~^~~~~~~~~~~~~~~~~~~~~~~~~~ lib/sdp.c:1944:10: warning: Potential leak of memory pointed to by 'u' *seqp = sdp_list_append(*seqp, u); ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/sdp.c:2049:4: warning: Potential leak of memory pointed to by 'lang' sdp_list_free(*langSeq, free); ^~~~~~~~~~~~~ lib/sdp.c:2138:9: warning: Potential leak of memory pointed to by 'profDesc' return 0; ^ lib/sdp.c:3270:8: warning: Potential leak of memory pointed to by 'pSvcRec' pSeq = sdp_list_append(pSeq, pSvcRec); ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/sdp.c:3271:9: warning: Potential leak of memory pointed to by 'pSeq' pdata += sizeof(uint32_t); ~~~~~~^~~~~~~~~~~~~~~~~~~ lib/sdp.c:4607:13: warning: Potential leak of memory pointed to by 'rec_list' } while (scanned < attr_list_len && pdata_len > 0); ^~~~~~~ lib/sdp.c:4903:40: warning: Potential leak of memory pointed to by 'tseq' for (d = sdpdata->val.dataseq; d; d = d->next) { ^ lib/sdp.c:4939:8: warning: Potential leak of memory pointed to by 'subseq' tseq = sdp_list_append(tseq, subseq); ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 12 warnings generated. src/shared/gatt-client.c:451:21: warning: Use of memory after it is freed gatt_db_unregister(op->client->db, op->db_id); ^~~~~~~~~~ src/shared/gatt-client.c:696:2: warning: Use of memory after it is freed discovery_op_complete(op, false, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:996:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1102:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1296:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1361:2: warning: Use of memory after it is freed discovery_op_complete(op, success, att_ecode); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1636:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:1641:2: warning: Use of memory after it is freed discover_all(op); ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2145:6: warning: Use of memory after it is freed if (read_db_hash(op)) { ^~~~~~~~~~~~~~~~ src/shared/gatt-client.c:2153:8: warning: Use of memory after it is freed discovery_op_ref(op), ^~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3242:2: warning: Use of memory after it is freed complete_write_long_op(req, success, 0, false); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ src/shared/gatt-client.c:3264:2: warning: Use of memory after it is freed request_unref(req); ^~~~~~~~~~~~~~~~~~ 12 warnings generated. monitor/l2cap.c:1638:4: warning: Value stored to 'data' is never read data += len; ^ ~~~ monitor/l2cap.c:1639:4: warning: Value stored to 'size' is never read size -= len; ^ ~~~ 2 warnings generated. monitor/hwdb.c:59:2: warning: Value stored to 'hwdb' is never read hwdb = udev_hwdb_unref(hwdb); ^ ~~~~~~~~~~~~~~~~~~~~~ monitor/hwdb.c:64:2: warning: Value stored to 'udev' is never read udev = udev_unref(udev); ^ ~~~~~~~~~~~~~~~~ monitor/hwdb.c:106:2: warning: Value stored to 'hwdb' is never read hwdb = udev_hwdb_unref(hwdb); ^ ~~~~~~~~~~~~~~~~~~~~~ monitor/hwdb.c:111:2: warning: Value stored to 'udev' is never read udev = udev_unref(udev); ^ ~~~~~~~~~~~~~~~~ 4 warnings generated. tools/bluemoon.c:1102:8: warning: Null pointer passed to 1st parameter expecting 'nonnull' if (strlen(optarg) > 3 && !strncmp(optarg, "hci", 3)) ^~~~~~~~~~~~~~ 1 warning generated. tools/meshctl.c:326:19: warning: Access to field 'mesh_devices' results in a dereference of a null pointer (loaded from variable 'default_ctrl') g_list_free_full(default_ctrl->mesh_devices, g_free); ^~~~~~~~~~~~~~~~~~~~~~~~~~ tools/meshctl.c:762:2: warning: 2nd function call argument is an uninitialized value bt_shell_printf("Attempting to disconnect from %s\n", addr); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ tools/meshctl.c:1957:2: warning: Value stored to 'len' is never read len = len + extra + strlen("local_node.json"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 3 warnings generated. In file included from tools/mesh-gatt/crypto.c:32: ./src/shared/util.h:240:9: warning: 1st function call argument is an uninitialized value return be32_to_cpu(get_unaligned((const uint32_t *) ptr)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./src/shared/util.h:33:26: note: expanded from macro 'be32_to_cpu' #define be32_to_cpu(val) bswap_32(val) ^~~~~~~~~~~~~ /usr/include/byteswap.h:34:21: note: expanded from macro 'bswap_32' #define bswap_32(x) __bswap_32 (x) ^~~~~~~~~~~~~~ In file included from tools/mesh-gatt/crypto.c:32: ./src/shared/util.h:250:9: warning: 1st function call argument is an uninitialized value return be64_to_cpu(get_unaligned((const uint64_t *) ptr)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./src/shared/util.h:34:26: note: expanded from macro 'be64_to_cpu' #define be64_to_cpu(val) bswap_64(val) ^~~~~~~~~~~~~ /usr/include/byteswap.h:37:21: note: expanded from macro 'bswap_64' #define bswap_64(x) __bswap_64 (x) ^~~~~~~~~~~~~~ 2 warnings generated. ell/util.c:785:8: warning: The left operand of '>' is a garbage value if (x > UINT8_MAX) ~ ^ ell/util.c:803:8: warning: The left operand of '>' is a garbage value if (x > UINT16_MAX) ~ ^ 2 warnings generated. ell/pem.c:131:8: warning: Dereference of null pointer (loaded from variable 'eol') if (*eol == '\r' || *eol == '\n') ^~~~ ell/pem.c:166:18: warning: Dereference of null pointer (loaded from variable 'eol') if (buf_len && *eol == '\r' && *buf_ptr == '\n') { ^~~~ ell/pem.c:166:34: warning: Dereference of null pointer (loaded from variable 'buf_ptr') if (buf_len && *eol == '\r' && *buf_ptr == '\n') { ^~~~~~~~ ell/pem.c:304:11: warning: 1st function call argument is an uninitialized value result = pem_load_buffer(file.data, file.st.st_size, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ell/pem.c:469:9: warning: 1st function call argument is an uninitialized value list = l_pem_load_certificate_list_from_data(file.data, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 5 warnings generated. ell/cert.c:644:41: warning: Access to field 'asn1_len' results in a dereference of a null pointer (loaded from variable 'cert') key = l_key_new(L_KEY_RSA, cert->asn1, cert->asn1_len); ^~~~~~~~~~~~~~ 1 warning generated. ell/gvariant-util.c:143:18: warning: The left operand of '>' is a garbage value if (alignment > max_alignment) ~~~~~~~~~ ^ ell/gvariant-util.c:456:5: warning: Dereference of null pointer !children[0].fixed_size) { ^~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. ell/ecc-external.c:68:24: warning: The left operand of '&' is a garbage value return (vli[bit / 64] & ((uint64_t) 1 << (bit % 64))); ~~~~~~~~~~~~~ ^ ell/ecc-external.c:160:18: warning: The right operand of '-' is a garbage value diff = left[i] - right[i] - borrow; ^ ~~~~~~~~ 2 warnings generated. In file included from tools/parser/amp.c:15: tools/parser/parser.h:121:16: warning: Dereference of null pointer time_t t = f->ts.tv_sec; ^~~~~~~~~~~~ tools/parser/parser.h:127:27: warning: Dereference of null pointer printf("%8lu.%06lu ", f->ts.tv_sec, f->ts.tv_usec); ^~~~~~~~~~~~ tools/parser/parser.h:129:18: warning: Access to field 'in' results in a dereference of a null pointer (loaded from variable 'f') printf("%c ", (f->in ? '>' : '<')); ^~~~~ 3 warnings generated. In file included from tools/parser/sdp.c:24: tools/parser/parser.h:121:16: warning: Dereference of null pointer time_t t = f->ts.tv_sec; ^~~~~~~~~~~~ tools/parser/parser.h:127:27: warning: Dereference of null pointer printf("%8lu.%06lu ", f->ts.tv_sec, f->ts.tv_usec); ^~~~~~~~~~~~ tools/parser/parser.h:129:18: warning: Access to field 'in' results in a dereference of a null pointer (loaded from variable 'f') printf("%c ", (f->in ? '>' : '<')); ^~~~~ 3 warnings generated. In file included from tools/parser/ppp.c:22: tools/parser/parser.h:156:2: warning: Undefined or garbage value returned to caller return *u8_ptr; ^~~~~~~~~~~~~~ tools/parser/ppp.c:108:30: warning: The left operand of '&' is a garbage value if (*((uint8_t *) frm->ptr) & 0x80) ~~~~~~~~~~~~~~~~~~~~~~~ ^ 2 warnings generated. emulator/serial.c:151:2: warning: Assigned value is garbage or undefined enum btdev_type uninitialized_var(type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/serial.c:151:36: warning: Value stored to 'type' during its initialization is never read enum btdev_type uninitialized_var(type); ^~~~ emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var' #define uninitialized_var(x) x = x ^ ~ emulator/serial.c:214:2: warning: Assigned value is garbage or undefined enum btdev_type uninitialized_var(dev_type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/serial.c:214:36: warning: Value stored to 'dev_type' during its initialization is never read enum btdev_type uninitialized_var(dev_type); ^~~~~~~~ emulator/serial.c:36:30: note: expanded from macro 'uninitialized_var' #define uninitialized_var(x) x = x ^ ~ 4 warnings generated. emulator/server.c:200:2: warning: Assigned value is garbage or undefined enum btdev_type uninitialized_var(type); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/server.c:200:36: warning: Value stored to 'type' during its initialization is never read enum btdev_type uninitialized_var(type); ^~~~ emulator/server.c:36:30: note: expanded from macro 'uninitialized_var' #define uninitialized_var(x) x = x ^ ~ 2 warnings generated. emulator/b1ee.c:258:3: warning: Potential leak of memory pointed to by 'server_port' int opt; ^~~~~~~ emulator/b1ee.c:258:3: warning: Potential leak of memory pointed to by 'sniffer_port' int opt; ^~~~~~~ emulator/b1ee.c:289:2: warning: Value stored to 'argc' is never read argc = argc - optind; ^ ~~~~~~~~~~~~~ 3 warnings generated. emulator/btdev.c:1101:10: warning: Although the value stored to 'conn' is used in the enclosing expression, the value is never actually read from 'conn' while ((conn = queue_find(dev->conns, match_handle, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ emulator/btdev.c:1388:24: warning: Access to field 'link' results in a dereference of a null pointer (loaded from variable 'conn') pending_conn_del(dev, conn->link->dev); ^~~~~~~~~~ emulator/btdev.c:1510:13: warning: Access to field 'dev' results in a dereference of a null pointer (loaded from variable 'conn') send_event(conn->dev, BT_HCI_EVT_AUTH_COMPLETE, &ev, sizeof(ev)); ^~~~~~~~~ 3 warnings generated. gobex/gobex-header.c:95:2: warning: Null pointer passed to 2nd parameter expecting 'nonnull' memcpy(to, from, count); ^~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. gobex/gobex-transfer.c:423:7: warning: Use of memory after it is freed if (!g_slist_find(transfers, transfer)) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. attrib/gatt.c:970:2: warning: Potential leak of memory pointed to by 'long_write' return prepare_write(long_write); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. tools/btpclient.c:2494:3: warning: Value stored to 'reply' is never read reply = l_dbus_message_new_error(ag.pending_req, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. android/avdtp.c:756:25: warning: Use of memory after it is freed session->prio_queue = g_slist_remove(session->prio_queue, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ android/avdtp.c:763:24: warning: Use of memory after it is freed session->req_queue = g_slist_remove(session->req_queue, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. profiles/audio/avdtp.c:899:25: warning: Use of memory after it is freed session->prio_queue = g_slist_remove(session->prio_queue, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/avdtp.c:906:24: warning: Use of memory after it is freed session->req_queue = g_slist_remove(session->req_queue, req); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. profiles/audio/a2dp.c:372:8: warning: Use of memory after it is freed if (!cb->resume_cb) ^~~~~~~~~~~~~ 1 warning generated. profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[0].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2067:2: note: in expansion of macro ‘A2DP_OPS’ 2067 | A2DP_OPS(A2DP_SOURCE_UUID, transport_a2dp_src_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: error: initialization of ‘void * (*)(struct media_transport *)’ from incompatible pointer type ‘struct avdtp_stream * (*)(struct media_transport *)’ [-Werror=incompatible-pointer-types] 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ profiles/audio/transport.c:2039:33: note: (near initialization for ‘transport_ops[1].get_stream’) 2039 | transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ | ^~~~~~~~~~~~~~~~~~~~~~~~~ profiles/audio/transport.c:2030:16: note: in definition of macro ‘TRANSPORT_OPS’ 2030 | .get_stream = _get_stream, \ | ^~~~~~~~~~~ profiles/audio/transport.c:2070:2: note: in expansion of macro ‘A2DP_OPS’ 2070 | A2DP_OPS(A2DP_SINK_UUID, transport_a2dp_snk_init, | ^~~~~~~~ cc1: all warnings being treated as errors make[1]: *** [Makefile:10276: profiles/audio/bluetoothd-transport.o] Error 1 make[1]: *** Waiting for unfinished jobs.... profiles/audio/media.c:1048:7: warning: Use of memory after it is freed if (req->cb != pac_select_cb) { ^~~~~~~ 1 warning generated. make: *** [Makefile:4690: all] Error 2 --- Regards, Linux Bluetooth
diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c index 448ee2730..289b40827 100644 --- a/profiles/audio/avdtp.c +++ b/profiles/audio/avdtp.c @@ -3203,6 +3203,10 @@ gboolean avdtp_stream_has_capabilities(struct avdtp_stream *stream, return TRUE; } +gboolean avdtp_stream_has_delay_reporting(struct avdtp_stream *stream) { + return stream->delay_reporting; +} + struct avdtp_remote_sep *avdtp_stream_get_remote_sep( struct avdtp_stream *stream) { diff --git a/profiles/audio/avdtp.h b/profiles/audio/avdtp.h index 102a2603e..500b814ac 100644 --- a/profiles/audio/avdtp.h +++ b/profiles/audio/avdtp.h @@ -252,6 +252,7 @@ struct avdtp_service_capability *avdtp_stream_get_codec( struct avdtp_stream *stream); gboolean avdtp_stream_has_capabilities(struct avdtp_stream *stream, GSList *caps); +gboolean avdtp_stream_has_delay_reporting(struct avdtp_stream *stream); struct avdtp_remote_sep *avdtp_stream_get_remote_sep( struct avdtp_stream *stream); diff --git a/profiles/audio/transport.c b/profiles/audio/transport.c index caa7287db..1a65ec6f9 100644 --- a/profiles/audio/transport.c +++ b/profiles/audio/transport.c @@ -377,13 +377,22 @@ static gboolean media_transport_set_fd(struct media_transport *transport, return TRUE; } +static struct avdtp_stream * +transport_a2dp_get_stream(struct media_transport *transport) +{ + struct media_endpoint *endpoint = transport->endpoint; + struct a2dp_sep *sep = media_endpoint_get_sep(endpoint); + struct avdtp_stream *stream = a2dp_sep_get_stream(sep); + + return stream; +} + static void a2dp_resume_complete(struct avdtp *session, int err, void *user_data) { struct media_owner *owner = user_data; struct media_request *req = owner->pending; struct media_transport *transport = owner->transport; - struct a2dp_sep *sep = media_endpoint_get_sep(transport->endpoint); struct avdtp_stream *stream; int fd; uint16_t imtu, omtu; @@ -394,7 +403,7 @@ static void a2dp_resume_complete(struct avdtp *session, int err, if (err) goto fail; - stream = a2dp_sep_get_stream(sep); + stream = transport_a2dp_get_stream(transport); if (stream == NULL) goto fail; @@ -852,9 +861,13 @@ static gboolean delay_reporting_exists(const GDBusPropertyTable *property, void *data) { struct media_transport *transport = data; - struct a2dp_transport *a2dp = transport->data; + struct avdtp_stream *stream; + + stream = media_transport_get_stream(transport); + if (stream == NULL) + return FALSE; - return a2dp->delay != 0; + return avdtp_stream_has_delay_reporting(stream); } static gboolean get_delay_reporting(const GDBusPropertyTable *property, @@ -2023,7 +2036,7 @@ static void *transport_asha_init(struct media_transport *transport, void *data) #define A2DP_OPS(_uuid, _init, _set_volume, _destroy) \ TRANSPORT_OPS(_uuid, transport_a2dp_properties, NULL, NULL, _init, \ transport_a2dp_resume, transport_a2dp_suspend, \ - transport_a2dp_cancel, NULL, NULL, \ + transport_a2dp_cancel, NULL, transport_a2dp_get_stream, \ transport_a2dp_get_volume, _set_volume, \ _destroy)