diff mbox series

[2/2] 8250_core.c : Global variable shouldn't be initialized to NULL

Message ID 20241014180415.2365-1-m.omerfarukbulut@gmail.com
State New
Headers show
Series None | expand

Commit Message

Omer Faruk BULUT Oct. 14, 2024, 6:04 p.m. UTC 
I check it with checkpatch. Then remove the NULL part.

Signed-by-off: Omer Faruk BULUT <m.omerfarukbulut@gmail.com>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Oct. 15, 2024, 11:34 a.m. UTC | #1 
On Mon, Oct 14, 2024 at 09:04:15PM +0300, Omer Faruk BULUT wrote:
> I check it with checkpatch. Then remove the NULL part.

checkpatch may be false positive. Please, add a better analysis
that it's fine to do a such cleanup. Note, this variable is _not_
static.

...

> -const struct uart_ops *univ8250_port_base_ops = NULL;
> +const struct uart_ops *univ8250_port_base_ops;

Is it guaranteed to be NULL for non-static variables? If so,
we want to know the details.

>  struct uart_ops univ8250_port_ops;
diff mbox series

Patch

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 5f9f06911795..435396233863 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -304,7 +304,7 @@  static void univ8250_release_irq(struct uart_8250_port *up)
 		serial_unlink_irq_chain(up);
 }
 
-const struct uart_ops *univ8250_port_base_ops = NULL;
+const struct uart_ops *univ8250_port_base_ops;
 struct uart_ops univ8250_port_ops;
 
 static const struct uart_8250_ops univ8250_driver_ops = {