| Message ID | 20241015180906.8464-2-karansanghvi98@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: spi: Convert bcm2835-aux-spi.txt to | expand |
On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote: > Converted the brcm,bcm2835-aux-spi.txt file to > its respective yaml file format. > > Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com> > --- > v1->v2 : Made the necessary changes in the yaml file > suggested by Krzysztof Kozlowski > > v1: > - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/ I don't understand this patch. How is it converting a text file to json schema when all you're doing here is deleting stuff from an existing yaml file? > > .../bindings/spi/brcm,bcm2835-aux-spi.yaml | 18 ++---------------- > 1 file changed, 2 insertions(+), 16 deletions(-) > > diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml > index 4c24cf2fe214..f83f71ba78dc 100644 > --- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml > +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml > @@ -9,8 +9,7 @@ title: Broadcom BCM2835 Auxiliary SPI1/2 Controller > maintainers: > - Karan Sanghavi <karansanghvi98@gmail.com> > > -description: | > - The BCM2835 contains two forms of SPI master controller. One is known simply as > +description: The BCM2835 contains two forms of SPI master controller. One is known simply as > SPI0, and the other as the "Universal SPI Master," part of the auxiliary block. > This binding applies to the SPI1 and SPI2 auxiliary controllers. > > @@ -21,7 +20,6 @@ properties: > compatible: > enum: > - brcm,bcm2835-aux-spi > - description: Broadcom BCM2835 Auxiliary SPI controller for SPI1 and SPI2. > > reg: > maxItems: 1 > @@ -30,8 +28,7 @@ properties: > maxItems: 1 > > clocks: > - items: > - - description: Reference to the auxiliary clock driver for the BCM2835. > + maxItems: 1 > > required: > - compatible > @@ -53,14 +50,3 @@ examples: > #size-cells = <0>; > }; > > - - | > - #include <dt-bindings/clock/bcm2835-aux.h> > - spi@7e2150c0 { > - compatible = "brcm,bcm2835-aux-spi"; > - reg = <0x7e2150c0 0x40>; > - interrupts = <1 29>; > - clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>; > - #address-cells = <1>; > - #size-cells = <0>; > - }; > - > -- > 2.43.0 >
On 15/10/2024 22:25, Conor Dooley wrote: > On Tue, Oct 15, 2024 at 06:09:07PM +0000, Karan Sanghavi wrote: >> Converted the brcm,bcm2835-aux-spi.txt file to >> its respective yaml file format. >> >> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com> >> --- >> v1->v2 : Made the necessary changes in the yaml file >> suggested by Krzysztof Kozlowski >> >> v1: >> - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/ > > I don't understand this patch. How is it converting a text file to > json schema when all you're doing here is deleting stuff from an > existing yaml file? I guess this is supposed to be v2, but it's all messed up. Karan, 1. Respond to previous review. 2. Prepare v3 incorporating the review. 3. Properly use Git to amend your commit - proficiency in Git is basically a requirement and we won't be teaching this here. This is kernel development, so assumption is that you know how to use Git (and not Github, these are entirely different things). 4. Send v3, do not attach the email to some other versions/threads whatever. Just use 'b4' if you have troubles with 'git format-patch'. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml index 4c24cf2fe214..f83f71ba78dc 100644 --- a/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml +++ b/Documentation/devicetree/bindings/spi/brcm,bcm2835-aux-spi.yaml @@ -9,8 +9,7 @@ title: Broadcom BCM2835 Auxiliary SPI1/2 Controller maintainers: - Karan Sanghavi <karansanghvi98@gmail.com> -description: | - The BCM2835 contains two forms of SPI master controller. One is known simply as +description: The BCM2835 contains two forms of SPI master controller. One is known simply as SPI0, and the other as the "Universal SPI Master," part of the auxiliary block. This binding applies to the SPI1 and SPI2 auxiliary controllers. @@ -21,7 +20,6 @@ properties: compatible: enum: - brcm,bcm2835-aux-spi - description: Broadcom BCM2835 Auxiliary SPI controller for SPI1 and SPI2. reg: maxItems: 1 @@ -30,8 +28,7 @@ properties: maxItems: 1 clocks: - items: - - description: Reference to the auxiliary clock driver for the BCM2835. + maxItems: 1 required: - compatible @@ -53,14 +50,3 @@ examples: #size-cells = <0>; }; - - | - #include <dt-bindings/clock/bcm2835-aux.h> - spi@7e2150c0 { - compatible = "brcm,bcm2835-aux-spi"; - reg = <0x7e2150c0 0x40>; - interrupts = <1 29>; - clocks = <&aux_clocks BCM2835_AUX_CLOCK_SPI2>; - #address-cells = <1>; - #size-cells = <0>; - }; -
Converted the brcm,bcm2835-aux-spi.txt file to its respective yaml file format. Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com> --- v1->v2 : Made the necessary changes in the yaml file suggested by Krzysztof Kozlowski v1: - https://lore.kernel.org/all/Zw1Oj1utiBJ9Sosg@Emma/ .../bindings/spi/brcm,bcm2835-aux-spi.yaml | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-)