diff mbox series

phy: qcom: ufs: drop unused ufsphy_v2_regs_layout

Message ID 20241016-topic-ufs-phy-drop-v2-regs-layout-v1-1-af804ce47060@linaro.org
State New
Headers show
Series phy: qcom: ufs: drop unused ufsphy_v2_regs_layout | expand

Commit Message

Neil Armstrong Oct. 16, 2024, 7:43 a.m. UTC 
The ufsphy_v2_regs_layout is not used, drop it and fix:
phy-qcom-qmp-ufs.c:87:27: warning: ‘ufsphy_v2_regs_layout’ defined but not used [-Wunused-const-variable=]

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 drivers/phy/qcom/phy-qcom-qmp-ufs.c | 6 ------
 1 file changed, 6 deletions(-)


---
base-commit: d5cab0d6adc26ec1bbd45c2fed101184d04454ae
change-id: 20241016-topic-ufs-phy-drop-v2-regs-layout-fc269a6d1d0c

Best regards,

Comments

Caleb Connolly Oct. 17, 2024, 10:44 a.m. UTC | #1 
On 16/10/2024 09:43, Neil Armstrong wrote:
> The ufsphy_v2_regs_layout is not used, drop it and fix:
> phy-qcom-qmp-ufs.c:87:27: warning: ‘ufsphy_v2_regs_layout’ defined but not used [-Wunused-const-variable=]
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>

Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>   drivers/phy/qcom/phy-qcom-qmp-ufs.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/phy/qcom/phy-qcom-qmp-ufs.c b/drivers/phy/qcom/phy-qcom-qmp-ufs.c
> index 8908a34df54..5b17f3aee67 100644
> --- a/drivers/phy/qcom/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qcom/phy-qcom-qmp-ufs.c
> @@ -84,12 +84,6 @@ enum qphy_reg_layout {
>   	QPHY_LAYOUT_SIZE
>   };
>   
> -static const unsigned int ufsphy_v2_regs_layout[QPHY_LAYOUT_SIZE] = {
> -	[QPHY_START_CTRL]		= QPHY_V2_PCS_UFS_PHY_START,
> -	[QPHY_PCS_READY_STATUS]		= QPHY_V2_PCS_UFS_READY_STATUS,
> -	[QPHY_PCS_POWER_DOWN_CONTROL]	= QPHY_V2_PCS_UFS_POWER_DOWN_CONTROL,
> -};
> -
>   static const unsigned int ufsphy_v3_regs_layout[QPHY_LAYOUT_SIZE] = {
>   	[QPHY_START_CTRL]		= QPHY_V3_PCS_UFS_PHY_START,
>   	[QPHY_PCS_READY_STATUS]		= QPHY_V3_PCS_UFS_READY_STATUS,
> 
> ---
> base-commit: d5cab0d6adc26ec1bbd45c2fed101184d04454ae
> change-id: 20241016-topic-ufs-phy-drop-v2-regs-layout-fc269a6d1d0c
> 
> Best regards,
Caleb Connolly Nov. 14, 2024, 6:13 p.m. UTC | #2 
On Wed, 16 Oct 2024 09:43:56 +0200, Neil Armstrong wrote:
> The ufsphy_v2_regs_layout is not used, drop it and fix:
> phy-qcom-qmp-ufs.c:87:27: warning: ‘ufsphy_v2_regs_layout’ defined but not used [-Wunused-const-variable=]
> 
> 

Applied, thanks!

[1/1] phy: qcom: ufs: drop unused ufsphy_v2_regs_layout
      commit: 7b52f3eaa0a188196f607c92f8f472470715393e

Best regards,
diff mbox series

Patch

diff --git a/drivers/phy/qcom/phy-qcom-qmp-ufs.c b/drivers/phy/qcom/phy-qcom-qmp-ufs.c
index 8908a34df54..5b17f3aee67 100644
--- a/drivers/phy/qcom/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qcom/phy-qcom-qmp-ufs.c
@@ -84,12 +84,6 @@  enum qphy_reg_layout {
 	QPHY_LAYOUT_SIZE
 };
 
-static const unsigned int ufsphy_v2_regs_layout[QPHY_LAYOUT_SIZE] = {
-	[QPHY_START_CTRL]		= QPHY_V2_PCS_UFS_PHY_START,
-	[QPHY_PCS_READY_STATUS]		= QPHY_V2_PCS_UFS_READY_STATUS,
-	[QPHY_PCS_POWER_DOWN_CONTROL]	= QPHY_V2_PCS_UFS_POWER_DOWN_CONTROL,
-};
-
 static const unsigned int ufsphy_v3_regs_layout[QPHY_LAYOUT_SIZE] = {
 	[QPHY_START_CTRL]		= QPHY_V3_PCS_UFS_PHY_START,
 	[QPHY_PCS_READY_STATUS]		= QPHY_V3_PCS_UFS_READY_STATUS,