diff mbox series

ACPI: resource: Add LG 16T90SP to irq1_level_low_skip_override[]

Message ID 20241016-lg-gram-pro-keyboard-v1-1-34306123102f@heusel.eu
State Superseded
Headers show
Series ACPI: resource: Add LG 16T90SP to irq1_level_low_skip_override[] | expand

Commit Message

Christian Heusel Oct. 16, 2024, 2:41 p.m. UTC 
The LG Gram Pro 16 2-in-1 (2024) the 16T90SP has its keybopard IRQ (1)
described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh
which breaks the keyboard.

Add the 16T90SP to the irq1_level_low_skip_override[] quirk table to fix
this.

Reported-by: Dirk Holten <dirk.holten@gmx.de>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219382
Cc: stable@vger.kernel.org
Suggested-by: Dirk Holten <dirk.holten@gmx.de>
Signed-off-by: Christian Heusel <christian@heusel.eu>
---
Note that I do not have the relevant hardware since I'm sending in this
quirk at the request of someone else.

Also does this change need a "Fixes: ..." tag?
---
 drivers/acpi/resource.c | 5 +++++
 1 file changed, 5 insertions(+)


---
base-commit: 8e929cb546ee42c9a61d24fae60605e9e3192354
change-id: 20241016-lg-gram-pro-keyboard-9a9d8b9aa647

Best regards,
--
Christian Heusel <christian@heusel.eu>

Comments

kernel test robot Oct. 17, 2024, 7:11 a.m. UTC | #1 
Hi Christian,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 8e929cb546ee42c9a61d24fae60605e9e3192354]

url:    https://github.com/intel-lab-lkp/linux/commits/Christian-Heusel/ACPI-resource-Add-LG-16T90SP-to-irq1_level_low_skip_override/20241016-224929
base:   8e929cb546ee42c9a61d24fae60605e9e3192354
patch link:    https://lore.kernel.org/r/20241016-lg-gram-pro-keyboard-v1-1-34306123102f%40heusel.eu
patch subject: [PATCH] ACPI: resource: Add LG 16T90SP to irq1_level_low_skip_override[]
config: x86_64-randconfig-122-20241017 (https://download.01.org/0day-ci/archive/20241017/202410171432.vrXoRLhw-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241017/202410171432.vrXoRLhw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410171432.vrXoRLhw-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/acpi/resource.c:501:18: sparse: sparse: Initializer entry defined twice
   drivers/acpi/resource.c:506:18: sparse:   also defined here
   drivers/acpi/resource.c: note: in included file (through include/linux/resource_ext.h, include/linux/acpi.h):
   include/linux/list.h:83:21: sparse: sparse: self-comparison always evaluates to true

vim +501 drivers/acpi/resource.c

55a93417c27c6ad Christophe Ricard 2015-12-23  387  
d37273af0e428e9 Hans de Goede     2023-09-13  388  /*
d37273af0e428e9 Hans de Goede     2023-09-13  389   * DMI matches for boards where the DSDT specifies the kbd IRQ as
d37273af0e428e9 Hans de Goede     2023-09-13  390   * level active-low and using the override changes this to rising edge,
d37273af0e428e9 Hans de Goede     2023-09-13  391   * stopping the keyboard from working.
d37273af0e428e9 Hans de Goede     2023-09-13  392   */
d37273af0e428e9 Hans de Goede     2023-09-13  393  static const struct dmi_system_id irq1_level_low_skip_override[] = {
892a012699fc0b9 Hui Wang          2021-09-15  394  	{
424009ab2030862 Hans de Goede     2023-09-13  395  		/* MEDION P15651 */
892a012699fc0b9 Hui Wang          2021-09-15  396  		.matches = {
892a012699fc0b9 Hui Wang          2021-09-15  397  			DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
892a012699fc0b9 Hui Wang          2021-09-15  398  			DMI_MATCH(DMI_BOARD_NAME, "M15T"),
892a012699fc0b9 Hui Wang          2021-09-15  399  		},
892a012699fc0b9 Hui Wang          2021-09-15  400  	},
1b26ae40092b43b Hui Wang          2021-10-25  401  	{
424009ab2030862 Hans de Goede     2023-09-13  402  		/* MEDION S17405 */
1b26ae40092b43b Hui Wang          2021-10-25  403  		.matches = {
1b26ae40092b43b Hui Wang          2021-10-25  404  			DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
1b26ae40092b43b Hui Wang          2021-10-25  405  			DMI_MATCH(DMI_BOARD_NAME, "M17T"),
1b26ae40092b43b Hui Wang          2021-10-25  406  		},
1b26ae40092b43b Hui Wang          2021-10-25  407  	},
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  408  	{
424009ab2030862 Hans de Goede     2023-09-13  409  		/* MEDION S17413 */
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  410  		.matches = {
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  411  			DMI_MATCH(DMI_SYS_VENDOR, "MEDION"),
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  412  			DMI_MATCH(DMI_BOARD_NAME, "M1xA"),
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  413  		},
2d0ab14634a26e5 Aymeric Wibo      2023-03-19  414  	},
e12dee3736731e2 Tamim Khan        2022-08-28  415  	{
424009ab2030862 Hans de Goede     2023-09-13  416  		/* Asus Vivobook K3402ZA */
e12dee3736731e2 Tamim Khan        2022-08-28  417  		.matches = {
e12dee3736731e2 Tamim Khan        2022-08-28  418  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
e12dee3736731e2 Tamim Khan        2022-08-28  419  			DMI_MATCH(DMI_BOARD_NAME, "K3402ZA"),
e12dee3736731e2 Tamim Khan        2022-08-28  420  		},
e12dee3736731e2 Tamim Khan        2022-08-28  421  	},
e12dee3736731e2 Tamim Khan        2022-08-28  422  	{
424009ab2030862 Hans de Goede     2023-09-13  423  		/* Asus Vivobook K3502ZA */
e12dee3736731e2 Tamim Khan        2022-08-28  424  		.matches = {
e12dee3736731e2 Tamim Khan        2022-08-28  425  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
e12dee3736731e2 Tamim Khan        2022-08-28  426  			DMI_MATCH(DMI_BOARD_NAME, "K3502ZA"),
e12dee3736731e2 Tamim Khan        2022-08-28  427  		},
e12dee3736731e2 Tamim Khan        2022-08-28  428  	},
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  429  	{
424009ab2030862 Hans de Goede     2023-09-13  430  		/* Asus Vivobook S5402ZA */
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  431  		.matches = {
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  432  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  433  			DMI_MATCH(DMI_BOARD_NAME, "S5402ZA"),
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  434  		},
6e5cbe7c4b41824 Kellen Renshaw    2022-09-21  435  	},
b5f9223a105d9b5 Tamim Khan        2022-10-14  436  	{
424009ab2030862 Hans de Goede     2023-09-13  437  		/* Asus Vivobook S5602ZA */
b5f9223a105d9b5 Tamim Khan        2022-10-14  438  		.matches = {
b5f9223a105d9b5 Tamim Khan        2022-10-14  439  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
b5f9223a105d9b5 Tamim Khan        2022-10-14  440  			DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
b5f9223a105d9b5 Tamim Khan        2022-10-14  441  		},
b5f9223a105d9b5 Tamim Khan        2022-10-14  442  	},
2f80ce0b78c340e Hans de Goede     2024-09-27  443  	{
2f80ce0b78c340e Hans de Goede     2024-09-27  444  		/* Asus Vivobook X1704VAP */
2f80ce0b78c340e Hans de Goede     2024-09-27  445  		.matches = {
2f80ce0b78c340e Hans de Goede     2024-09-27  446  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
2f80ce0b78c340e Hans de Goede     2024-09-27  447  			DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"),
2f80ce0b78c340e Hans de Goede     2024-09-27  448  		},
2f80ce0b78c340e Hans de Goede     2024-09-27  449  	},
c1ed72171ed580f Hans de Goede     2023-09-12  450  	{
158d0f3700fd719 Hans de Goede     2024-10-05  451  		/* Asus ExpertBook B1402C* */
c1ed72171ed580f Hans de Goede     2023-09-12  452  		.matches = {
c1ed72171ed580f Hans de Goede     2023-09-12  453  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
158d0f3700fd719 Hans de Goede     2024-10-05  454  			DMI_MATCH(DMI_BOARD_NAME, "B1402C"),
c1ed72171ed580f Hans de Goede     2023-09-12  455  		},
c1ed72171ed580f Hans de Goede     2023-09-12  456  	},
bd911485294a6f0 Hans de Goede     2023-11-15  457  	{
158d0f3700fd719 Hans de Goede     2024-10-05  458  		/* Asus ExpertBook B1502C* */
bd911485294a6f0 Hans de Goede     2023-11-15  459  		.matches = {
bd911485294a6f0 Hans de Goede     2023-11-15  460  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
158d0f3700fd719 Hans de Goede     2024-10-05  461  			DMI_MATCH(DMI_BOARD_NAME, "B1502C"),
ca3afc2806046f6 Nicolas Haye      2024-01-30  462  		},
ca3afc2806046f6 Nicolas Haye      2024-01-30  463  	},
77c724888238539 Tamim Khan        2022-12-30  464  	{
564a278573783cd Hans de Goede     2024-10-05  465  		/* Asus ExpertBook B2402 (B2402CBA / B2402FBA / B2402CVA / B2402FVA) */
77c724888238539 Tamim Khan        2022-12-30  466  		.matches = {
77c724888238539 Tamim Khan        2022-12-30  467  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
564a278573783cd Hans de Goede     2024-10-05  468  			DMI_MATCH(DMI_BOARD_NAME, "B2402"),
65eb2867f5bf460 Vojtech Hejsek    2023-02-16  469  		},
65eb2867f5bf460 Vojtech Hejsek    2023-02-16  470  	},
7203481fd12b125 Hans de Goede     2022-12-15  471  	{
435f2d87579e240 Hans de Goede     2024-10-05  472  		/* Asus ExpertBook B2502 (B2502CBA / B2502FBA / B2502CVA / B2502FVA) */
7203481fd12b125 Hans de Goede     2022-12-15  473  		.matches = {
7203481fd12b125 Hans de Goede     2022-12-15  474  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
435f2d87579e240 Hans de Goede     2024-10-05  475  			DMI_MATCH(DMI_BOARD_NAME, "B2502"),
056301e7c7c886f Hans de Goede     2024-09-27  476  		},
056301e7c7c886f Hans de Goede     2024-09-27  477  	},
49e9cc315604972 Tamim Khan        2024-09-02  478  	{
63539defee17bf0 Hans de Goede     2024-09-27  479  		/* Asus Vivobook Go E1404GA* */
49e9cc315604972 Tamim Khan        2024-09-02  480  		.matches = {
49e9cc315604972 Tamim Khan        2024-09-02  481  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
63539defee17bf0 Hans de Goede     2024-09-27  482  			DMI_MATCH(DMI_BOARD_NAME, "E1404GA"),
49e9cc315604972 Tamim Khan        2024-09-02  483  		},
49e9cc315604972 Tamim Khan        2024-09-02  484  	},
d2aaf19965045f7 Ben Mayo          2024-01-06  485  	{
65bdebf38e5fac7 Hans de Goede     2024-09-27  486  		/* Asus Vivobook E1504GA* */
d2aaf19965045f7 Ben Mayo          2024-01-06  487  		.matches = {
d2aaf19965045f7 Ben Mayo          2024-01-06  488  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
d2aaf19965045f7 Ben Mayo          2024-01-06  489  			DMI_MATCH(DMI_BOARD_NAME, "E1504GA"),
d2aaf19965045f7 Ben Mayo          2024-01-06  490  		},
d2aaf19965045f7 Ben Mayo          2024-01-06  491  	},
7c52c7071bd403a Tamim Khan        2024-04-28  492  	{
1af7e441feb08cd Hans de Goede     2024-10-05  493  		/* Asus Vivobook Pro N6506M* */
7c52c7071bd403a Tamim Khan        2024-04-28  494  		.matches = {
7c52c7071bd403a Tamim Khan        2024-04-28  495  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
1af7e441feb08cd Hans de Goede     2024-10-05  496  			DMI_MATCH(DMI_BOARD_NAME, "N6506M"),
e2e7f037b400aeb Tamim Khan        2024-07-07  497  		},
e2e7f037b400aeb Tamim Khan        2024-07-07  498  	},
d37273af0e428e9 Hans de Goede     2023-09-13  499  	{
424009ab2030862 Hans de Goede     2023-09-13  500  		/* LG Electronics 17U70P */
d37273af0e428e9 Hans de Goede     2023-09-13 @501  		.matches = {
d37273af0e428e9 Hans de Goede     2023-09-13  502  			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
d37273af0e428e9 Hans de Goede     2023-09-13  503  			DMI_MATCH(DMI_BOARD_NAME, "17U70P"),
d37273af0e428e9 Hans de Goede     2023-09-13  504  		},
6576e827971bb3b Christian Heusel  2024-10-16  505  		/* LG Electronics 16T90SP */
6576e827971bb3b Christian Heusel  2024-10-16  506  		.matches = {
6576e827971bb3b Christian Heusel  2024-10-16  507  			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
6576e827971bb3b Christian Heusel  2024-10-16  508  			DMI_MATCH(DMI_BOARD_NAME, "16T90SP"),
6576e827971bb3b Christian Heusel  2024-10-16  509  		},
d37273af0e428e9 Hans de Goede     2023-09-13  510  	},
e12dee3736731e2 Tamim Khan        2022-08-28  511  	{ }
e12dee3736731e2 Tamim Khan        2022-08-28  512  };
e12dee3736731e2 Tamim Khan        2022-08-28  513
diff mbox series

Patch

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 129bceb1f4a27df93439bcefdb27fd9c91258028..dd6249fb76c24f08db4149883be4548130d0ef1e 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -502,6 +502,11 @@  static const struct dmi_system_id irq1_level_low_skip_override[] = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
 			DMI_MATCH(DMI_BOARD_NAME, "17U70P"),
 		},
+		/* LG Electronics 16T90SP */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"),
+			DMI_MATCH(DMI_BOARD_NAME, "16T90SP"),
+		},
 	},
 	{ }
 };