diff mbox series

dt-bindings: interrupt-controller: qcom,pdc: Add SAR2130P compatible

Message ID 20241017-sar2130p-pdc-v1-1-cf9ccd9c37da@linaro.org
State Accepted
Commit 919e0dd4118ee6fafd2d63d31ecf0c98fec7a152
Headers show
Series dt-bindings: interrupt-controller: qcom,pdc: Add SAR2130P compatible | expand

Commit Message

Dmitry Baryshkov Oct. 17, 2024, 6:13 p.m. UTC
Document compatible for PDC interrupt controller on SAR2130P platform.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
 Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
 1 file changed, 1 insertion(+)


---
base-commit: 7df1e7189cecb6965ce672e820a5ec6cf499b65b
change-id: 20241017-sar2130p-pdc-18d3f08abdbe

Best regards,

Comments

Krzysztof Kozlowski Oct. 18, 2024, 7:19 a.m. UTC | #1
On Thu, Oct 17, 2024 at 09:13:01PM +0300, Dmitry Baryshkov wrote:
> Document compatible for PDC interrupt controller on SAR2130P platform.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
>  Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 

This will be picked up by Bjorn, so should be part of patchset
targetting SoC (just like few others, e.g. firmware). Please target same
maintainer tree/subsystem within one patchset.

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 18, 2024, 7:20 a.m. UTC | #2
On 18/10/2024 09:19, Krzysztof Kozlowski wrote:
> On Thu, Oct 17, 2024 at 09:13:01PM +0300, Dmitry Baryshkov wrote:
>> Document compatible for PDC interrupt controller on SAR2130P platform.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>> ---
>>  Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
> 
> This will be picked up by Bjorn, so should be part of patchset
> targetting SoC (just like few others, e.g. firmware). Please target same
> maintainer tree/subsystem within one patchset.

And I forgot:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Rob Herring (Arm) Nov. 8, 2024, 9:13 p.m. UTC | #3
On Thu, Oct 31, 2024 at 07:34:41PM +0200, Dmitry Baryshkov wrote:
> On Thu, Oct 17, 2024 at 09:13:01PM +0300, Dmitry Baryshkov wrote:
> > Document compatible for PDC interrupt controller on SAR2130P platform.
> > 
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Gracious ping, the patch has been acked by DT maintainers, but is still
> not present in linux-next and got no other reviews.

Applied.

> Krzysztof mentioned that the patch should be picked up by Bjorn, but all
> previous patches for PDC schema were picked up by Rob Herring or by Marc
> Zyngier (and one stray patch was picked up by Linus Walleij).

My preference is for it to be applied with the driver or dts changes. 
For standalone patches, I only pick them up if the $subsystem maintainer 
does not.

Rob
Dmitry Baryshkov Nov. 8, 2024, 10:45 p.m. UTC | #4
On Fri, 8 Nov 2024 at 23:13, Rob Herring <robh@kernel.org> wrote:
>
> On Thu, Oct 31, 2024 at 07:34:41PM +0200, Dmitry Baryshkov wrote:
> > On Thu, Oct 17, 2024 at 09:13:01PM +0300, Dmitry Baryshkov wrote:
> > > Document compatible for PDC interrupt controller on SAR2130P platform.
> > >
> > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > > ---
> > >  Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml | 1 +
> > >  1 file changed, 1 insertion(+)
> >
> > Gracious ping, the patch has been acked by DT maintainers, but is still
> > not present in linux-next and got no other reviews.
>
> Applied.
>
> > Krzysztof mentioned that the patch should be picked up by Bjorn, but all
> > previous patches for PDC schema were picked up by Rob Herring or by Marc
> > Zyngier (and one stray patch was picked up by Linus Walleij).
>
> My preference is for it to be applied with the driver or dts changes.
> For standalone patches, I only pick them up if the $subsystem maintainer
> does not.

Understood, thank you!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
index b1ea08a41bb0c369985c5f2d5b4c4644367a88dd..a54da66a89e73212f7b965997dc487d9f0d421b0 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.yaml
@@ -29,6 +29,7 @@  properties:
           - qcom,qdu1000-pdc
           - qcom,sa8255p-pdc
           - qcom,sa8775p-pdc
+          - qcom,sar2130p-pdc
           - qcom,sc7180-pdc
           - qcom,sc7280-pdc
           - qcom,sc8180x-pdc