| Message ID | 20241018150337.2182181-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] i2c: Use *-y instead of *-objs in Makefile | expand |
On Fri, Oct 18, 2024 at 06:03:37PM +0300, Andy Shevchenko wrote: > *-objs suffix is reserved rather for (user-space) host programs while > usually *-y suffix is used for kernel drivers (although *-objs works > for that purpose for now). > > Let's correct the old usages of *-objs in Makefiles. Any comments?
On Fri, Nov 01, 2024 at 02:43:47PM +0200, Wolfram Sang wrote: > > > > Let's correct the old usages of *-objs in Makefiles. > > > > Any comments? > > LGTM. What about fixing the drivers, too, in one go? What drivers do you have in mind? Shouldn't be separated commit anyway?
On Fri, Nov 01, 2024 at 03:06:46PM +0200, Andy Shevchenko wrote: > On Fri, Nov 01, 2024 at 02:43:47PM +0200, Wolfram Sang wrote: > > > > > > Let's correct the old usages of *-objs in Makefiles. > > > > > > Any comments? > > > > LGTM. What about fixing the drivers, too, in one go? > > What drivers do you have in mind? > Shouldn't be separated commit anyway? A separate patch just has been sent.
> > Shouldn't be separated commit anyway?
Can be argued.
This patch applied to for-next, thanks!
On Mon, Nov 04, 2024 at 01:05:20PM +0200, Wolfram Sang wrote: > > > > Shouldn't be separated commit anyway? > > Can be argued. I have an evidence for my side: LKP complained as my (thanks to be a separate) patch unveiled the issue in the Kconfig there. Meaning that required a new version of the change, while the core part is not affected anyhow. > This patch applied to for-next, thanks! Thank you!
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile index f12d6b10a85e..af95d6e7f004 100644 --- a/drivers/i2c/Makefile +++ b/drivers/i2c/Makefile @@ -5,7 +5,7 @@ obj-$(CONFIG_I2C_BOARDINFO) += i2c-boardinfo.o obj-$(CONFIG_I2C) += i2c-core.o -i2c-core-objs := i2c-core-base.o i2c-core-smbus.o +i2c-core-y := i2c-core-base.o i2c-core-smbus.o i2c-core-$(CONFIG_ACPI) += i2c-core-acpi.o i2c-core-$(CONFIG_I2C_SLAVE) += i2c-core-slave.o i2c-core-$(CONFIG_OF) += i2c-core-of.o
*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now). Let's correct the old usages of *-objs in Makefiles. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/i2c/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)