| Message ID | 20241020195717.CD7CC17525E@bout3.ijzerbout.nl |
|---|---|
| State | New |
| Headers | show |
| Series | HID: corsair-void: Add missing initializer | expand |
Good catch, thanks Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC Jiri Kosina and Benjamin Tissoires, as they can actually apply this. Stuart On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote: > > This was detected by Coverity, CID 1600743 > > Signed-off-by: Kees Bakker <kees@ijzerbout.nl> > --- > drivers/hid/hid-corsair-void.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c > index 6ece56b850fc..d1fd04264656 100644 > --- a/drivers/hid/hid-corsair-void.c > +++ b/drivers/hid/hid-corsair-void.c > @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work) > static void corsair_void_battery_add_work_handler(struct work_struct *work) > { > struct corsair_void_drvdata *drvdata; > - struct power_supply_config psy_cfg; > + struct power_supply_config psy_cfg = {}; > struct power_supply *new_supply; > > drvdata = container_of(work, struct corsair_void_drvdata, > -- > 2.47.0 >
Checked the script, CCed missing people Stuart On Thu, 24 Oct 2024 at 02:51, Stuart <stuart.a.hayhurst@gmail.com> wrote: > > Good catch, thanks > > Are you aware of 'scripts/get_maintainer.pl'? It might tell you to CC > Jiri Kosina and Benjamin Tissoires, as they can actually apply this. > > Stuart > > On Sun, 20 Oct 2024 at 20:57, Kees Bakker <kees@ijzerbout.nl> wrote: > > > > This was detected by Coverity, CID 1600743 > > > > Signed-off-by: Kees Bakker <kees@ijzerbout.nl> > > --- > > drivers/hid/hid-corsair-void.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c > > index 6ece56b850fc..d1fd04264656 100644 > > --- a/drivers/hid/hid-corsair-void.c > > +++ b/drivers/hid/hid-corsair-void.c > > @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work) > > static void corsair_void_battery_add_work_handler(struct work_struct *work) > > { > > struct corsair_void_drvdata *drvdata; > > - struct power_supply_config psy_cfg; > > + struct power_supply_config psy_cfg = {}; > > struct power_supply *new_supply; > > > > drvdata = container_of(work, struct corsair_void_drvdata, > > -- > > 2.47.0 > >
diff --git a/drivers/hid/hid-corsair-void.c b/drivers/hid/hid-corsair-void.c index 6ece56b850fc..d1fd04264656 100644 --- a/drivers/hid/hid-corsair-void.c +++ b/drivers/hid/hid-corsair-void.c @@ -553,7 +553,7 @@ static void corsair_void_battery_remove_work_handler(struct work_struct *work) static void corsair_void_battery_add_work_handler(struct work_struct *work) { struct corsair_void_drvdata *drvdata; - struct power_supply_config psy_cfg; + struct power_supply_config psy_cfg = {}; struct power_supply *new_supply; drvdata = container_of(work, struct corsair_void_drvdata,
This was detected by Coverity, CID 1600743 Signed-off-by: Kees Bakker <kees@ijzerbout.nl> --- drivers/hid/hid-corsair-void.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)