diff mbox series

board_r: Remove duplicate headers

Message ID 20241023052750.1067020-1-ilias.apalodimas@linaro.org
State Accepted
Commit 92e75ee47f12131306b6a0c501bf8b7cedfe3818
Headers show
Series board_r: Remove duplicate headers | expand

Commit Message

Ilias Apalodimas Oct. 23, 2024, 5:27 a.m. UTC
efi_loader.h is included twice. Remove one and move the other in
alphabetical order

Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
---
 common/board_r.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Peter Robinson Oct. 23, 2024, 7:25 a.m. UTC | #1
On Wed, 23 Oct 2024 at 06:28, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> efi_loader.h is included twice. Remove one and move the other in
> alphabetical order
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Reviewed-by: Peter Robinson <pbrobinson@gmail.com>

LGTM

> ---
>  common/board_r.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/common/board_r.c b/common/board_r.c
> index e5f33f40643b..61b15d01c25f 100644
> --- a/common/board_r.c
> +++ b/common/board_r.c
> @@ -32,6 +32,7 @@
>  #include <command.h>
>  #include <console.h>
>  #include <dm.h>
> +#include <efi_loader.h>
>  #include <env.h>
>  #include <env_internal.h>
>  #include <fdtdec.h>
> @@ -63,10 +64,8 @@
>  #include <dm/ofnode.h>
>  #include <linux/compiler.h>
>  #include <linux/err.h>
> -#include <efi_loader.h>
>  #include <wdt.h>
>  #include <asm-generic/gpio.h>
> -#include <efi_loader.h>
>  #include <relocate.h>
>
>  DECLARE_GLOBAL_DATA_PTR;
> --
> 2.45.2
>
Tom Rini Oct. 29, 2024, 10:28 p.m. UTC | #2
On Wed, 23 Oct 2024 08:27:50 +0300, Ilias Apalodimas wrote:

> efi_loader.h is included twice. Remove one and move the other in
> alphabetical order
> 
> 

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/common/board_r.c b/common/board_r.c
index e5f33f40643b..61b15d01c25f 100644
--- a/common/board_r.c
+++ b/common/board_r.c
@@ -32,6 +32,7 @@ 
 #include <command.h>
 #include <console.h>
 #include <dm.h>
+#include <efi_loader.h>
 #include <env.h>
 #include <env_internal.h>
 #include <fdtdec.h>
@@ -63,10 +64,8 @@ 
 #include <dm/ofnode.h>
 #include <linux/compiler.h>
 #include <linux/err.h>
-#include <efi_loader.h>
 #include <wdt.h>
 #include <asm-generic/gpio.h>
-#include <efi_loader.h>
 #include <relocate.h>
 
 DECLARE_GLOBAL_DATA_PTR;