| Message ID | 20241025061711.198933-3-tony467913@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/6] driver: usb: serial: mos7840: fix style warnings | expand |
On Fri, Oct 25, 2024 at 02:17:10PM +0800, Tony Chung wrote: > fix block comments coding style warnings. > 1. Block comments use * on subsequent lines > 2. Block comments use a trailing */ on a separate line Just say something like: Clean up the style of the block comments. or similar. > Signed-off-by: Tony Chung <tony467913@gmail.com> > --- > drivers/usb/serial/mos7840.c | 20 +++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c > index dcaed0f26..b1a794f99 100644 > --- a/drivers/usb/serial/mos7840.c > +++ b/drivers/usb/serial/mos7840.c > @@ -282,7 +282,8 @@ static int mos7840_set_uart_reg(struct usb_serial_port *port, __u16 reg, > struct usb_device *dev = port->serial->dev; > val = val & 0x00ff; > /* For the UART control registers, the application number need > - to be Or'ed */ > + * to be Or'ed > + */ > if (port->serial->num_ports == 2 && port->port_number != 0) > val |= ((__u16)port->port_number + 2) << 8; > else > @@ -1539,8 +1540,9 @@ static int mos7840_port_probe(struct usb_serial_port *port) > int pnum; > __u16 Data; > > - /* we set up the pointers to the endpoints in the mos7840_open * > - * function, as the structures aren't created yet. */ > + /* we set up the pointers to the endpoints in the mos7840_open This style is only valid in networking code; the format for block comments should generally be: /* * ... */ > + * function, as the structures aren't created yet. > + */ > > pnum = port->port_number; > > @@ -1551,14 +1553,16 @@ static int mos7840_port_probe(struct usb_serial_port *port) > > /* Initialize all port interrupt end point to port 0 int > * endpoint. Our device has only one interrupt end point > - * common to all port */ > + * common to all port > + */ > > mos7840_port->port = port; > spin_lock_init(&mos7840_port->pool_lock); > > /* minor is not initialised until later by > * usb-serial.c:get_free_serial() and cannot therefore be used > - * to index device instances */ > + * to index device instances > + */ > mos7840_port->port_num = pnum + 1; > dev_dbg(&port->dev, "port->minor = %d\n", port->minor); > dev_dbg(&port->dev, "mos7840_port->port_num = %d\n", mos7840_port->port_num); > @@ -1591,7 +1595,8 @@ static int mos7840_port_probe(struct usb_serial_port *port) > dev_dbg(&port->dev, "ControlReg Reading success val is %x, status%d\n", Data, status); > Data |= 0x08; /* setting driver done bit */ > Data |= 0x04; /* sp1_bit to have cts change reflect in > - modem status reg */ > + * modem status reg > + */ Just drop the new line, this can be an exception to the 80 char rule if you can't find a good way to rephrase this. > /* Data |= 0x20; //rx_disable bit */ > status = mos7840_set_reg_sync(port, Johan
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index dcaed0f26..b1a794f99 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -282,7 +282,8 @@ static int mos7840_set_uart_reg(struct usb_serial_port *port, __u16 reg, struct usb_device *dev = port->serial->dev; val = val & 0x00ff; /* For the UART control registers, the application number need - to be Or'ed */ + * to be Or'ed + */ if (port->serial->num_ports == 2 && port->port_number != 0) val |= ((__u16)port->port_number + 2) << 8; else @@ -1539,8 +1540,9 @@ static int mos7840_port_probe(struct usb_serial_port *port) int pnum; __u16 Data; - /* we set up the pointers to the endpoints in the mos7840_open * - * function, as the structures aren't created yet. */ + /* we set up the pointers to the endpoints in the mos7840_open + * function, as the structures aren't created yet. + */ pnum = port->port_number; @@ -1551,14 +1553,16 @@ static int mos7840_port_probe(struct usb_serial_port *port) /* Initialize all port interrupt end point to port 0 int * endpoint. Our device has only one interrupt end point - * common to all port */ + * common to all port + */ mos7840_port->port = port; spin_lock_init(&mos7840_port->pool_lock); /* minor is not initialised until later by * usb-serial.c:get_free_serial() and cannot therefore be used - * to index device instances */ + * to index device instances + */ mos7840_port->port_num = pnum + 1; dev_dbg(&port->dev, "port->minor = %d\n", port->minor); dev_dbg(&port->dev, "mos7840_port->port_num = %d\n", mos7840_port->port_num); @@ -1591,7 +1595,8 @@ static int mos7840_port_probe(struct usb_serial_port *port) dev_dbg(&port->dev, "ControlReg Reading success val is %x, status%d\n", Data, status); Data |= 0x08; /* setting driver done bit */ Data |= 0x04; /* sp1_bit to have cts change reflect in - modem status reg */ + * modem status reg + */ /* Data |= 0x20; //rx_disable bit */ status = mos7840_set_reg_sync(port, @@ -1603,7 +1608,8 @@ static int mos7840_port_probe(struct usb_serial_port *port) dev_dbg(&port->dev, "ControlReg Writing success(rx_disable) status%d\n", status); /* Write default values in DCR (i.e 0x01 in DCR0, 0x05 in DCR2 - and 0x24 in DCR3 */ + * and 0x24 in DCR3 + */ Data = 0x01; status = mos7840_set_reg_sync(port, (__u16) (mos7840_port->DcrRegOffset + 0), Data);
fix block comments coding style warnings. 1. Block comments use * on subsequent lines 2. Block comments use a trailing */ on a separate line Signed-off-by: Tony Chung <tony467913@gmail.com> --- drivers/usb/serial/mos7840.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-)