diff mbox series

ACPI: thermal: Use strscpy instead of strcpy.

Message ID 20241027083007.11199-1-qasim.majeed20@gmail.com
State New
Headers show
Series ACPI: thermal: Use strscpy instead of strcpy. | expand

Commit Message

Muhammad Qasim Abdul Majeed Oct. 27, 2024, 8:28 a.m. UTC
Replace strcpy() with strscpy() in the ACPI thermal driver.

strcpy() has been deprecated because it is generally unsafe.
Eliminating it from the kernel source.

Link: https://github.com/KSPP/linux/issues/88
Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>

Hi Rafael,

Any update on the patches?

Best Regards,
Qasim

---
 drivers/acpi/thermal.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Rafael J. Wysocki Nov. 5, 2024, 8:22 p.m. UTC | #1
On Sun, Oct 27, 2024 at 9:30 AM Muhammad Qasim Abdul Majeed
<qasim.majeed20@gmail.com> wrote:
>
> Replace strcpy() with strscpy() in the ACPI thermal driver.
>
> strcpy() has been deprecated because it is generally unsafe.
> Eliminating it from the kernel source.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com>
>
> Hi Rafael,
>
> Any update on the patches?
>
> Best Regards,
> Qasim
>
> ---
>  drivers/acpi/thermal.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
> index a0cfc857fb55..0c69d04fbac9 100644
> --- a/drivers/acpi/thermal.c
> +++ b/drivers/acpi/thermal.c
> @@ -842,9 +842,9 @@ static int acpi_thermal_add(struct acpi_device *device)
>                 return -ENOMEM;
>
>         tz->device = device;
> -       strcpy(tz->name, device->pnp.bus_id);
> -       strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> -       strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
> +       strscpy(tz->name, device->pnp.bus_id);
> +       strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
> +       strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
>         device->driver_data = tz;
>
>         acpi_thermal_aml_dependency_fix(tz);
> --

Applied (with edits in the changelog) as 6.13 material, thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
index a0cfc857fb55..0c69d04fbac9 100644
--- a/drivers/acpi/thermal.c
+++ b/drivers/acpi/thermal.c
@@ -842,9 +842,9 @@  static int acpi_thermal_add(struct acpi_device *device)
 		return -ENOMEM;
 
 	tz->device = device;
-	strcpy(tz->name, device->pnp.bus_id);
-	strcpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
-	strcpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
+	strscpy(tz->name, device->pnp.bus_id);
+	strscpy(acpi_device_name(device), ACPI_THERMAL_DEVICE_NAME);
+	strscpy(acpi_device_class(device), ACPI_THERMAL_CLASS);
 	device->driver_data = tz;
 
 	acpi_thermal_aml_dependency_fix(tz);