diff mbox series

altera_jtaguart: Use dev_err() to report error attaching IRQ

Message ID 20241029130307.5003-1-tklauser@distanz.ch
State New
Headers show
Series altera_jtaguart: Use dev_err() to report error attaching IRQ | expand

Commit Message

Tobias Klauser Oct. 29, 2024, 1:03 p.m. UTC
In case of multiple Altera JTAG UART ports available on the system, the
error message will contain information about the port for which
attaching the IRQ handler failed.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/tty/serial/altera_jtaguart.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jiri Slaby Oct. 30, 2024, 5:16 a.m. UTC | #1
On 29. 10. 24, 14:03, Tobias Klauser wrote:
> In case of multiple Altera JTAG UART ports available on the system, the
> error message will contain information about the port for which
> attaching the IRQ handler failed.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
diff mbox series

Patch

diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
index 6162108c758e..4c7bde5dd856 100644
--- a/drivers/tty/serial/altera_jtaguart.c
+++ b/drivers/tty/serial/altera_jtaguart.c
@@ -175,7 +175,7 @@  static int altera_jtaguart_startup(struct uart_port *port)
 	ret = request_irq(port->irq, altera_jtaguart_interrupt, 0,
 			DRV_NAME, port);
 	if (ret) {
-		pr_err(DRV_NAME ": unable to attach Altera JTAG UART %d "
+		dev_err(port->dev, "unable to attach Altera JTAG UART %d "
 		       "interrupt vector=%d\n", port->line, port->irq);
 		return ret;
 	}