| Message ID | 20241101101441.3518612-4-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-acpi: A few cleanups | expand |
On 1/11/24 12:11, Andy Shevchenko wrote: > First of all, this error message is just informative and doesn't prevent > driver from going on. Second, the ioremap() on many architectures just > works on page size granularity, which is higher than 256 bytes. Last, > but not lease, this is an impediment for furhter cleanups, hence remove lease -> least furhter -> further > it. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/mmc/host/sdhci-acpi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c > index 5241c5c26891..f861e9a3a911 100644 > --- a/drivers/mmc/host/sdhci-acpi.c > +++ b/drivers/mmc/host/sdhci-acpi.c > @@ -849,9 +849,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev) > return -ENOMEM; > > len = resource_size(iomem); > - if (len < 0x100) > - dev_err(dev, "Invalid iomem size!\n"); > - > if (!devm_request_mem_region(dev, iomem->start, len, dev_name(dev))) > return -ENOMEM; >
diff --git a/drivers/mmc/host/sdhci-acpi.c b/drivers/mmc/host/sdhci-acpi.c index 5241c5c26891..f861e9a3a911 100644 --- a/drivers/mmc/host/sdhci-acpi.c +++ b/drivers/mmc/host/sdhci-acpi.c @@ -849,9 +849,6 @@ static int sdhci_acpi_probe(struct platform_device *pdev) return -ENOMEM; len = resource_size(iomem); - if (len < 0x100) - dev_err(dev, "Invalid iomem size!\n"); - if (!devm_request_mem_region(dev, iomem->start, len, dev_name(dev))) return -ENOMEM;
First of all, this error message is just informative and doesn't prevent driver from going on. Second, the ioremap() on many architectures just works on page size granularity, which is higher than 256 bytes. Last, but not lease, this is an impediment for furhter cleanups, hence remove it. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/mmc/host/sdhci-acpi.c | 3 --- 1 file changed, 3 deletions(-)