diff mbox series

[1/3] system/dma-helpers.c: Move trace events to system/trace-events

Message ID 20241108162909.4080314-2-peter.maydell@linaro.org
State Superseded
Headers show
Series trace: Minor cleanups to trace header includes | expand

Commit Message

Peter Maydell Nov. 8, 2024, 4:29 p.m. UTC 
The dma-helpers.c file is in the system/ subdirectory, but it
defines its trace events in the root trace-events file. Move
them to the system/trace-events file where they more naturally
belong.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 system/dma-helpers.c | 2 +-
 system/trace-events  | 7 +++++++
 trace-events         | 7 -------
 3 files changed, 8 insertions(+), 8 deletions(-)

Comments

Philippe Mathieu-Daudé Nov. 8, 2024, 5:09 p.m. UTC | #1 
On 8/11/24 16:29, Peter Maydell wrote:
> The dma-helpers.c file is in the system/ subdirectory, but it
> defines its trace events in the root trace-events file. Move
> them to the system/trace-events file where they more naturally
> belong.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   system/dma-helpers.c | 2 +-
>   system/trace-events  | 7 +++++++
>   trace-events         | 7 -------
>   3 files changed, 8 insertions(+), 8 deletions(-)

Fixes: 800d4deda0 ("softmmu: move more files to softmmu/")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/system/dma-helpers.c b/system/dma-helpers.c
index 74013308f52..cbcd89dfaaa 100644
--- a/system/dma-helpers.c
+++ b/system/dma-helpers.c
@@ -10,7 +10,7 @@ 
 #include "qemu/osdep.h"
 #include "sysemu/block-backend.h"
 #include "sysemu/dma.h"
-#include "trace/trace-root.h"
+#include "trace.h"
 #include "qemu/thread.h"
 #include "qemu/main-loop.h"
 #include "sysemu/cpu-timers.h"
diff --git a/system/trace-events b/system/trace-events
index 2ed1d59b1fb..5bbc3fbffac 100644
--- a/system/trace-events
+++ b/system/trace-events
@@ -4,6 +4,13 @@ 
 # Since requests are raised via monitor, not many tracepoints are needed.
 balloon_event(void *opaque, unsigned long addr) "opaque %p addr %lu"
 
+# dma-helpers.c
+dma_blk_io(void *dbs, void *bs, int64_t offset, bool to_dev) "dbs=%p bs=%p offset=%" PRId64 " to_dev=%d"
+dma_aio_cancel(void *dbs) "dbs=%p"
+dma_complete(void *dbs, int ret, void *cb) "dbs=%p ret=%d cb=%p"
+dma_blk_cb(void *dbs, int ret) "dbs=%p ret=%d"
+dma_map_wait(void *dbs) "dbs=%p"
+
 # ioport.c
 cpu_in(unsigned int addr, char size, unsigned int val) "addr 0x%x(%c) value %u"
 cpu_out(unsigned int addr, char size, unsigned int val) "addr 0x%x(%c) value %u"
diff --git a/trace-events b/trace-events
index 9cb96f64c4a..3ec8a6c7202 100644
--- a/trace-events
+++ b/trace-events
@@ -30,13 +30,6 @@  breakpoint_insert(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64
 breakpoint_remove(int cpu_index, uint64_t pc, int flags) "cpu=%d pc=0x%" PRIx64 " flags=0x%x"
 breakpoint_singlestep(int cpu_index, int enabled) "cpu=%d enable=%d"
 
-# dma-helpers.c
-dma_blk_io(void *dbs, void *bs, int64_t offset, bool to_dev) "dbs=%p bs=%p offset=%" PRId64 " to_dev=%d"
-dma_aio_cancel(void *dbs) "dbs=%p"
-dma_complete(void *dbs, int ret, void *cb) "dbs=%p ret=%d cb=%p"
-dma_blk_cb(void *dbs, int ret) "dbs=%p ret=%d"
-dma_map_wait(void *dbs) "dbs=%p"
-
 # job.c
 job_state_transition(void *job,  int ret, const char *legal, const char *s0, const char *s1) "job %p (ret: %d) attempting %s transition (%s-->%s)"
 job_apply_verb(void *job, const char *state, const char *verb, const char *legal) "job %p in state %s; applying verb %s (%s)"