| Message ID | 20241112222516.1.I7fa78e6acbbed56ed5677f5e2dacc098a269d955@changeid |
|---|---|
| State | Accepted |
| Commit | 295991836b23c12ddb447f7f583a17fd3616ad7d |
| Headers | show |
| Series | ACPI: video: force native for Apple MacbookPro11,2 and Air7,2 | expand |
On Tue, Nov 12, 2024 at 11:25 PM Jonathan Denose <jdenose@google.com> wrote: > > There is a bug in the Macbook Pro 11,2 and Air 7,2 firmware similar to > what is described in: > > commit 7dc918daaf29 ("ACPI: video: force native for Apple > MacbookPro9,2") > > This bug causes their backlights not to come back after resume. > > This commit adds DMI quirks to select the working native intel firmware > interface such that the backlght comes back on after resume. > > Signed-off-by: Jonathan Denose <jdenose@google.com> > --- > > drivers/acpi/video_detect.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 015bd8e66c1cf..d507d5e084354 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -549,6 +549,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"), > }, > }, > + { > + .callback = video_detect_force_native, > + /* Apple MacBook Air 7,2 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir7,2"), > + }, > + }, > { > .callback = video_detect_force_native, > /* Apple MacBook Air 9,1 */ > @@ -565,6 +573,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro9,2"), > }, > }, > + { > + .callback = video_detect_force_native, > + /* Apple MacBook Pro 11,2 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro11,2"), > + }, > + }, > { > /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */ > .callback = video_detect_force_native, > -- Applied as 6.13 material, thanks!
diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c index 015bd8e66c1cf..d507d5e084354 100644 --- a/drivers/acpi/video_detect.c +++ b/drivers/acpi/video_detect.c @@ -549,6 +549,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "iMac12,2"), }, }, + { + .callback = video_detect_force_native, + /* Apple MacBook Air 7,2 */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookAir7,2"), + }, + }, { .callback = video_detect_force_native, /* Apple MacBook Air 9,1 */ @@ -565,6 +573,14 @@ static const struct dmi_system_id video_detect_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro9,2"), }, }, + { + .callback = video_detect_force_native, + /* Apple MacBook Pro 11,2 */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "MacBookPro11,2"), + }, + }, { /* https://bugzilla.redhat.com/show_bug.cgi?id=1217249 */ .callback = video_detect_force_native,
There is a bug in the Macbook Pro 11,2 and Air 7,2 firmware similar to what is described in: commit 7dc918daaf29 ("ACPI: video: force native for Apple MacbookPro9,2") This bug causes their backlights not to come back after resume. This commit adds DMI quirks to select the working native intel firmware interface such that the backlght comes back on after resume. Signed-off-by: Jonathan Denose <jdenose@google.com> --- drivers/acpi/video_detect.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)