| Message ID | 1480183585-592-7-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 61e1e33..b2b050b 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -834,7 +834,7 @@ static int write_oob_data(struct mtd_info *mtd, uint8_t *buf, int page) denali->page = page; - if (denali_send_pipeline_cmd(denali, false, false, SPARE_ACCESS, + if (denali_send_pipeline_cmd(denali, false, true, SPARE_ACCESS, DENALI_WRITE) == PASS) { write_data_to_flash_mem(denali, buf, mtd->oobsize);
The function write_oob_data() performs write access to the spare area, so passing "false" to the 3rd argument (transfer_spare) of denali_send_pipeline_cmd() is weird. Actually, the transfer_spare is ignored for MAP10 operation with SPARE_ACCESS (0x41), so this change has no impact on the hardware behavior. Yet, we should keep our code to make sense. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- drivers/mtd/nand/denali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.7.4 ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/