| Message ID | 20241203125654.29657-1-tklauser@distanz.ch |
|---|---|
| State | New |
| Headers | show |
| Series | serial: altera_jtaguart: Use DRV_NAME to initialize uart_driver.driver_name | expand |
On Tue, Dec 03, 2024 at 01:56:54PM +0100, Tobias Klauser wrote: > Use the DRV_NAME constant instead of the verbatim string. Why? > > Signed-off-by: Tobias Klauser <tklauser@distanz.ch> > --- > drivers/tty/serial/altera_jtaguart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c > index b9c3c3bed0c1..9657c3bb8e66 100644 > --- a/drivers/tty/serial/altera_jtaguart.c > +++ b/drivers/tty/serial/altera_jtaguart.c > @@ -365,7 +365,7 @@ OF_EARLYCON_DECLARE(juart, "altr,juart-1.0", altera_jtaguart_earlycon_setup); > > static struct uart_driver altera_jtaguart_driver = { > .owner = THIS_MODULE, > - .driver_name = "altera_jtaguart", > + .driver_name = DRV_NAME, Why don't we just use KBUILD_MODNAME here and get rid of DRV_NAME entirely? thanks, greg k-h
diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c index b9c3c3bed0c1..9657c3bb8e66 100644 --- a/drivers/tty/serial/altera_jtaguart.c +++ b/drivers/tty/serial/altera_jtaguart.c @@ -365,7 +365,7 @@ OF_EARLYCON_DECLARE(juart, "altr,juart-1.0", altera_jtaguart_earlycon_setup); static struct uart_driver altera_jtaguart_driver = { .owner = THIS_MODULE, - .driver_name = "altera_jtaguart", + .driver_name = DRV_NAME, .dev_name = "ttyJ", .major = ALTERA_JTAGUART_MAJOR, .minor = ALTERA_JTAGUART_MINOR,
Use the DRV_NAME constant instead of the verbatim string. Signed-off-by: Tobias Klauser <tklauser@distanz.ch> --- drivers/tty/serial/altera_jtaguart.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)