diff mbox series

[7/7] gpio: graniterapids: Fix GPIO Ack functionality

Message ID 20241204070415.1034449-8-mika.westerberg@linux.intel.com
State New
Headers show
Series gpio: Fixes for Granite Rapids vGPIO driver | expand

Commit Message

Mika Westerberg Dec. 4, 2024, 7:04 a.m. UTC 
From: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>

Interrupt status (GPI_IS) register is cleared by writing 1 to it, not 0.

Cc: stable@vger.kernel.org
Signed-off-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
 drivers/gpio/gpio-graniterapids.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-graniterapids.c b/drivers/gpio/gpio-graniterapids.c
index 3a972d460fe2..ad6a045fd3d2 100644
--- a/drivers/gpio/gpio-graniterapids.c
+++ b/drivers/gpio/gpio-graniterapids.c
@@ -185,7 +185,7 @@  static void gnr_gpio_irq_ack(struct irq_data *d)
 	guard(raw_spinlock_irqsave)(&priv->lock);
 
 	reg = readl(addr);
-	reg &= ~BIT(bit_idx);
+	reg |= BIT(bit_idx);
 	writel(reg, addr);
 }