| Message ID | 20241213-qcs615-gpu-dt-v2-2-6606c64f03b5@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Devicetree changes for QCS615's GPU | expand |
On 13.12.2024 11:35 AM, Akhil P Oommen wrote: > RGMU a.k.a Reduced Graphics Management Unit is a small state machine > with the sole purpose of providing IFPC support. Compared to GMU, it > doesn't manage GPU clock, voltage scaling, bw voting or any other > functionalities. All it does is detect an idle GPU and toggle the > GDSC switch. So it doesn't require iommu & opp table. > > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> > --- The bindings file exists so that people that are not in the know, can reference it and learn about the hardware. Please spell out IFPC, as that's a non-obvious, hw-specific acronym. Otherwise looks ok Konrad
On 12/13/2024 4:23 PM, Konrad Dybcio wrote: > On 13.12.2024 11:35 AM, Akhil P Oommen wrote: >> RGMU a.k.a Reduced Graphics Management Unit is a small state machine >> with the sole purpose of providing IFPC support. Compared to GMU, it >> doesn't manage GPU clock, voltage scaling, bw voting or any other >> functionalities. All it does is detect an idle GPU and toggle the >> GDSC switch. So it doesn't require iommu & opp table. >> >> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >> --- > > The bindings file exists so that people that are not in the know, can > reference it and learn about the hardware. Please spell out IFPC, as > that's a non-obvious, hw-specific acronym. > > Otherwise looks ok Ah right. Krzysztof schooled me that a while ago. Will update. -Akhil. > > Konrad
diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml index b1bd372996d5..6889dda7d4be 100644 --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml @@ -27,6 +27,7 @@ properties: - pattern: '^qcom,adreno-gmu-x[1-9][0-9][0-9]\.[0-9]$' - const: qcom,adreno-gmu - const: qcom,adreno-gmu-wrapper + - const: qcom,adreno-rgmu reg: minItems: 1 @@ -267,12 +268,14 @@ allOf: properties: compatible: contains: - const: qcom,adreno-gmu-wrapper + enum: + - qcom,adreno-gmu-wrapper + - qcom,adreno-rgmu then: properties: reg: items: - - description: GMU wrapper register space + - description: RGMU/GMU wrapper register space reg-names: items: - const: gmu
RGMU a.k.a Reduced Graphics Management Unit is a small state machine with the sole purpose of providing IFPC support. Compared to GMU, it doesn't manage GPU clock, voltage scaling, bw voting or any other functionalities. All it does is detect an idle GPU and toggle the GDSC switch. So it doesn't require iommu & opp table. Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> --- Documentation/devicetree/bindings/display/msm/gmu.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)