| Message ID | 20250102-b4-gs101_max77759_fg-v2-4-87959abeb7ff@uclouvain.be |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/4] power: supply: add support for max77759 fuel gauge | expand |
Hi Thomas, Thanks for your patch! On Thu, 2025-01-02 at 12:15 +0100, Thomas Antoine via B4 Relay wrote: > From: Thomas Antoine <t.antoine@uclouvain.be> > > Add the node for the max77759 fuel gauge as a slave of the i2c. > > The todo is still applicable given there are other slaves on the > bus (pca9468, other max77759 functions and the max20339 OVP). > > The fuel gauge has been tested and seems to give coherent results. > Manual activation of the charger via i2cset shows that the sign of > the current does indicate charging/discharging status. > > Signed-off-by: Thomas Antoine <t.antoine@uclouvain.be> > --- > arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > index 387fb779bd29ea3812331a7951f03b181c5fe659..6c83ee6f8a6b0327c576573d03a8d2bcc93f9e16 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > @@ -10,6 +10,7 @@ > > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > +#include <dt-bindings/interrupt-controller/irq.h> > #include "gs101-pinctrl.h" > #include "gs101.dtsi" > > @@ -90,6 +91,15 @@ eeprom: eeprom@50 { > &hsi2c_12 { > status = "okay"; > /* TODO: add the devices once drivers exist */ > + > + fuel-gauge@36 { > + compatible = "maxim,max77759-fg"; > + reg = <0x36>; > + reg-names = "m5"; > + shunt-resistor-micro-ohms = <5000>; > + interrupt-parent = <&gpa9>; > + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; > + }; The order of properties within a node should follow Documentation/devicetree/bindings/dts-coding-style.rst In particular shunt-resistor-micro-ohms should come last in this case. Cheers, Andre'
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts index 387fb779bd29ea3812331a7951f03b181c5fe659..6c83ee6f8a6b0327c576573d03a8d2bcc93f9e16 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts @@ -10,6 +10,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> +#include <dt-bindings/interrupt-controller/irq.h> #include "gs101-pinctrl.h" #include "gs101.dtsi" @@ -90,6 +91,15 @@ eeprom: eeprom@50 { &hsi2c_12 { status = "okay"; /* TODO: add the devices once drivers exist */ + + fuel-gauge@36 { + compatible = "maxim,max77759-fg"; + reg = <0x36>; + reg-names = "m5"; + shunt-resistor-micro-ohms = <5000>; + interrupt-parent = <&gpa9>; + interrupts = <3 IRQ_TYPE_LEVEL_LOW>; + }; }; &pinctrl_far_alive {