| Message ID | 20250107022432.65390-1-hawkxiang.cpp@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] scsi: iscsi: Fix redundant response for ISCSI_UEVENT_GET_HOST_STATS request | expand |
On 1/6/25 8:24 PM, Xiang Zhang wrote: > The ISCSI_UEVENT_GET_HOST_STATS request is already replied to > iscsid in iscsi_get_host_stats. This fix ensures > that redundant responses are skipped in iscsi_if_rx. > - On success: send reply and stats from iscsi_get_host_stats() > within if_recv_msg(). > - On error: fall through. > > Signed-off-by: Xiang Zhang <hawkxiang.cpp@gmail.com> Thanks for fixing this. Reviewed-by: Mike Christie <michael.christie@oracle.com>
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index fde7de3b1e55..9b47f91c5b97 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -4104,7 +4104,7 @@ iscsi_if_rx(struct sk_buff *skb) } do { /* - * special case for GET_STATS: + * special case for GET_STATS, GET_CHAP and GET_HOST_STATS: * on success - sending reply and stats from * inside of if_recv_msg(), * on error - fall through. @@ -4113,6 +4113,8 @@ iscsi_if_rx(struct sk_buff *skb) break; if (ev->type == ISCSI_UEVENT_GET_CHAP && !err) break; + if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err) + break; err = iscsi_if_send_reply(portid, nlh->nlmsg_type, ev, sizeof(*ev)); if (err == -EAGAIN && --retries < 0) {
The ISCSI_UEVENT_GET_HOST_STATS request is already replied to iscsid in iscsi_get_host_stats. This fix ensures that redundant responses are skipped in iscsi_if_rx. - On success: send reply and stats from iscsi_get_host_stats() within if_recv_msg(). - On error: fall through. Signed-off-by: Xiang Zhang <hawkxiang.cpp@gmail.com> --- V2 -> V3: Update code comments V1 -> V2: Update commit message --- drivers/scsi/scsi_transport_iscsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)