| Message ID | 20250124113352.93638-1-nico.escande@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | wifi: ath12k: fbx: fix ath12k_hal_tx_cmd_ext_desc_setup() info1 override | expand |
On 1/25/2025 12:21 PM, Nicolas Escande wrote:
> So You guys prefer I remove the fixes tag then ?
Yes, please don't add a Fixes: tag if no current upstream functionality is
broken. This may cause the 'stable' team to spend unnecessary time backporting
the change for no reason.
/jeff
On Sun Jan 26, 2025 at 7:16 PM CET, Jeff Johnson wrote: > On 1/25/2025 12:21 PM, Nicolas Escande wrote: >> So You guys prefer I remove the fixes tag then ? > > Yes, please don't add a Fixes: tag if no current upstream functionality is > broken. This may cause the 'stable' team to spend unnecessary time backporting > the change for no reason. > > /jeff Sure, no problem, I'll send an updated v2.
diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c index e0b85f959cd4a..00437736e0322 100644 --- a/drivers/net/wireless/ath/ath12k/dp_tx.c +++ b/drivers/net/wireless/ath/ath12k/dp_tx.c @@ -117,7 +117,7 @@ static void ath12k_hal_tx_cmd_ext_desc_setup(struct ath12k_base *ab, le32_encode_bits(ti->data_len, HAL_TX_MSDU_EXT_INFO1_BUF_LEN); - tcl_ext_cmd->info1 = le32_encode_bits(1, HAL_TX_MSDU_EXT_INFO1_EXTN_OVERRIDE) | + tcl_ext_cmd->info1 |= le32_encode_bits(1, HAL_TX_MSDU_EXT_INFO1_EXTN_OVERRIDE) | le32_encode_bits(ti->encap_type, HAL_TX_MSDU_EXT_INFO1_ENCAP_TYPE) | le32_encode_bits(ti->encrypt_type,
Since inception there is an obvious typo laying around in ath12k_hal_tx_cmd_ext_desc_setup(). Instead of intitializing + adding flags to tcl_ext_cmd->info1, we initialize + override. This is needed to make broadcast frames work with ethernet encapsulation. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1 Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") Signed-off-by: Nicolas Escande <nico.escande@gmail.com> --- drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)