| Message ID | 20250204-exynos7870-pmic-regulators-v1-1-05adad38102c@disroot.org |
|---|---|
| State | New |
| Headers | show |
| Series | Introduce support for Exynos7870's S2MPU05 PMIC and its regulators | expand |
On Tue, Feb 04, 2025 at 02:06:26AM +0530, Kaustabh Chakraborty wrote: > S2MPU05 is a PMIC found in Exynos7870 devices, which controls voltage > regulators (21 LDOs and 5 BUCKs). Provide documentation for devicetree > definitions, regulator naming patterns, etc. > > Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> > --- > .../bindings/regulator/samsung,s2mpu05.yaml | 44 ++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..0a968fe79d44dbcb6720a7d1da698f9460e25521 > --- /dev/null > +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/regulator/samsung,s2mpu05.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S2MPU05 Power Management IC regulators > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> Not me, I don't have this device nor its datasheet. > + > +description: | > + This is a part of device tree bindings for S2M and S5M family of Power > + Management IC (PMIC). > + > + The S2MPU05 provides buck and LDO regulators. > + > + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for > + additional information and example. > + > +patternProperties: > + # 21 LDOs > + "^LDO([1-9]|10|2[0-9]|3[0-5])$": Why is there a gap in LDOs? Best regards, Krzysztof
On 2025-02-05 08:32, Krzysztof Kozlowski wrote: >> + >> +description: | >> + This is a part of device tree bindings for S2M and S5M family of Power >> + Management IC (PMIC). >> + >> + The S2MPU05 provides buck and LDO regulators. >> + >> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for >> + additional information and example. >> + >> +patternProperties: >> + # 21 LDOs >> + "^LDO([1-9]|10|2[0-9]|3[0-5])$": > > Why is there a gap in LDOs? LDOs 11-24 are not implemented in the downstream kernel driver. On further inspection I was able to find the register addresses, but minimum voltage and step values are unknown. :(
On 05/02/2025 21:06, Kaustabh Chakraborty wrote: > On 2025-02-05 08:32, Krzysztof Kozlowski wrote: >>> + >>> +description: | >>> + This is a part of device tree bindings for S2M and S5M family of Power >>> + Management IC (PMIC). >>> + >>> + The S2MPU05 provides buck and LDO regulators. >>> + >>> + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for >>> + additional information and example. >>> + >>> +patternProperties: >>> + # 21 LDOs >>> + "^LDO([1-9]|10|2[0-9]|3[0-5])$": >> >> Why is there a gap in LDOs? > > LDOs 11-24 are not implemented in the downstream kernel driver. On further > inspection I was able to find the register addresses, but minimum voltage > and step values are unknown. :( I see, there are marked for CP. Add a comment that gap in LDOs is due to lack of datasheet and lack of control by OS. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml b/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml new file mode 100644 index 0000000000000000000000000000000000000000..0a968fe79d44dbcb6720a7d1da698f9460e25521 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/samsung,s2mpu05.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/samsung,s2mpu05.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S2MPU05 Power Management IC regulators + +maintainers: + - Krzysztof Kozlowski <krzk@kernel.org> + +description: | + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + The S2MPU05 provides buck and LDO regulators. + + See also Documentation/devicetree/bindings/mfd/samsung,s2mps11.yaml for + additional information and example. + +patternProperties: + # 21 LDOs + "^LDO([1-9]|10|2[0-9]|3[0-5])$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for single LDO regulator. + + required: + - regulator-name + + # 5 bucks + "^BUCK[1-5]$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + description: + Properties for single BUCK regulator. + + required: + - regulator-name + +additionalProperties: false
S2MPU05 is a PMIC found in Exynos7870 devices, which controls voltage regulators (21 LDOs and 5 BUCKs). Provide documentation for devicetree definitions, regulator naming patterns, etc. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- .../bindings/regulator/samsung,s2mpu05.yaml | 44 ++++++++++++++++++++++ 1 file changed, 44 insertions(+)