[v3,10/20] input: ipaq-micro-keys: use devm_kmemdup_array()

Message ID	20250203080902.1864382-11-raag.jadav@intel.com
State	Superseded
Headers	show Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4421C1FC7E6; Mon, 3 Feb 2025 08:09:58 +0000 (UTC) From: Raag Jadav <raag.jadav@intel.com> To: gregkh@linuxfoundation.org, rafael@kernel.org, linus.walleij@linaro.org, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, dmitry.torokhov@gmail.com, lgirdwood@gmail.com, broonie@kernel.org, sre@kernel.org, jic23@kernel.org, przemyslaw.kitszel@intel.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-sound@vger.kernel.org, linux-pm@vger.kernel.org, linux-iio@vger.kernel.org, Raag Jadav <raag.jadav@intel.com> Subject: [PATCH v3 10/20] input: ipaq-micro-keys: use devm_kmemdup_array() Date: Mon, 3 Feb 2025 13:38:52 +0530 Message-Id: <20250203080902.1864382-11-raag.jadav@intel.com> In-Reply-To: <20250203080902.1864382-1-raag.jadav@intel.com> References: <20250203080902.1864382-1-raag.jadav@intel.com> Precedence: bulk MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
Series	Split devres APIs to device/devres.h and introduce devm_kmemdup_array() \| expand [v3,00/20] Split devres APIs to device/devres.h and introduce devm_kmemdup_array() [v3,01/20] driver core: Split devres APIs to device/devres.h [v3,02/20] iio: imu: st_lsm9ds0: Replace device.h with what is needed [v3,03/20] devres: Introduce devm_kmemdup_array() [v3,04/20] pinctrl: intel: copy communities using devm_kmemdup_array() [v3,05/20] pinctrl: baytrail: copy communities using devm_kmemdup_array() [v3,06/20] pinctrl: cherryview: use devm_kmemdup_array() [v3,07/20] pinctrl: tangier: use devm_kmemdup_array() [v3,08/20] pinctrl: pxa2xx: use devm_kmemdup_array() [v3,09/20] input: sparse-keymap: use devm_kmemdup_array() [v3,10/20] input: ipaq-micro-keys: use devm_kmemdup_array() [v3,11/20] regulator: devres: use devm_kmemdup_array() [v3,12/20] regulator: cros-ec: use devm_kmemdup_array() [v3,13/20] power: supply: sc27xx: use devm_kmemdup_array() [v3,14/20] iio: adc: xilinx-xadc-core: use devm_kmemdup_array() [v3,15/20] ASoC: Intel: avs: use devm_kmemdup_array() [v3,16/20] ASoC: hdac_hdmi: use devm_kmemdup_array() [v3,17/20] ASoC: tlv320dac33: use devm_kmemdup_array() [v3,18/20] ASoC: uda1380: use devm_kmemdup_array() [v3,19/20] ASoC: meson: axg-tdm-interface: use devm_kmemdup_array() [v3,20/20] ASoC: uniphier: use devm_kmemdup_array()

Message ID

20250203080902.1864382-11-raag.jadav@intel.com

State

Superseded

Headers

From: Raag Jadav <raag.jadav@intel.com>
To: gregkh@linuxfoundation.org,
	rafael@kernel.org,
	linus.walleij@linaro.org,
	mika.westerberg@linux.intel.com,
	andriy.shevchenko@linux.intel.com,
	dmitry.torokhov@gmail.com,
	lgirdwood@gmail.com,
	broonie@kernel.org,
	sre@kernel.org,
	jic23@kernel.org,
	przemyslaw.kitszel@intel.com
Cc: linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-input@vger.kernel.org,
	linux-sound@vger.kernel.org,
	linux-pm@vger.kernel.org,
	linux-iio@vger.kernel.org,
	Raag Jadav <raag.jadav@intel.com>
Subject: [PATCH v3 10/20] input: ipaq-micro-keys: use devm_kmemdup_array()
Date: Mon,  3 Feb 2025 13:38:52 +0530
Message-Id: <20250203080902.1864382-11-raag.jadav@intel.com>
In-Reply-To: <20250203080902.1864382-1-raag.jadav@intel.com>
References: <20250203080902.1864382-1-raag.jadav@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Series

Split devres APIs to device/devres.h and introduce devm_kmemdup_array() | expand

Convert to use devm_kmemdup_array() which is more robust. Signed-off-by: Raag Jadav <raag.jadav@intel.com> --- drivers/input/keyboard/ipaq-micro-keys.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Linus Walleij Feb. 6, 2025, 6:46 p.m. UTC | #1

On Mon, Feb 3, 2025 at 9:09 AM Raag Jadav <raag.jadav@intel.com> wrote:

> Convert to use devm_kmemdup_array() which is more robust.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

diff --git a/drivers/input/keyboard/ipaq-micro-keys.c b/drivers/input/keyboard/ipaq-micro-keys.c
index 58631bf7ce55..ca7ec054b1ce 100644
--- a/drivers/input/keyboard/ipaq-micro-keys.c
+++ b/drivers/input/keyboard/ipaq-micro-keys.c
@@ -102,9 +102,8 @@  static int micro_key_probe(struct platform_device *pdev)
 
 	keys->input->keycodesize = sizeof(micro_keycodes[0]);
 	keys->input->keycodemax = ARRAY_SIZE(micro_keycodes);
-	keys->codes = devm_kmemdup(&pdev->dev, micro_keycodes,
-			   keys->input->keycodesize * keys->input->keycodemax,
-			   GFP_KERNEL);
+	keys->codes = devm_kmemdup_array(&pdev->dev, micro_keycodes, keys->input->keycodemax,
+					 keys->input->keycodesize, GFP_KERNEL);
 	if (!keys->codes)
 		return -ENOMEM;

[v3,10/20] input: ipaq-micro-keys: use devm_kmemdup_array()

Commit Message

Comments

Patch