| Message ID | 20250206-gpio-set-array-helper-v2-8-1c5f048f79c3@baylibre.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpiolib: add gpiod_multi_set_value_cansleep | expand |
On Thu, 06 Feb 2025 16:48:22 -0600 David Lechner <dlechner@baylibre.com> wrote: > Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of > gpiod_set_array_value(). > > These are not called in an atomic context, so changing to the cansleep > variant is fine. > > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: David Lechner <dlechner@baylibre.com> If this goes through GPIO Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/iio/resolver/ad2s1210.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c > index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193a49f0677c999f 100644 > --- a/drivers/iio/resolver/ad2s1210.c > +++ b/drivers/iio/resolver/ad2s1210.c > @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) > > bitmap[0] = mode; > > - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, > - bitmap); > + return gpiod_multi_set_value_cansleep(gpios, bitmap); > } > > /* > @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) > > bitmap[0] = st->resolution; > > - ret = gpiod_set_array_value(resolution_gpios->ndescs, > - resolution_gpios->desc, > - resolution_gpios->info, > - bitmap); > + ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); > if (ret < 0) > return dev_err_probe(dev, ret, > "failed to set resolution gpios\n"); >
diff --git a/drivers/iio/resolver/ad2s1210.c b/drivers/iio/resolver/ad2s1210.c index b681129a99b6cf399668bf01a1f5a15fbc4f95b8..7f18df790157f1e411fb70de193a49f0677c999f 100644 --- a/drivers/iio/resolver/ad2s1210.c +++ b/drivers/iio/resolver/ad2s1210.c @@ -182,8 +182,7 @@ static int ad2s1210_set_mode(struct ad2s1210_state *st, enum ad2s1210_mode mode) bitmap[0] = mode; - return gpiod_set_array_value(gpios->ndescs, gpios->desc, gpios->info, - bitmap); + return gpiod_multi_set_value_cansleep(gpios, bitmap); } /* @@ -1473,10 +1472,7 @@ static int ad2s1210_setup_gpios(struct ad2s1210_state *st) bitmap[0] = st->resolution; - ret = gpiod_set_array_value(resolution_gpios->ndescs, - resolution_gpios->desc, - resolution_gpios->info, - bitmap); + ret = gpiod_multi_set_value_cansleep(resolution_gpios, bitmap); if (ret < 0) return dev_err_probe(dev, ret, "failed to set resolution gpios\n");