diff mbox series

[v3,2/8] mmc: renesas_sdhi: Arrange local variables in reverse xmas tree order

Message ID 20250206134047.67866-3-biju.das.jz@bp.renesas.com
State New
Headers show
Series Add RZ/G3E SDHI support | expand

Commit Message

Biju Das Feb. 6, 2025, 1:40 p.m. UTC 
Arrange local variables in reverse xmas tree for probe().

Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2->v3:
 * No change.
v1->v2:
 * Collected tags.
---
 drivers/mmc/host/renesas_sdhi_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wolfram Sang Feb. 28, 2025, 9:36 a.m. UTC | #1 
>  	struct tmio_mmc_data *mmd = pdev->dev.platform_data;
> -	struct tmio_mmc_data *mmc_data;
>  	struct renesas_sdhi_dma *dma_priv;
> +	struct tmio_mmc_data *mmc_data;

I'd prefer to have the same types close to each other.
Biju Das Feb. 28, 2025, 10:51 a.m. UTC | #2 
Hi Wolfram,

Thanks for the feedback.

> -----Original Message-----
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Sent: 28 February 2025 09:36
> Subject: Re: [PATCH v3 2/8] mmc: renesas_sdhi: Arrange local variables in reverse xmas tree order
> 
> 
> >  	struct tmio_mmc_data *mmd = pdev->dev.platform_data;
> > -	struct tmio_mmc_data *mmc_data;
> >  	struct renesas_sdhi_dma *dma_priv;
> > +	struct tmio_mmc_data *mmc_data;
> 
> I'd prefer to have the same types close to each other.

OK, will drop this patch.

Cheers,
Biju
diff mbox series

Patch

diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index f73b84bae0c4..6ea651409774 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -910,8 +910,8 @@  int renesas_sdhi_probe(struct platform_device *pdev,
 		       const struct renesas_sdhi_quirks *quirks)
 {
 	struct tmio_mmc_data *mmd = pdev->dev.platform_data;
-	struct tmio_mmc_data *mmc_data;
 	struct renesas_sdhi_dma *dma_priv;
+	struct tmio_mmc_data *mmc_data;
 	struct tmio_mmc_host *host;
 	struct renesas_sdhi *priv;
 	int num_irqs, irq, ret, i;