| Message ID | 20250211104532.699124-1-thorsten.blum@linux.dev |
|---|---|
| State | New |
| Headers | show |
| Series | [RESEND] ACPI: video: Use str_yes_no() helper in acpi_video_bus_add() | expand |
On Tue, Feb 11, 2025 at 11:45 AM Thorsten Blum <thorsten.blum@linux.dev> wrote: > > Remove hard-coded strings by using the str_yes_no() helper function. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > drivers/acpi/acpi_video.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c > index a972831dbd66..efdadc74e3f4 100644 > --- a/drivers/acpi/acpi_video.c > +++ b/drivers/acpi/acpi_video.c > @@ -27,6 +27,7 @@ > #include <linux/acpi.h> > #include <acpi/video.h> > #include <linux/uaccess.h> > +#include <linux/string_choices.h> > > #define ACPI_VIDEO_BUS_NAME "Video Bus" > #define ACPI_VIDEO_DEVICE_NAME "Video Device" > @@ -2039,9 +2040,9 @@ static int acpi_video_bus_add(struct acpi_device *device) > > pr_info("%s [%s] (multi-head: %s rom: %s post: %s)\n", > ACPI_VIDEO_DEVICE_NAME, acpi_device_bid(device), > - video->flags.multihead ? "yes" : "no", > - video->flags.rom ? "yes" : "no", > - video->flags.post ? "yes" : "no"); > + str_yes_no(video->flags.multihead), > + str_yes_no(video->flags.rom), > + str_yes_no(video->flags.post)); > mutex_lock(&video_list_lock); > list_add_tail(&video->entry, &video_bus_head); > mutex_unlock(&video_list_lock); > -- Applied with changelog edits as 6.15 material, thanks!
diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index a972831dbd66..efdadc74e3f4 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -27,6 +27,7 @@ #include <linux/acpi.h> #include <acpi/video.h> #include <linux/uaccess.h> +#include <linux/string_choices.h> #define ACPI_VIDEO_BUS_NAME "Video Bus" #define ACPI_VIDEO_DEVICE_NAME "Video Device" @@ -2039,9 +2040,9 @@ static int acpi_video_bus_add(struct acpi_device *device) pr_info("%s [%s] (multi-head: %s rom: %s post: %s)\n", ACPI_VIDEO_DEVICE_NAME, acpi_device_bid(device), - video->flags.multihead ? "yes" : "no", - video->flags.rom ? "yes" : "no", - video->flags.post ? "yes" : "no"); + str_yes_no(video->flags.multihead), + str_yes_no(video->flags.rom), + str_yes_no(video->flags.post)); mutex_lock(&video_list_lock); list_add_tail(&video->entry, &video_bus_head); mutex_unlock(&video_list_lock);
Remove hard-coded strings by using the str_yes_no() helper function. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- drivers/acpi/acpi_video.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)