| Message ID | 20250219-isp-v1-1-6d3e89b67c31@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/5] dt-bindings: power: apple,pmgr-pwrstate: Add force-{disable,reset} properties | expand |
On Wed, Feb 19, 2025 at 10:43:17AM +0100, Sasha Finkelstein wrote: > On Wed, 19 Feb 2025 at 10:34, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 19/02/2025 10:26, Sasha Finkelstein via B4 Relay wrote: > > > From: Sasha Finkelstein <fnkl.kernel@gmail.com> > > > > > > Add properties to set disable/reset bits when powering down > > > certain domains > > > > > > Please explain why and what problem are you solving. This looks too > > close to SW policy or really arbitrary choice. Background would be useful. > > The ISP block has some weird requirements where some of it's power domains > will not power down correctly without using the "force disable" or "force reset" > pmgr feature. Basically a hardware quirk. Add that to the commit message. Rob
diff --git a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml index 59a6af735a2167b7edd9e0491da238f21effe316..9c8f5385bee5aa1bac8c3e44963713299160521e 100644 --- a/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml +++ b/Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml @@ -62,6 +62,16 @@ properties: Forces this power domain to always be powered up. type: boolean + apple,force-disable: + description: + Use the disable bit when turning the power off + type: boolean + + apple,force-reset: + description: + Use the reset bit when turning the power off + type: boolean + apple,min-state: description: Specifies the minimum power state for auto-PM.