Message ID | 20250227152831.59784-1-brgl@bgdev.pl |
---|---|
State | New |
Headers | show |
Series | gpiolib: remove unneeded WARN_ON() from gpiochip_set_multiple() | expand |
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Thu, 27 Feb 2025 16:28:31 +0100, Bartosz Golaszewski wrote: > GPIO drivers are not required to support set_multiple() - the core will > fallback to calling set() for each line if it's missing. Remove the > offending check from gpiochip_set_multiple(). > > Applied, thanks! [1/1] gpiolib: remove unneeded WARN_ON() from gpiochip_set_multiple() commit: 8014097f1466f7e034844770c537b8dc7d98811f Best regards,
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 1b4af0f97e5a..6cfbc8869cf8 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3608,9 +3608,6 @@ static int gpiochip_set_multiple(struct gpio_chip *gc, lockdep_assert_held(&gc->gpiodev->srcu); - if (WARN_ON(unlikely(!gc->set_multiple && !gc->set_multiple_rv))) - return -EOPNOTSUPP; - if (gc->set_multiple_rv) { ret = gc->set_multiple_rv(gc, mask, bits); if (ret > 0)