| Message ID | 20250313034524.3069690-2-richard.henderson@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | accel/tcg, codebase: Build once patches | expand |
On 13/3/25 04:44, Richard Henderson wrote: > CONFIG_USER_ONLY == !CONFIG_SYSTEM_ONLY. > Therefore it's cleaner to just add to user_ss. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > accel/tcg/meson.build | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On 3/12/25 20:44, Richard Henderson wrote: > CONFIG_USER_ONLY == !CONFIG_SYSTEM_ONLY. > Therefore it's cleaner to just add to user_ss. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > accel/tcg/meson.build | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build > index 38ff227eb0..14bf797fda 100644 > --- a/accel/tcg/meson.build > +++ b/accel/tcg/meson.build > @@ -12,7 +12,6 @@ tcg_specific_ss.add(files( > 'translator.c', > )) > tcg_specific_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user-exec.c')) > -tcg_specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_false: files('user-exec-stub.c')) > if get_option('plugins') > tcg_specific_ss.add(files('plugin-gen.c')) > endif > @@ -22,6 +21,10 @@ specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files( > 'cputlb.c', > )) > > +user_ss.add(when: ['CONFIG_TCG'], if_true: files( > + 'user-exec-stub.c', > +)) > + > system_ss.add(when: ['CONFIG_TCG'], if_true: files( > 'icount-common.c', > 'monitor.c', Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Richard Henderson <richard.henderson@linaro.org> writes: > CONFIG_USER_ONLY == !CONFIG_SYSTEM_ONLY. > Therefore it's cleaner to just add to user_ss. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
diff --git a/accel/tcg/meson.build b/accel/tcg/meson.build index 38ff227eb0..14bf797fda 100644 --- a/accel/tcg/meson.build +++ b/accel/tcg/meson.build @@ -12,7 +12,6 @@ tcg_specific_ss.add(files( 'translator.c', )) tcg_specific_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user-exec.c')) -tcg_specific_ss.add(when: 'CONFIG_SYSTEM_ONLY', if_false: files('user-exec-stub.c')) if get_option('plugins') tcg_specific_ss.add(files('plugin-gen.c')) endif @@ -22,6 +21,10 @@ specific_ss.add(when: ['CONFIG_SYSTEM_ONLY', 'CONFIG_TCG'], if_true: files( 'cputlb.c', )) +user_ss.add(when: ['CONFIG_TCG'], if_true: files( + 'user-exec-stub.c', +)) + system_ss.add(when: ['CONFIG_TCG'], if_true: files( 'icount-common.c', 'monitor.c',
CONFIG_USER_ONLY == !CONFIG_SYSTEM_ONLY. Therefore it's cleaner to just add to user_ss. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- accel/tcg/meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)