| Message ID | 20250313-qpic-snand-memleak-fix-v1-1-e54e78d1da3a@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [next] spi: spi-qpic-snand: avoid memleak in qcom_spi_ecc_init_ctx_pipelined() | expand |
diff --git a/drivers/spi/spi-qpic-snand.c b/drivers/spi/spi-qpic-snand.c index ffb2b6ec685ce3e0b6c56fa38988c5de011445e7..fbba7741a9bf336deed1c07eab8d5a94204878d7 100644 --- a/drivers/spi/spi-qpic-snand.c +++ b/drivers/spi/spi-qpic-snand.c @@ -263,8 +263,10 @@ static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand) return -ENOMEM; snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize, GFP_KERNEL); - if (!snandc->qspi->oob_buf) + if (!snandc->qspi->oob_buf) { + kfree(ecc_cfg); return -ENOMEM; + } memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize);
When the allocation of the OOB buffer fails, the qcom_spi_ecc_init_ctx_pipelined() function returns without freeing the memory allocated for 'ecc_cfg' thus it can cause a memory leak. Call kfree() to free 'ecc_cfg' before returning from the function to avoid that. Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface") Signed-off-by: Gabor Juhos <j4g8y7@gmail.com> --- drivers/spi/spi-qpic-snand.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- base-commit: cce2200dacd6d7e0501c3811f24f5216710968fb change-id: 20250313-qpic-snand-memleak-fix-4f1e4a641c69 Best regards,