| Message ID | 1481273736-102485-1-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Accepted |
| Commit | f289416c64b3225b7733eedb305d98c8be068d90 |
| Headers | show |
Hi Leif, Could you help to review this patch, just update uefi version to 16.12. Code also could be found in rp-16.12-04-all branch. Thanks and Regards, Heyi 在 12/9/2016 4:55 PM, Heyi Guo 写道: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > Platforms/Hisilicon/D03/D03.dsc | 2 +- > Platforms/Hisilicon/D05/D05.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc > index b6ce299..4c90326 100644 > --- a/Platforms/Hisilicon/D03/D03.dsc > +++ b/Platforms/Hisilicon/D03/D03.dsc > @@ -182,7 +182,7 @@ > gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.08 RC1" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release" > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > > diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc > index 1f5e084..5645b15 100644 > --- a/Platforms/Hisilicon/D05/D05.dsc > +++ b/Platforms/Hisilicon/D05/D05.dsc > @@ -195,7 +195,7 @@ > > gHisiTokenSpaceGuid.PcdIsMPBoot|1 > gHisiTokenSpaceGuid.PcdSocketMask|0x3 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.08 RC1" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release" > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >
On 9 December 2016 at 09:01, Heyi Guo <heyi.guo@linaro.org> wrote: > Hi Leif, > > Could you help to review this patch, just update uefi version to 16.12. > I'm not convinced you want to have version numbers in the code. It seems like an overhead for the maintainer, as well as yourself. I just use the GIT SHA, which uefi-build.sh generates automatically and outputs on the terminal at boot. But you can add the environment variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify something else, eg. "16.12-<commit id>". > Code also could be found in rp-16.12-04-all branch. > > > Thanks and Regards, > > Heyi > > > > 在 12/9/2016 4:55 PM, Heyi Guo 写道: >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >> --- >> Platforms/Hisilicon/D03/D03.dsc | 2 +- >> Platforms/Hisilicon/D05/D05.dsc | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Platforms/Hisilicon/D03/D03.dsc >> b/Platforms/Hisilicon/D03/D03.dsc >> index b6ce299..4c90326 100644 >> --- a/Platforms/Hisilicon/D03/D03.dsc >> +++ b/Platforms/Hisilicon/D03/D03.dsc >> @@ -182,7 +182,7 @@ >> gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon >> D03 UEFI 16.08 RC1" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 >> UEFI 16.12 Release" >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> diff --git a/Platforms/Hisilicon/D05/D05.dsc >> b/Platforms/Hisilicon/D05/D05.dsc >> index 1f5e084..5645b15 100644 >> --- a/Platforms/Hisilicon/D05/D05.dsc >> +++ b/Platforms/Hisilicon/D05/D05.dsc >> @@ -195,7 +195,7 @@ >> gHisiTokenSpaceGuid.PcdIsMPBoot|1 >> gHisiTokenSpaceGuid.PcdSocketMask|0x3 >> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >> UEFI 16.08 RC1" >> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >> UEFI 16.12 Release" >> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >> > > > _______________________________________________ > Linaro-uefi mailing list > Linaro-uefi@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-uefi
I have no objection to this, but should you not bump D02 too? Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> Pushed as f289416. On Fri, Dec 09, 2016 at 04:55:36PM +0800, Heyi Guo wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > --- > Platforms/Hisilicon/D03/D03.dsc | 2 +- > Platforms/Hisilicon/D05/D05.dsc | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc > index b6ce299..4c90326 100644 > --- a/Platforms/Hisilicon/D03/D03.dsc > +++ b/Platforms/Hisilicon/D03/D03.dsc > @@ -182,7 +182,7 @@ > gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 > > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.08 RC1" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release" > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > > diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc > index 1f5e084..5645b15 100644 > --- a/Platforms/Hisilicon/D05/D05.dsc > +++ b/Platforms/Hisilicon/D05/D05.dsc > @@ -195,7 +195,7 @@ > > gHisiTokenSpaceGuid.PcdIsMPBoot|1 > gHisiTokenSpaceGuid.PcdSocketMask|0x3 > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.08 RC1" > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release" > > gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > > -- > 1.9.1 >
Hi Ryan, 在 12/9/2016 5:14 PM, Ryan Harkin 写道: > On 9 December 2016 at 09:01, Heyi Guo <heyi.guo@linaro.org> wrote: >> Hi Leif, >> >> Could you help to review this patch, just update uefi version to 16.12. >> > I'm not convinced you want to have version numbers in the code. It > seems like an overhead for the maintainer, as well as yourself. > > I just use the GIT SHA, which uefi-build.sh generates automatically > and outputs on the terminal at boot. But you can add the environment > variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify > something else, eg. "16.12-<commit id>". Thanks for your opinion. But this pcd is used by SMBIOS too. And anybody who build the code have to specify a version then, maybe they lost the commit id, and the version maybe different every one, so we don't know the codebase if there have issue. Thanks and Regards, Heyi > >> Code also could be found in rp-16.12-04-all branch. >> >> >> Thanks and Regards, >> >> Heyi >> >> >> >> 在 12/9/2016 4:55 PM, Heyi Guo 写道: >>> Contributed-under: TianoCore Contribution Agreement 1.0 >>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >>> --- >>> Platforms/Hisilicon/D03/D03.dsc | 2 +- >>> Platforms/Hisilicon/D05/D05.dsc | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/Platforms/Hisilicon/D03/D03.dsc >>> b/Platforms/Hisilicon/D03/D03.dsc >>> index b6ce299..4c90326 100644 >>> --- a/Platforms/Hisilicon/D03/D03.dsc >>> +++ b/Platforms/Hisilicon/D03/D03.dsc >>> @@ -182,7 +182,7 @@ >>> gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 >>> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon >>> D03 UEFI 16.08 RC1" >>> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 >>> UEFI 16.12 Release" >>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >>> diff --git a/Platforms/Hisilicon/D05/D05.dsc >>> b/Platforms/Hisilicon/D05/D05.dsc >>> index 1f5e084..5645b15 100644 >>> --- a/Platforms/Hisilicon/D05/D05.dsc >>> +++ b/Platforms/Hisilicon/D05/D05.dsc >>> @@ -195,7 +195,7 @@ >>> gHisiTokenSpaceGuid.PcdIsMPBoot|1 >>> gHisiTokenSpaceGuid.PcdSocketMask|0x3 >>> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >>> UEFI 16.08 RC1" >>> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >>> UEFI 16.12 Release" >>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >>> >> >> _______________________________________________ >> Linaro-uefi mailing list >> Linaro-uefi@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/linaro-uefi
Hi Heyi, On Fri, Dec 09, 2016 at 06:55:04PM +0800, Heyi Guo wrote: > >On 9 December 2016 at 09:01, Heyi Guo <heyi.guo@linaro.org> wrote: > >>Could you help to review this patch, just update uefi version to 16.12. > > > >I'm not convinced you want to have version numbers in the code. It > >seems like an overhead for the maintainer, as well as yourself. > > > >I just use the GIT SHA, which uefi-build.sh generates automatically > >and outputs on the terminal at boot. But you can add the environment > >variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify > >something else, eg. "16.12-<commit id>". > > Thanks for your opinion. > But this pcd is used by SMBIOS too. And anybody who build the code have to > specify a version then, maybe they lost the commit id, and the > version maybe different every one, so we don't know the codebase if > there have issue. That is already the case, though. This value is going to stay in the codebase post release, making it look like any future builds are based on this. I agree with Ryan on this point, but pushed the patch anyway since we're just about to release and I don't want to start messing with the build. Ryan already added support to uefi-build.sh to add git commit hash (which is much more reliable) automatically on build if FIRMWARE_VER is not specified. I recommend we move the Hisilicon platforms over to using this mechanism after the release. Regards, Leif > Thanks and Regards, > Heyi > > > > >>Code also could be found in rp-16.12-04-all branch. > >> > >> > >>Thanks and Regards, > >> > >>Heyi > >> > >> > >> > >>在 12/9/2016 4:55 PM, Heyi Guo 写道: > >>>Contributed-under: TianoCore Contribution Agreement 1.0 > >>>Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > >>>--- > >>> Platforms/Hisilicon/D03/D03.dsc | 2 +- > >>> Platforms/Hisilicon/D05/D05.dsc | 2 +- > >>> 2 files changed, 2 insertions(+), 2 deletions(-) > >>> > >>>diff --git a/Platforms/Hisilicon/D03/D03.dsc > >>>b/Platforms/Hisilicon/D03/D03.dsc > >>>index b6ce299..4c90326 100644 > >>>--- a/Platforms/Hisilicon/D03/D03.dsc > >>>+++ b/Platforms/Hisilicon/D03/D03.dsc > >>>@@ -182,7 +182,7 @@ > >>> gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 > >>> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon > >>>D03 UEFI 16.08 RC1" > >>>+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 > >>>UEFI 16.12 Release" > >>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > >>> diff --git a/Platforms/Hisilicon/D05/D05.dsc > >>>b/Platforms/Hisilicon/D05/D05.dsc > >>>index 1f5e084..5645b15 100644 > >>>--- a/Platforms/Hisilicon/D05/D05.dsc > >>>+++ b/Platforms/Hisilicon/D05/D05.dsc > >>>@@ -195,7 +195,7 @@ > >>> gHisiTokenSpaceGuid.PcdIsMPBoot|1 > >>> gHisiTokenSpaceGuid.PcdSocketMask|0x3 > >>>- gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 > >>>UEFI 16.08 RC1" > >>>+ gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 > >>>UEFI 16.12 Release" > >>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" > >>> > >> > >>_______________________________________________ > >>Linaro-uefi mailing list > >>Linaro-uefi@lists.linaro.org > >>https://lists.linaro.org/mailman/listinfo/linaro-uefi > > _______________________________________________ > Linaro-uefi mailing list > Linaro-uefi@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/linaro-uefi
Hi Leif, 在 12/9/2016 9:33 PM, Leif Lindholm 写道: > Hi Heyi, > > On Fri, Dec 09, 2016 at 06:55:04PM +0800, Heyi Guo wrote: >>> On 9 December 2016 at 09:01, Heyi Guo <heyi.guo@linaro.org> wrote: >>>> Could you help to review this patch, just update uefi version to 16.12. >>> I'm not convinced you want to have version numbers in the code. It >>> seems like an overhead for the maintainer, as well as yourself. >>> >>> I just use the GIT SHA, which uefi-build.sh generates automatically >>> and outputs on the terminal at boot. But you can add the environment >>> variable FIRMWARE_VER to EXTRA_OPTIONS at build time to specify >>> something else, eg. "16.12-<commit id>". >> Thanks for your opinion. >> But this pcd is used by SMBIOS too. And anybody who build the code have to >> specify a version then, maybe they lost the commit id, and the >> version maybe different every one, so we don't know the codebase if >> there have issue. > That is already the case, though. > This value is going to stay in the codebase post release, making it > look like any future builds are based on this. > > I agree with Ryan on this point, but pushed the patch anyway since > we're just about to release and I don't want to start messing with the > build. > > Ryan already added support to uefi-build.sh to add git commit hash > (which is much more reliable) automatically on build if FIRMWARE_VER > is not specified. > > I recommend we move the Hisilicon platforms over to using this > mechanism after the release. Got it and agree this, thanks Leif and Ryan, I will try it. Thanks and Regards, Heyi > Regards, > > Leif > >> Thanks and Regards, >> Heyi >> >>>> Code also could be found in rp-16.12-04-all branch. >>>> >>>> >>>> Thanks and Regards, >>>> >>>> Heyi >>>> >>>> >>>> >>>> 在 12/9/2016 4:55 PM, Heyi Guo 写道: >>>>> Contributed-under: TianoCore Contribution Agreement 1.0 >>>>> Signed-off-by: Heyi Guo <heyi.guo@linaro.org> >>>>> --- >>>>> Platforms/Hisilicon/D03/D03.dsc | 2 +- >>>>> Platforms/Hisilicon/D05/D05.dsc | 2 +- >>>>> 2 files changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/Platforms/Hisilicon/D03/D03.dsc >>>>> b/Platforms/Hisilicon/D03/D03.dsc >>>>> index b6ce299..4c90326 100644 >>>>> --- a/Platforms/Hisilicon/D03/D03.dsc >>>>> +++ b/Platforms/Hisilicon/D03/D03.dsc >>>>> @@ -182,7 +182,7 @@ >>>>> gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 >>>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon >>>>> D03 UEFI 16.08 RC1" >>>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 >>>>> UEFI 16.12 Release" >>>>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >>>>> diff --git a/Platforms/Hisilicon/D05/D05.dsc >>>>> b/Platforms/Hisilicon/D05/D05.dsc >>>>> index 1f5e084..5645b15 100644 >>>>> --- a/Platforms/Hisilicon/D05/D05.dsc >>>>> +++ b/Platforms/Hisilicon/D05/D05.dsc >>>>> @@ -195,7 +195,7 @@ >>>>> gHisiTokenSpaceGuid.PcdIsMPBoot|1 >>>>> gHisiTokenSpaceGuid.PcdSocketMask|0x3 >>>>> - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >>>>> UEFI 16.08 RC1" >>>>> + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 >>>>> UEFI 16.12 Release" >>>>> gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" >>>>> >>>> _______________________________________________ >>>> Linaro-uefi mailing list >>>> Linaro-uefi@lists.linaro.org >>>> https://lists.linaro.org/mailman/listinfo/linaro-uefi >> _______________________________________________ >> Linaro-uefi mailing list >> Linaro-uefi@lists.linaro.org >> https://lists.linaro.org/mailman/listinfo/linaro-uefi
diff --git a/Platforms/Hisilicon/D03/D03.dsc b/Platforms/Hisilicon/D03/D03.dsc index b6ce299..4c90326 100644 --- a/Platforms/Hisilicon/D03/D03.dsc +++ b/Platforms/Hisilicon/D03/D03.dsc @@ -182,7 +182,7 @@ gHisiTokenSpaceGuid.PcdAlgSmmuBaseAddress|0xd0040000 - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.08 RC1" + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D03 UEFI 16.12 Release" gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18" diff --git a/Platforms/Hisilicon/D05/D05.dsc b/Platforms/Hisilicon/D05/D05.dsc index 1f5e084..5645b15 100644 --- a/Platforms/Hisilicon/D05/D05.dsc +++ b/Platforms/Hisilicon/D05/D05.dsc @@ -195,7 +195,7 @@ gHisiTokenSpaceGuid.PcdIsMPBoot|1 gHisiTokenSpaceGuid.PcdSocketMask|0x3 - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.08 RC1" + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"Hisilicon D05 UEFI 16.12 Release" gHisiTokenSpaceGuid.PcdBiosVersionString|L"10.01.01T18"
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Heyi Guo <heyi.guo@linaro.org> --- Platforms/Hisilicon/D03/D03.dsc | 2 +- Platforms/Hisilicon/D05/D05.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)