| Message ID | 20250320113521.3966762-1-andi.shyti@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: k1: Initialize variable before use | expand |
On 3/20/25 6:35 AM, Andi Shyti wrote: > Commit 95a8ca229032 ("i2c: spacemit: add support for SpacemiT K1 > SoC") introduced a check in the probe function to warn the user > if the DTS has incorrect frequency settings. In such cases, the > driver falls back to default values. > > However, the return value of of_property_read_u32() was not > stored, making the check ineffective. Fix this by storing the > return value in 'ret' and evaluating it properly. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202503200928.eBWfwnHG-lkp@intel.com/ > Signed-off-by: Andi Shyti <andi.shyti@kernel.org> > Cc: Troy Mitchell <troymitchell988@gmail.com> This landed in my junk folder for some reason. I noticed this on an earlier version but didn't check in v8. The fix looks good (in case you haven't already applied it). Reviewed-by: Alex Elder <elder@riscstar.com> > --- > Cc: Alex Elder <elder@riscstar.com> > > drivers/i2c/busses/i2c-k1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c > index 0d8763b852db..5965b4cf6220 100644 > --- a/drivers/i2c/busses/i2c-k1.c > +++ b/drivers/i2c/busses/i2c-k1.c > @@ -514,7 +514,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev) > if (!i2c) > return -ENOMEM; > > - of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); > + ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); > if (ret && ret != -EINVAL) > dev_warn(dev, "failed to read clock-frequency property: %d\n", ret); >
diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c index 0d8763b852db..5965b4cf6220 100644 --- a/drivers/i2c/busses/i2c-k1.c +++ b/drivers/i2c/busses/i2c-k1.c @@ -514,7 +514,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev) if (!i2c) return -ENOMEM; - of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); + ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); if (ret && ret != -EINVAL) dev_warn(dev, "failed to read clock-frequency property: %d\n", ret);
Commit 95a8ca229032 ("i2c: spacemit: add support for SpacemiT K1 SoC") introduced a check in the probe function to warn the user if the DTS has incorrect frequency settings. In such cases, the driver falls back to default values. However, the return value of of_property_read_u32() was not stored, making the check ineffective. Fix this by storing the return value in 'ret' and evaluating it properly. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202503200928.eBWfwnHG-lkp@intel.com/ Signed-off-by: Andi Shyti <andi.shyti@kernel.org> Cc: Troy Mitchell <troymitchell988@gmail.com> --- Cc: Alex Elder <elder@riscstar.com> drivers/i2c/busses/i2c-k1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)