| Message ID | 20250324080303.408084-1-nichen@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: rtw88: usb: Remove redundant 'flush_workqueue()' calls | expand |
Chen Ni <nichen@iscas.ac.cn> wrote: > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 625fbc16524a wifi: rtw88: usb: Remove redundant 'flush_workqueue()' calls --- https://github.com/pkshih/rtw.git
diff --git a/drivers/net/wireless/realtek/rtw88/usb.c b/drivers/net/wireless/realtek/rtw88/usb.c index c8092fa0d9f1..667473b7a9f5 100644 --- a/drivers/net/wireless/realtek/rtw88/usb.c +++ b/drivers/net/wireless/realtek/rtw88/usb.c @@ -948,7 +948,6 @@ static void rtw_usb_deinit_rx(struct rtw_dev *rtwdev) skb_queue_purge(&rtwusb->rx_queue); - flush_workqueue(rtwusb->rxwq); destroy_workqueue(rtwusb->rxwq); skb_queue_purge(&rtwusb->rx_free_queue); @@ -977,7 +976,6 @@ static void rtw_usb_deinit_tx(struct rtw_dev *rtwdev) { struct rtw_usb *rtwusb = rtw_get_usb_priv(rtwdev); - flush_workqueue(rtwusb->txwq); destroy_workqueue(rtwusb->txwq); rtw_usb_tx_queue_purge(rtwusb); }
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/net/wireless/realtek/rtw88/usb.c | 2 -- 1 file changed, 2 deletions(-)