| Message ID | 20250328-s2mpg10-v2-3-b54dee33fb6b@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Samsung S2MPG10 PMIC MFD-based drivers | expand |
On Fri, Mar 28, 2025 at 01:28:49PM +0000, André Draszik wrote: > The PMIC is supposed to be a child of ACPM, add it here to describe the > connection. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > .../bindings/firmware/google,gs101-acpm-ipc.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > index 2cdad1bbae73bb1795eccf47e1a58e270acd022c..5524f2af5bda2d29b5113f8fe14ece7f02366a60 100644 > --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > @@ -27,6 +27,16 @@ properties: > mboxes: > maxItems: 1 > > + pmic: > + description: Child node describing the main PMIC. > + type: object > + $ref: /schemas/mfd/samsung,s2mps11.yaml > + unevaluatedProperties: false Drop these two and use "additionalProperties: true". > + > + properties: > + compatible: > + const: samsung,s2mpg10-pmic Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml index 2cdad1bbae73bb1795eccf47e1a58e270acd022c..5524f2af5bda2d29b5113f8fe14ece7f02366a60 100644 --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml @@ -27,6 +27,16 @@ properties: mboxes: maxItems: 1 + pmic: + description: Child node describing the main PMIC. + type: object + $ref: /schemas/mfd/samsung,s2mps11.yaml + unevaluatedProperties: false + + properties: + compatible: + const: samsung,s2mpg10-pmic + shmem: description: List of phandle pointing to the shared memory (SHM) area. The memory @@ -43,8 +53,15 @@ additionalProperties: false examples: - | + #include <dt-bindings/interrupt-controller/irq.h> + power-management { compatible = "google,gs101-acpm-ipc"; mboxes = <&ap2apm_mailbox>; shmem = <&apm_sram>; + + pmic { + compatible = "samsung,s2mpg10-pmic"; + interrupts-extended = <&gpa0 6 IRQ_TYPE_LEVEL_LOW>; + }; };
The PMIC is supposed to be a child of ACPM, add it here to describe the connection. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- .../bindings/firmware/google,gs101-acpm-ipc.yaml | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)