| Message ID | 20250331204442.1727618-1-superm1@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | ACPI: EC: Set ec_no_wakeup for Lenovo Go S | expand |
On 4/2/2025 3:37 PM, Antheas Kapenekakis wrote: >> Maybe I'm failing at my search-engine-foo, could you point me at some >> docs about this AC/DC burst stuff? > > AC/DC Burst/AC/DC Burst Suppresed are the events in Sleep Study > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-sleepstudy > > You can see those when running a sleep study and unplugging a > connector. I think suppressed is unplugging > > Then here is the description for plugging in a charger > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-1 > >> The Windows power manager will turn on the display when the battery subsystem has indicated >> AC power has been connected. The GPIO interrupt for power source changes must cause the >> ACPI _PSR method under the power supply device to be executed. The power subsystem must >> wake the SoC any time the power source changes, including when the system is attached or >> removed from a dock that has a battery or AC power source. After AC power is connected, >> the display will remain on for five seconds, unless there is input to the system during this five-second window. > > And here for unplugging: > https://learn.microsoft.com/en-us/windows-hardware/design/device-experiences/modern-standby-wake-sources#environmental-context-changes-2 > >> The GPIO interrupt for power source changes must cause the ACPI _PSR method under >> the power supply device to be executed. The power subsystem must wake the SoC any time >> the power source changes, including when the system is attached or removed from a dock >> that has a battery or AC power source. I suppose this could actually just be another way to say that there is a flurry of EC activity as a result of the ACPI SCI and they characterize that activity as a "burst" associated with unplug or plug. It would be good to find actual documentation though instead of guessing. > > I guess from the description it is not clear that the device stays on > for 5 seconds when unplugging, but from empirical testing I want to > say it does. It has been a while. I left 3 devices like an hour ago on > Windows and none of them managed to sleep, so I cannot verify this at > the moment though. > During "display off" there is other activity that goes on until reaching resiliency on Microsoft side. So it's not really cut and dry periods of time. If I was to hypothesize when the screen off wakeup occurs the OS looks at the amount of time that has passed and if there was any scheduled tasks for the next wakeup gets them done before going back down.
diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c index 8db09d81918fb..3c5f34892734e 100644 --- a/drivers/acpi/ec.c +++ b/drivers/acpi/ec.c @@ -2301,6 +2301,34 @@ static const struct dmi_system_id acpi_ec_no_wakeup[] = { DMI_MATCH(DMI_PRODUCT_FAMILY, "103C_5336AN HP ZHAN 66 Pro"), }, }, + /* + * Lenovo Legion Go S; touchscreen blocks HW sleep when woken up from EC + * https://gitlab.freedesktop.org/drm/amd/-/issues/3929 + */ + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83L3"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83N6"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83Q2"), + } + }, + { + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"), + DMI_MATCH(DMI_PRODUCT_NAME, "83Q3"), + } + }, { }, };