| Message ID | 20250403150223.4136-1-neeraj.sanjaykale@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] Bluetooth: btnxpuart: Add an error message if FW dump trigger fails | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=949648 ---Test result--- Test Summary: CheckPatch PENDING 0.37 seconds GitLint PENDING 0.31 seconds SubjectPrefix PASS 0.28 seconds BuildKernel PASS 24.10 seconds CheckAllWarning PASS 26.56 seconds CheckSparse PASS 30.02 seconds BuildKernel32 PASS 23.80 seconds TestRunnerSetup PASS 426.29 seconds TestRunner_l2cap-tester PASS 20.77 seconds TestRunner_iso-tester PASS 33.05 seconds TestRunner_bnep-tester PASS 4.60 seconds TestRunner_mgmt-tester PASS 121.22 seconds TestRunner_rfcomm-tester PASS 7.78 seconds TestRunner_sco-tester PASS 12.35 seconds TestRunner_ioctl-tester PASS 8.16 seconds TestRunner_mesh-tester PASS 5.88 seconds TestRunner_smp-tester PASS 7.12 seconds TestRunner_userchan-tester PASS 4.88 seconds IncrementalBuild PENDING 0.90 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 5091dea762a0..96dd098cee98 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -1286,7 +1286,9 @@ static void nxp_coredump(struct hci_dev *hdev) u8 pcmd = 2; skb = nxp_drv_send_cmd(hdev, HCI_NXP_TRIGGER_DUMP, 1, &pcmd); - if (!IS_ERR(skb)) + if (IS_ERR(skb)) + bt_dev_err(hdev, "Failed to trigger FW Dump. (%ld)", PTR_ERR(skb)); + else kfree_skb(skb); }
This prints an error message if the FW Dump trigger command fails. This scenario is mainly observed in legacy chipsets 8987 and 8997 and also IW416, where this feature is unavailable due to memory constraints. Fixes: 998e447f443f ("Bluetooth: btnxpuart: Add support for HCI coredump feature") Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- v2: Create this as a separate patch. (Neeraj) --- drivers/bluetooth/btnxpuart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)