| Message ID | 20250407-gpiochip-set-rv-i2c-mux-v1-1-7330a0f4df1a@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | i2c: mux: ltc4306: use new GPIO line value setter callbacks | expand |
On Mon, Apr 7, 2025 at 10:08 AM Peter Rosin <peda@axentia.se> wrote: > > Hi! > > 2025-04-07 at 09:17, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > struct gpio_chip now has callbacks for setting line values that return > > an integer, allowing to indicate failures. Convert the driver to using > > them. > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > --- > > Peter: I know you've not been very active recently. If you prefer to > > just Ack it and let me take it through the GPIO tree, please do. > > What normally happens is that I just Ack trivial things like this, and > then either Wolfram or Andi picks it. The risk of future conflicts in > this area (and cycle) should be low, so I don't think it really matters > if you pick it, but Wolfram/Andi should have first dibs, since it makes > for slightly neater PRs during the merge window. > > Acked-by: Peter Rosin <peda@axentia.se> > I just realized their emails didn't pop up in b4 --auto-to-cc. Cc'ed now. Wolfram, Andi: do you want to pick it up or should I take it via the GPIO tree? Bartosz
> I just realized their emails didn't pop up in b4 --auto-to-cc. Cc'ed > now. Wolfram, Andi: do you want to pick it up or should I take it via > the GPIO tree? If there is no dependency in your tree, then I prefer to pick it myself.
On Thu, Apr 24, 2025 at 10:10 AM Wolfram Sang <wsa@the-dreams.de> wrote: > > > > I just realized their emails didn't pop up in b4 --auto-to-cc. Cc'ed > > now. Wolfram, Andi: do you want to pick it up or should I take it via > > the GPIO tree? > > If there is no dependency in your tree, then I prefer to pick it myself. > No, everything's upstream. Bartosz
On Thu, Apr 24, 2025 at 09:16:48AM +0200, Bartosz Golaszewski wrote: > On Mon, Apr 7, 2025 at 10:08 AM Peter Rosin <peda@axentia.se> wrote: > > > > Hi! > > > > 2025-04-07 at 09:17, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > struct gpio_chip now has callbacks for setting line values that return > > > an integer, allowing to indicate failures. Convert the driver to using > > > them. > > > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Applied to for-next, thanks!
diff --git a/drivers/i2c/muxes/i2c-mux-ltc4306.c b/drivers/i2c/muxes/i2c-mux-ltc4306.c index 8a87f19bf5d5..c688af270a11 100644 --- a/drivers/i2c/muxes/i2c-mux-ltc4306.c +++ b/drivers/i2c/muxes/i2c-mux-ltc4306.c @@ -85,13 +85,13 @@ static int ltc4306_gpio_get(struct gpio_chip *chip, unsigned int offset) return !!(val & BIT(1 - offset)); } -static void ltc4306_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int ltc4306_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct ltc4306 *data = gpiochip_get_data(chip); - regmap_update_bits(data->regmap, LTC_REG_CONFIG, BIT(5 - offset), - value ? BIT(5 - offset) : 0); + return regmap_update_bits(data->regmap, LTC_REG_CONFIG, + BIT(5 - offset), value ? BIT(5 - offset) : 0); } static int ltc4306_gpio_get_direction(struct gpio_chip *chip, @@ -164,7 +164,7 @@ static int ltc4306_gpio_init(struct ltc4306 *data) data->gpiochip.direction_input = ltc4306_gpio_direction_input; data->gpiochip.direction_output = ltc4306_gpio_direction_output; data->gpiochip.get = ltc4306_gpio_get; - data->gpiochip.set = ltc4306_gpio_set; + data->gpiochip.set_rv = ltc4306_gpio_set; data->gpiochip.set_config = ltc4306_gpio_set_config; data->gpiochip.owner = THIS_MODULE;