| Message ID | 20250408-iris-dec-hevc-vp9-v1-9-acd258778bd6@quicinc.com |
|---|---|
| State | New |
| Headers | show
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0127922DFA4;
Tue, 8 Apr 2025 15:55:30 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=205.220.168.131
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1744127732; cv=none;
b=jLpENQanMgeY6ghpUVtbKDOGAxwVIpKxdshFkqOqEG3jKrTwgqFvTPurqykZL/3JmHq3qcjvHd88IQsuo7VrJfPlm9p6Ix09FjBvP+fAujIey3BN2jWd+pwfC+X9IKT//9POvaG0/Lqd2I6vvoX6aXOVpPZ+PXrS7JkE7/eCUDY=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1744127732; c=relaxed/simple;
bh=9cgfIJPo13nVcJSIDHHqC8F3QDl6D0/+VyXTs6soU+w=;
h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References:
In-Reply-To:To:CC;
b=nzeWGrLWdNY4v2a/emRlfSI75QCWWUEEmcCqJ/9eDaRQrHBN/lMB6MWc6D6vcTq3ADt8JUSlGXRifJX3NgSsJfWYeI//HMZv8aypSPTmXP9WHNH2aS1eqMt4qEzpXA5uAk8gddo6cx6HBGm5x9s0x1Sw0eVMLkXRq70vVmgBbGY=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=quicinc.com;
spf=pass smtp.mailfrom=quicinc.com;
dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com
header.b=gdX61hAO; arc=none smtp.client-ip=205.220.168.131
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=quicinc.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=quicinc.com
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com
header.b="gdX61hAO"
Received: from pps.filterd (m0279866.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id
538BDdNH008070;
Tue, 8 Apr 2025 15:55:28 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to; s=qcppdkim1; bh=
jNVy6x5tCC2ATkH3o5b/ImkuBnPR3ltvMGsn9NYEp28=; b=gdX61hAOUUHC0htU
GnHZHiFkWHL/UQI/DtytXyfGq2YQP+8GC3zFU98hXkhENS7L/ei1ccWdf4Bm1gk8
pRx65Z+X5DWeNL3T2UAE+7qur07kDUrLLL/yqkZ6YG9fGNzX1a/pvae+LrB1sRag
NucA8GhBz0nLlfj2mK04i6R1P8U2sHMm+OXucW8eu3+e/P9ozEh8Ggz6LT69j/ZJ
QPC4MRyEoyMVc9VLJ3e6VMMFv7weD+bneOJnpCmHAqaK2DF2KBCmhwqlcsUZzXEW
LCebG94JCKlU5i5y+96tlky5zj2dxodhR3Zz32J6DmXSFMvpl490PTb3CoA151md
7MjqbA==
Received: from nalasppmta01.qualcomm.com (Global_NAT1.qualcomm.com
[129.46.96.20])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twtb0cjm-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Tue, 08 Apr 2025 15:55:27 +0000 (GMT)
Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com
[10.47.209.196])
by NALASPPMTA01.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id
538FtRR0002715
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Tue, 8 Apr 2025 15:55:27 GMT
Received: from hu-dikshita-hyd.qualcomm.com (10.80.80.8) by
nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1544.9; Tue, 8 Apr 2025 08:55:21 -0700
From: Dikshita Agarwal <quic_dikshita@quicinc.com>
Date: Tue, 8 Apr 2025 21:24:23 +0530
Subject: [PATCH 09/20] media: iris: Prevent HFI queue writes when core is
in deinit state
Precedence: bulk
X-Mailing-List: linux-media@vger.kernel.org
List-Id: <linux-media.vger.kernel.org>
List-Subscribe: <mailto:linux-media+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-media+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-ID: <20250408-iris-dec-hevc-vp9-v1-9-acd258778bd6@quicinc.com>
References: <20250408-iris-dec-hevc-vp9-v1-0-acd258778bd6@quicinc.com>
In-Reply-To: <20250408-iris-dec-hevc-vp9-v1-0-acd258778bd6@quicinc.com>
To: Vikash Garodia <quic_vgarodia@quicinc.com>,
Abhinav Kumar
<quic_abhinavk@quicinc.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Stefan Schmidt <stefan.schmidt@linaro.org>,
Hans Verkuil
<hverkuil@xs4all.nl>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio
<konradybcio@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski
<krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
CC: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov
<dmitry.baryshkov@linaro.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
<linux-media@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
"Dikshita
Agarwal" <quic_dikshita@quicinc.com>,
<stable@vger.kernel.org>
X-Mailer: b4 0.14.1
X-Developer-Signature: v=1; a=ed25519-sha256; t=1744127674; l=1349;
i=quic_dikshita@quicinc.com; s=20240917; h=from:subject:message-id;
bh=9cgfIJPo13nVcJSIDHHqC8F3QDl6D0/+VyXTs6soU+w=;
b=tw44yHZlh+UnH2AnhahfnA3TqVOY277ctF64q4Ra6StuELpCJm2jhzc3cPEJOwntola8FvYfT
BAUM8avk/taC2xEJXtfo+Oafs3c3TGiTwwMGRjL+83fAKfyaKn4sm7D
X-Developer-Key: i=quic_dikshita@quicinc.com; a=ed25519;
pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM=
X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To
nalasex01a.na.qualcomm.com (10.47.209.196)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: aXt8FkzZ_gA3pY1waBHLSUoO-qr4Xx2r
X-Authority-Analysis: v=2.4 cv=LLlmQIW9 c=1 sm=1 tr=0 ts=67f546ef cx=c_pps
a=ouPCqIW2jiPt+lZRy3xVPw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17
a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VwQbUJbxAAAA:8
a=COk6AnOGAAAA:8 a=TuTThgpRNTc_Uxy4z7QA:9
a=QEXdDO2ut3YA:10 a=TjNXssC_j7lpFel5tvFf:22
X-Proofpoint-ORIG-GUID: aXt8FkzZ_gA3pY1waBHLSUoO-qr4Xx2r
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34
definitions=2025-04-08_06,2025-04-08_03,2024-11-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
impostorscore=0 bulkscore=0
clxscore=1015 mlxlogscore=999 malwarescore=0 phishscore=0
lowpriorityscore=0 priorityscore=1501 mlxscore=0 spamscore=0 adultscore=0
suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc=
route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000
definitions=main-2504080110
|
| Series |
Add support for HEVC and VP9 codecs in decoder
|
expand
|
diff --git a/drivers/media/platform/qcom/iris/iris_hfi_queue.c b/drivers/media/platform/qcom/iris/iris_hfi_queue.c index fac7df0c4d1a..221dcd09e1e1 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_queue.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_queue.c @@ -113,7 +113,7 @@ int iris_hfi_queue_cmd_write_locked(struct iris_core *core, void *pkt, u32 pkt_s { struct iris_iface_q_info *q_info = &core->command_queue; - if (core->state == IRIS_CORE_ERROR) + if (core->state == IRIS_CORE_ERROR || core->state == IRIS_CORE_DEINIT) return -EINVAL; if (!iris_hfi_queue_write(q_info, pkt, pkt_size)) {
The current check only considers the core error state before allowing writes to the HFI queues. However, the core can also transition to the deinit state due to a system error triggered by the response thread. In such cases, writing to the HFI queues should not be allowed. Fix this by adding a check for the core deinit state, ensuring that writes are rejected when core is not in a valid state. Cc: stable@vger.kernel.org Fixes: fb583a214337 ("media: iris: introduce host firmware interface with necessary hooks") Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com> --- drivers/media/platform/qcom/iris/iris_hfi_queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)